Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2510
CI passed. Merge if no more discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2510
got it, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2510
@felixcheung It will because It converts ANSI codes whatever the content
format is.
And I intentionally made a change to convert TEXT format (of Zeppelin
output) only.
```js
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2510
Thanks @1ambda I also tested it, it works very well
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2510
Verified that this PR works on master with ipython interpreter. (See the
timestamp in the paragraph)
Merge if no more discussion.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2510
rebased to resolve conflict.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2510
@zjffdu Sorry for the late response. I can do in few hours. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2510
ping @1ambda
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2510
@1ambda I have merged #2474, can you rebase this PR ? Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2510
LG, I guess we go back to 2474 then
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2510
@zjffdu is right. This is based on #2474 as described in the PR
description. Please review last 2 commits except for @zjffdu's commits.
- 80ecfba
- dd97d00
---
If your project
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2510
I think @1ambda just want to verify this PR based my PR, @1ambda can rebase
this PR after #2474 is merged.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2510
@1ambda This PR includes some commits from
https://github.com/apache/zeppelin/pull/2474. Is it intended?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2510
Great, Thanks @1ambda
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2510
CI failed, but irrelevant. The error is related with Ipython which is going
on #2510
- https://api.travis-ci.org/jobs/259230939/log.txt?deansi=true
```
Results :
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/2510
AWESOME!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
16 matches
Mail list logo
