Github user jinxliu commented on the issue:
https://github.com/apache/zeppelin/pull/2645
@yiming187 I have made the changes and updated pull request. You can
review now.
---
Github user jinxliu commented on the issue:
https://github.com/apache/zeppelin/pull/2645
@zjffdu Thanks for your comments and review. There seems something wrong
with validating pull request.
---
Github user jinxliu commented on the issue:
https://github.com/apache/zeppelin/pull/2645
@zjffdu the CI checks seems to get stuck, even after rebase.
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2645
Thanks @jinxliu wait for CI pass and will merge if no more comments
---
Github user jinxliu commented on the issue:
https://github.com/apache/zeppelin/pull/2645
@zjffdu please review. Thanks.
---
Github user jinxliu commented on the issue:
https://github.com/apache/zeppelin/pull/2645
@zjffdu sure, kylin interpreter has unit test class, and I will add the
test when result set is empty.
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2645
Thanks @jinxliu does kylin has some utility class for integration test ?
Very few people in community has experience of kylin, it is better to have test
for the bug fix and avoid regression
---
Github user jinxliu commented on the issue:
https://github.com/apache/zeppelin/pull/2645
@zjffdu @felixcheung can you please review? I have rebased and created this
new pull request. [was https://github.com/apache/zeppelin/pull/2634]. Thanks
for your time!
---
