[GitHub] zeppelin issue #2675: [ZEPPELIN-3060] Unable to use interpreter names with s...

2017-11-28 Thread weand
Github user weand commented on the issue: https://github.com/apache/zeppelin/pull/2675 Closed and created https://issues.apache.org/jira/browse/ZEPPELIN-3083 instead. ---

[GitHub] zeppelin issue #2675: [ZEPPELIN-3060] Unable to use interpreter names with s...

2017-11-21 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2675 Good point @weand , We should validate the interpreter name when creating new interpreter. ---

[GitHub] zeppelin issue #2675: [ZEPPELIN-3060] Unable to use interpreter names with s...

2017-11-21 Thread weand
Github user weand commented on the issue: https://github.com/apache/zeppelin/pull/2675 Well, the current implementation does not enforce any naming pattern when creating a new interpreter. Before ZEPPELIN-3013 interpreters with any characters e.g. - could be created and execu

[GitHub] zeppelin issue #2675: [ZEPPELIN-3060] Unable to use interpreter names with s...

2017-11-21 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2675 '_' is acceptable in interpreter name and current code support that I believe. But `-` is not acceptable IMHO, because no programming language allow `-` in variable identifier IIRC. ---

[GitHub] zeppelin issue #2675: [ZEPPELIN-3060] Unable to use interpreter names with s...

2017-11-18 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2675 well, IMHO `-` and `_` are very common in programming languages too (eg. python) I think it's reasonable to accept these two in names. Not sure about other characters though, `(` c

[GitHub] zeppelin issue #2675: [ZEPPELIN-3060] Unable to use interpreter names with s...

2017-11-16 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2675 @weand In ZEPPELIN-3013, I try to make interpreter name only contains alphabet ,number and under score, just like valid variable name in most of programing languages. Is it necessary and normal for