[GitHub] zeppelin issue #2685: Fix unqiue algo for the web side in pivot.js file.

2017-11-26 Thread liguohuicmss
Github user liguohuicmss commented on the issue: https://github.com/apache/zeppelin/pull/2685 @felixcheung Thank you very much. I have add the unit test as you pointing ---

[GitHub] zeppelin issue #2685: Fix unqiue algo for the web side in pivot.js file.

2017-11-25 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2685 thanks, that's useful. could you look into if we could add a test in https://github.com/apache/zeppelin/blob/master/zeppelin-web/src/app/tabledata/tabledata.test.js ? ---

[GitHub] zeppelin issue #2685: Fix unqiue algo for the web side in pivot.js file.

2017-11-24 Thread liguohuicmss
Github user liguohuicmss commented on the issue: https://github.com/apache/zeppelin/pull/2685 Hello @felixcheung , I have add the test above. Can you review this patch for me? Thank you. ---

[GitHub] zeppelin issue #2685: Fix unqiue algo for the web side in pivot.js file.

2017-11-23 Thread liguohuicmss
Github user liguohuicmss commented on the issue: https://github.com/apache/zeppelin/pull/2685 Thanks. The test is as following. First. When dragging item in chart settings. The item `still` cannot duplicated in the same groups: ![untitled project](https://user-images.githubuse