[GitHub] zeppelin issue #2709: ZEPPELIN-3111. Refactor SparkInterpreter

Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2709 Thanks @alonshoham Feel free to create a PR for that issue ---

[GitHub] zeppelin issue #2709: ZEPPELIN-3111. Refactor SparkInterpreter

Github user alonshoham commented on the issue: https://github.com/apache/zeppelin/pull/2709 Your commit looks OK. Notice that I mentioned another problem in the ticket with interpreter.cmd On Wed, Oct 3, 2018 at 9:55 AM Jeff Zhang wrote: > @alonshoham

[GitHub] zeppelin issue #2709: ZEPPELIN-3111. Refactor SparkInterpreter

Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2709 @alonshoham Sorry I didn't notice you created the ticket, I have fixed via this commit, https://github.com/apache/zeppelin/commit/8b2f4a7bd89aa69661e09ef9ad73c04d862029ff Could you help ve

[GitHub] zeppelin issue #2709: ZEPPELIN-3111. Refactor SparkInterpreter

Github user alonshoham commented on the issue: https://github.com/apache/zeppelin/pull/2709 Hi I have created a JIRA iisue and corrected this locally. I cannot push my local branch to github so I cannot create the PR. How do i complete this process? On Thu, Sep 27,

[GitHub] zeppelin issue #2709: ZEPPELIN-3111. Refactor SparkInterpreter

Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2709 Thanks @alonshoham feel free to create a PR for that. ---

[GitHub] zeppelin issue #2709: ZEPPELIN-3111. Refactor SparkInterpreter

Github user alonshoham commented on the issue: https://github.com/apache/zeppelin/pull/2709 In this PR a change was made to `bin/interpreter.sh` script. In line 124 `SPARK_APP_JAR="$(ls ${ZEPPELIN_HOME}/interpreter/spark/spark-interpreter*.jar)"` used to be `SPARK_APP_JAR="$(ls ${ZEP

[GitHub] zeppelin issue #2709: ZEPPELIN-3111. Refactor SparkInterpreter

Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2709 Thanks @Leemoonsoo , will merge it if no more comments ---

[GitHub] zeppelin issue #2709: ZEPPELIN-3111. Refactor SparkInterpreter

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2709 Thanks @zjffdu for explain. Looks good to me. ---

[GitHub] zeppelin issue #2709: ZEPPELIN-3111. Refactor SparkInterpreter

Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2709 @Leemoonsoo binary package is the same as before, spark/scala-2.11 and spark/scala-2.10 will be packaged together into `spark-interpreter-0.8.0-SNAPSHOT.jar` which doesn't contain scala library. s

[GitHub] zeppelin issue #2709: ZEPPELIN-3111. Refactor SparkInterpreter

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2709 in the binary package, how spark/scala-2.11 and spark/scala-2.10 modules will be packaged? ---

[GitHub] zeppelin issue #2709: ZEPPELIN-3111. Refactor SparkInterpreter

Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2709 @Leemoonsoo @felixcheung @prabhjyotsingh @jongyoul Could you help review it ? Thanks ---