[GitHub] zeppelin issue #2894: ZEPPELIN-3364. Followup of ZEPPELIN-3362, improve Zepp...

2018-03-29 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2894 Will merge if no more comments ---

[GitHub] zeppelin issue #2894: ZEPPELIN-3364. Followup of ZEPPELIN-3362, improve Zepp...

2018-03-28 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2894 ok thanks ---

[GitHub] zeppelin issue #2894: ZEPPELIN-3364. Followup of ZEPPELIN-3362, improve Zepp...

2018-03-27 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2894 @zjffdu sure, I've created a new JIRA https://issues.apache.org/jira/browse/ZEPPELIN-3369 ---

[GitHub] zeppelin issue #2894: ZEPPELIN-3364. Followup of ZEPPELIN-3362, improve Zepp...

2018-03-27 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2894 @felixcheung comments are addressed except #2890 (comment) which I plan to do in separate PR as it is not a trivial change I believe. ---

[GitHub] zeppelin issue #2894: ZEPPELIN-3364. Followup of ZEPPELIN-3362, improve Zepp...

2018-03-26 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2894 @prabhjyotsingh Do you mean ZeppelinServer will get the append event after the paragraph is completed ? ---

[GitHub] zeppelin issue #2894: ZEPPELIN-3364. Followup of ZEPPELIN-3362, improve Zepp...

2018-03-26 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2894 Thanks @zjffdu cc @prabhjyotsingh - you were saying in [a comment for ZEPPELIN-3292](https://issues.apache.org/jira/browse/ZEPPELIN-3292?focusedCommentId=16387420&page=com.atlassian.jira.pl

[GitHub] zeppelin issue #2894: ZEPPELIN-3364. Followup of ZEPPELIN-3362, improve Zepp...

2018-03-26 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2894 @felixcheung Mind to help review it ? Thanks ---