Github user weand commented on the issue:
https://github.com/apache/zeppelin/pull/2925
great. LGTM :+1: please merge to master and branch-0.8
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2925
Thanks @weand for review, comments are addressed
---
Github user weand commented on the issue:
https://github.com/apache/zeppelin/pull/2925
@zjffdu uhm, I can't confirm it. Today after checking out this PR from
scratch my first point now works correctly. sorry for the spam.
created issue
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2925
@weand I don't the first issue you mentioned, can you confirm that ?
For the second point, I am afraid this is not trivial to fix, I would
suggest to defer it to 0.8.1 or 0.9, what do you
Github user mebelousov commented on the issue:
https://github.com/apache/zeppelin/pull/2925
@weand Thank you!
Some addition to 2.
Over time user may not belong to group.
At first we could store cronExecutingRoles and in future it's to be good to
check groups on the fly.
Github user weand commented on the issue:
https://github.com/apache/zeppelin/pull/2925
The notebook now runs successfully after restart with the user who enabled
the scheduler.
2 remaining issues:
1) user1 schedules the cron. then the note is executed via cron with
Github user weand commented on the issue:
https://github.com/apache/zeppelin/pull/2925
The notebook now runs successfully after restart with the user who enabled
the scheduler.
There is one more valid use case left in my mind (dealing with permissions):
- interpreter
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2925
Thanks @weand , I agree with you that your proposal seems much easier. I
have updated the PR, please help verify it, thanks
---
Github user weand commented on the issue:
https://github.com/apache/zeppelin/pull/2925
@mebelousov I fully agree that running document as the group is not what a
user would expect.
That's why I'm proposing another approach again:
1) prior to #2914 the cronExecutionUser
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2925
I am saying using group is not good, it just depends on user's setting.
BTW, it looks like this PR also works for your scenario. In this PR, I would
always choose the owner to run the cronjob. And
Github user mebelousov commented on the issue:
https://github.com/apache/zeppelin/pull/2925
@zjffdu This is your solution ;) I have tested your branch.
Do we have uniform opinion that running document as the group is not good?
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2925
@mebelousov Your solution depends on shiro setting, we could not assume
that in code.
---
Github user mebelousov commented on the issue:
https://github.com/apache/zeppelin/pull/2925
@weand cronExecutionUser is set to the user who set the cron string inside
the note.
@zjffdu I define groups in shiro.ini.
The user sets groupname in owner field. Then the note runs on
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2925
@mebelousov What do you mean `group as owner` ? And how do you use that ?
---
Github user weand commented on the issue:
https://github.com/apache/zeppelin/pull/2925
and optionally (or alternatively) introduce a config parameter for a static
cronExecutionUser (kind of service user) to be defined by ops team. when this
config parameter is set, cron schedules
Github user weand commented on the issue:
https://github.com/apache/zeppelin/pull/2925
@zjffdu is there a chance to set the cronExecutionUser implictly to the
user who activates the cron schedule.
and in addtion only allow owners (which can be defined by username or
groupnames)
Github user mebelousov commented on the issue:
https://github.com/apache/zeppelin/pull/2925
@zjffdu I have checked with group as owner. This is ok.
Why do you think that use of owner is more secure than cronExecutingUser?
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2925
@mebelousov Currently I would only allow note owner to set the schedule and
run cron job via the owner. But seems zeppelin allow multiple owners for one
note (it doesn't make sense to me), this is
Github user mebelousov commented on the issue:
https://github.com/apache/zeppelin/pull/2925
Groups can be note owners. As I see `AuthenticationInfo` is not valid for
internal shiro groups.
How can I find the user which scheduled note?
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2925
Update the PR to run the cron job as the note owner
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2925
Thanks @weand , even I didn't realize the user in note.json means the last
user run the paragraph (I thought it is the owner). In that case, it seems
meaningless to store user in note.json IMHO.
Github user weand commented on the issue:
https://github.com/apache/zeppelin/pull/2925
so running via cron will use the last user that executed a paragraph. that
does not fit exactly to the docu change from original PR:
> Cron executing user (It is removed from 0.8 where it
Github user r-kamath commented on the issue:
https://github.com/apache/zeppelin/pull/2925
LGTM
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2925
@felixcheung Mind to help review it ?
---
24 matches
Mail list logo
