[GitHub] zeppelin issue #3015: [ZEPPELIN-3490] Yarn cluster mode doesn't work with de...

Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/3015 https://travis-ci.org/jongyoul/zeppelin/builds/399878754 ---

[GitHub] zeppelin issue #3015: [ZEPPELIN-3490] Yarn cluster mode doesn't work with de...

Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/3015 @felixcheung Fixed all you commented. Will merge if there's no more discussion ---

[GitHub] zeppelin issue #3015: [ZEPPELIN-3490] Yarn cluster mode doesn't work with de...

Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/3015 Oh... missed. Will fix it. ---

[GitHub] zeppelin issue #3015: [ZEPPELIN-3490] Yarn cluster mode doesn't work with de...

Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/3015 how about this https://github.com/apache/zeppelin/pull/3015#discussion_r194955050 and https://github.com/apache/zeppelin/pull/3015#discussion_r194955106? ---

[GitHub] zeppelin issue #3015: [ZEPPELIN-3490] Yarn cluster mode doesn't work with de...

Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3015 LGTM, thanks ---

[GitHub] zeppelin issue #3015: [ZEPPELIN-3490] Yarn cluster mode doesn't work with de...

Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/3015 Yes, of course :-) ---

[GitHub] zeppelin issue #3015: [ZEPPELIN-3490] Yarn cluster mode doesn't work with de...

Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3015 @jongyoul Can you just wait a moment ? I will look at it soon. ---

[GitHub] zeppelin issue #3015: [ZEPPELIN-3490] Yarn cluster mode doesn't work with de...

Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/3015 Will merge if there's no discussion ---

[GitHub] zeppelin issue #3015: [ZEPPELIN-3490] Yarn cluster mode doesn't work with de...

Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/3015 @zjffdu I've checked `spark.jars` kept. 

[GitHub] zeppelin issue #3015: [ZEPPELIN-3490] Yarn cluster mode doesn't work with de...

Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/3015 @felixcheung AFAIK, in `yarn-client` mode, a job is created from scripts and added dependencies when making the job from a driver. Thus those jars are propagated to executors. In case of

[GitHub] zeppelin issue #3015: [ZEPPELIN-3490] Yarn cluster mode doesn't work with de...

Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/3015 @felixcheung @zjffdu I'll address this after next Wednesday. :-) ---

[GitHub] zeppelin issue #3015: [ZEPPELIN-3490] Yarn cluster mode doesn't work with de...

Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3015 What will happen if user also specify jars via `spark.jars` ? Would that override `--jars` or combine with it ? ---

[GitHub] zeppelin issue #3015: [ZEPPELIN-3490] Yarn cluster mode doesn't work with de...

Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/3015 Please review this PR https://travis-ci.org/jongyoul/zeppelin/builds/390350342 ---