[GitHub] zeppelin issue #3117: [ZEPPELIN-3691] Scheduled note continues to work in th...

2018-08-21 Thread oxygen311
Github user oxygen311 commented on the issue: https://github.com/apache/zeppelin/pull/3117 @zjffdu Sorry, you are right. Fixed ---

[GitHub] zeppelin issue #3117: [ZEPPELIN-3691] Scheduled note continues to work in th...

2018-08-20 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3117 No, it is compilation error. ``` [WARNING]

[GitHub] zeppelin issue #3117: [ZEPPELIN-3691] Scheduled note continues to work in th...

2018-08-20 Thread oxygen311
Github user oxygen311 commented on the issue: https://github.com/apache/zeppelin/pull/3117 @zjffdu Looks like it's some bug with dependencies in master: `[ERROR] SLF4J: Class path contains multiple SLF4J bindings.` ---

[GitHub] zeppelin issue #3117: [ZEPPELIN-3691] Scheduled note continues to work in th...

2018-08-20 Thread oxygen311
Github user oxygen311 commented on the issue: https://github.com/apache/zeppelin/pull/3117 @zjffdu resolved ---

[GitHub] zeppelin issue #3117: [ZEPPELIN-3691] Scheduled note continues to work in th...

2018-08-20 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3117 @oxygen311 Could you fix the conflict ? ---

[GitHub] zeppelin issue #3117: [ZEPPELIN-3691] Scheduled note continues to work in th...

2018-08-17 Thread oxygen311
Github user oxygen311 commented on the issue: https://github.com/apache/zeppelin/pull/3117 @zjffdu [Current Travis build](https://travis-ci.org/TinkoffCreditSystems/zeppelin/builds/416851939) ---

[GitHub] zeppelin issue #3117: [ZEPPELIN-3691] Scheduled note continues to work in th...

2018-08-16 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3117 LGTM, @oxygen311 Can you paste your travis link ? I can not find it, maybe there's something wrong with the integration of jenkins. ---

[GitHub] zeppelin issue #3117: [ZEPPELIN-3691] Scheduled note continues to work in th...

2018-08-16 Thread oxygen311
Github user oxygen311 commented on the issue: https://github.com/apache/zeppelin/pull/3117 @zjffdu Added ---

[GitHub] zeppelin issue #3117: [ZEPPELIN-3691] Scheduled note continues to work in th...

2018-08-15 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3117 Thanks @oxygen311 Could you add any unit test ? ---

[GitHub] zeppelin issue #3117: [ZEPPELIN-3691] Scheduled note continues to work in th...

2018-08-15 Thread oxygen311
Github user oxygen311 commented on the issue: https://github.com/apache/zeppelin/pull/3117 @zjffdu So, I moved this check to `refreshCron()` method ---

[GitHub] zeppelin issue #3117: [ZEPPELIN-3691] Scheduled note continues to work in th...

2018-08-15 Thread oxygen311
Github user oxygen311 commented on the issue: https://github.com/apache/zeppelin/pull/3117 @felixcheung I have amended commit for checking is note in trash. ---