[GitHub] zeppelin issue #984: [ZEPPELIN-982] Improve interpreter completion API

2016-06-15 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/984 Thanks @AhyoungRyu for the improvement and taking care of comments. LGTM. Merge it into master and 0.6 branch if there're no more discussions. --- If your project is set up for it, you

[GitHub] zeppelin issue #984: [ZEPPELIN-982] Improve interpreter completion API

2016-06-13 Thread bzz
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/984 @AhyoungRyu there are 2 different test failures on CI here: **Integration test** fails https://s3.amazonaws.com/archive.travis-ci.org/jobs/137185986/log.txt ``` Tests in error:

[GitHub] zeppelin issue #984: [ZEPPELIN-982] Improve interpreter completion API

2016-06-11 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/984 @AhyoungRyu I see. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] zeppelin issue #984: [ZEPPELIN-982] Improve interpreter completion API

2016-06-10 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/984 @AhyoungRyu What the `value` of InterpreterCompletion means? And I suggest we remove the mark abstract from Interpreter class because almost interpreter returns empty list and it's better to