[GitHub] zeppelin issue #1780: [BugFix] Tutorial note json format.

2016-12-21 Thread astroshim
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1780 @AhyoungRyu Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] zeppelin issue #1780: [BugFix] Tutorial note json format.

2016-12-21 Thread astroshim
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1780 CI has passed after rebase. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin pull request #1735: [ZEPPELIN-1767] Blank paragraph should not be r...

2016-12-07 Thread astroshim
GitHub user astroshim opened a pull request: https://github.com/apache/zeppelin/pull/1735 [ZEPPELIN-1767] Blank paragraph should not be run. ### What is this PR for? This PR fixes not to run blank paragraph. ### What type of PR is it? Improvement

[GitHub] zeppelin pull request #1780: [BugFix] Tutorial note json format.

2016-12-16 Thread astroshim
GitHub user astroshim opened a pull request: https://github.com/apache/zeppelin/pull/1780 [BugFix] Tutorial note json format. ### What is this PR for? Since https://github.com/apache/zeppelin/pull/1658, the output format had changed but note.json of Tutorials didn't changed

[GitHub] zeppelin issue #1777: [ZEPPELIN-1831] Fix paragraph control dropdown alignme...

2016-12-16 Thread astroshim
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1777 Thanks for contribution! Looks great to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #2106: [WIP] Rewrite PythonInterpreter.

2017-03-15 Thread astroshim
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/2106 @Leemoonsoo fixed the issues you commented and added PandasSql. and also added `conda`, `pandasql` interpreter test on PR description. --- If your project is set up for it, you can reply

[GitHub] zeppelin pull request #2106: [WIP] Rewrite PythonInterpreter.

2017-03-14 Thread astroshim
GitHub user astroshim reopened a pull request: https://github.com/apache/zeppelin/pull/2106 [WIP] Rewrite PythonInterpreter. ### What is this PR for? I've been testing the python interpreter and I found at least 4 major issues in the current python interpreter. 1

[GitHub] zeppelin pull request #2106: [WIP] Rewrite PythonInterpreter.

2017-03-14 Thread astroshim
Github user astroshim closed the pull request at: https://github.com/apache/zeppelin/pull/2106 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin issue #2192: [ZEPPELIN-2320] fixing test + modifying map browsing

2017-04-04 Thread astroshim
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/2192 @Remilito Could you make this PR based on `branch-0.7` branch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin issue #2207: [Zeppelin-802] Support for Zeppelin Context redefiniti...

2017-03-30 Thread astroshim
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/2207 @cloverhearts It looks also great! 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #2192: [ZEPPELIN-2320] fixing test + modifying map browsing

2017-04-06 Thread astroshim
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/2192 @Remilito Could you make this PR based on branch-0.7 branch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin issue #2106: [WIP] Rewrite PythonInterpreter.

2017-03-09 Thread astroshim
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/2106 @Leemoonsoo thanks for reviewing.. Let me fix the issues you commented and add PandasSql. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] zeppelin issue #1985: [ZEPPELIN-2075] Can't stop infinite `while` statement ...

2017-03-04 Thread astroshim
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1985 @FireArrow Thank you for confirm your idea and thank @zjffdu help to review! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] zeppelin issue #2106: Rewrite PythonInterpreter.

2017-03-08 Thread astroshim
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/2106 I just added conda interpreter. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin pull request #2106: Py4j python interpreter

2017-03-07 Thread astroshim
GitHub user astroshim opened a pull request: https://github.com/apache/zeppelin/pull/2106 Py4j python interpreter ### What is this PR for? I've been testing the python interpreter and I found at least 4 major issues in the current python interpreter. 1. not working

[GitHub] zeppelin issue #2106: Rewrite PythonInterpreter.

2017-03-07 Thread astroshim
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/2106 @zjffdu Thank you for your opinion! Of course i checked #1495 and I totally agree of extensibility for python interpreter. but As you can see, current python interpreter has lots

[GitHub] zeppelin issue #2080: [ZEPPELIN-1964] Layout info is lost after refresh

2017-03-05 Thread astroshim
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/2080 @Leemoonsoo I did. thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin pull request #2080: [ZEPPELIN-1964] Layout info is lost after refre...

2017-03-05 Thread astroshim
Github user astroshim closed the pull request at: https://github.com/apache/zeppelin/pull/2080 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin pull request #2080: [ZEPPELIN-1964] Layout info is lost after refre...

2017-02-28 Thread astroshim
GitHub user astroshim opened a pull request: https://github.com/apache/zeppelin/pull/2080 [ZEPPELIN-1964] Layout info is lost after refresh ### What is this PR for? This PR is for `branch-0.7` of https://github.com/apache/zeppelin/pull/2053. ### What type of PR

[GitHub] zeppelin issue #2080: [ZEPPELIN-1964] Layout info is lost after refresh

2017-02-28 Thread astroshim
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/2080 @AhyoungRyu Could you help to review? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #2192: [ZEPPELIN-2320] fixing test + modifying map browsing

2017-04-04 Thread astroshim
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/2192 LGTM.. Sorry for late catch.. Merge if there is no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] zeppelin issue #2207: [Zeppelin-802] Support for Zeppelin Context redefiniti...

2017-03-30 Thread astroshim
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/2207 Looks great. one thing i worrying about is that the `_zc` can be possibly used by user easily? how about assigning more unique key word like `__zc__` ? --- If your project is set up

[GitHub] zeppelin issue #2428: [ZEPPELIN-1470] limiting results from jdbc

2017-07-14 Thread astroshim
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/2428 LGTM~ I think this PR can be merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #2343: [ZEPPELIN-2538] JDBC completer improvements for work w...

2017-05-24 Thread astroshim
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/2343 I think this feature is really cool. BTW I got following exception whenever i try to run sql completion. ``` ==> logs/zeppelin-interpreter-jdbc-jdbc.log <== ERROR [2017

[GitHub] zeppelin issue #2343: [ZEPPELIN-2538] JDBC completer improvements for work w...

2017-05-24 Thread astroshim
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/2343 @tinkoff-dwh Sorry it was my problem. Tested and working good! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin issue #2343: [ZEPPELIN-2538] JDBC completer improvements for work w...

2017-05-31 Thread astroshim
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/2343 @cloverhearts Did you test this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #2586: [ZEPPELIN-2930] Releasing session of JDBC interpreter ...

2017-09-15 Thread astroshim
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/2586 @felixcheung yeah.. it's similar but the differentiation is that the previous one couldn't solve the releasing connection issue perfectly. ---

[GitHub] zeppelin pull request #2581: Fix/jdbc connection release 0.7

2017-09-11 Thread astroshim
GitHub user astroshim opened a pull request: https://github.com/apache/zeppelin/pull/2581 Fix/jdbc connection release 0.7 ### What is this PR for? This PR fixes JDBC connection release problem. for example whenever i run not executable command like following

[GitHub] zeppelin pull request #2581: Fix/jdbc connection release 0.7

2017-09-11 Thread astroshim
Github user astroshim closed the pull request at: https://github.com/apache/zeppelin/pull/2581 ---

[GitHub] zeppelin issue #2586: [ZEPPELIN-2930] Releasing session of JDBC interpreter ...

2017-09-15 Thread astroshim
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/2586 @felixcheung This is not a subset of the other PR. ---

[GitHub] zeppelin pull request #2576: [hotfix] JDBC connection does not release when ...

2017-09-08 Thread astroshim
GitHub user astroshim opened a pull request: https://github.com/apache/zeppelin/pull/2576 [hotfix] JDBC connection does not release when got exception. ### What is this PR for? This PR fixes JDBC connection release problem. for example when i run not executable command

[GitHub] zeppelin pull request #2582: fixed jdbc connection issue.

2017-09-11 Thread astroshim
GitHub user astroshim opened a pull request: https://github.com/apache/zeppelin/pull/2582 fixed jdbc connection issue. ### What is this PR for? This PR fixes JDBC connection release problem. for example whenever i run not executable command like following ![image

[GitHub] zeppelin issue #2582: fixed jdbc connection issue.

2017-09-12 Thread astroshim
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/2582 CI fails seems not related to this PR ---

[GitHub] zeppelin pull request #2582: fixed jdbc connection issue.

2017-09-13 Thread astroshim
Github user astroshim closed the pull request at: https://github.com/apache/zeppelin/pull/2582 ---

[GitHub] zeppelin pull request #2586: [ZEPPELIN-2930] Releasing session of JDBC inter...

2017-09-13 Thread astroshim
GitHub user astroshim opened a pull request: https://github.com/apache/zeppelin/pull/2586 [ZEPPELIN-2930] Releasing session of JDBC interpreter close(). ### What is this PR for? This PR fixes that the session release issue of close() of JDBC interpreter. ### What type

<    1   2   3   4   5