[GitHub] incubator-zeppelin pull request: change runNote from event to func...

2015-07-28 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/171#issuecomment-125834126 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] incubator-zeppelin pull request: The user will be able to provide ...

2015-07-28 Thread corneadoug
Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/156#issuecomment-125831645 Thanks for the changes, I will check the code and test it again :) --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] incubator-zeppelin pull request: ZEPPELIN-172 Websocket connection...

2015-07-28 Thread corneadoug
Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/170#issuecomment-125831519 There is a couple of other things related to Websocket, do you think this could be handled in this PR too? Security: https://issues.apache.org/jira/browse

[GitHub] incubator-zeppelin pull request: README typo, build profile additi...

2015-07-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/166 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] incubator-zeppelin pull request: change runNote from event to func...

2015-07-28 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/171#issuecomment-125828781 looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-zeppelin pull request: README typo, build profile additi...

2015-07-28 Thread jongyoul
Github user jongyoul commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/166#issuecomment-125801748 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] incubator-zeppelin pull request: add save button to paragraph

2015-07-28 Thread nberserk
Github user nberserk commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/168#issuecomment-125786055 ![screen shot 2015-07-29 at 9 04 55](https://cloud.githubusercontent.com/assets/900639/8947018/f515da00-35d0-11e5-990f-4886312d91a4.png) flag icon a

[GitHub] incubator-zeppelin pull request: change runNote from event to func...

2015-07-28 Thread minahlee
Github user minahlee commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/171#issuecomment-125782879 Tested and LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] incubator-zeppelin pull request: README typo, build profile additi...

2015-07-28 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/166#issuecomment-125776537 Looks good to me! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] incubator-zeppelin pull request: ZEPPELIN-172 Websocket connection...

2015-07-28 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/170#issuecomment-125775869 Ready to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[jira] [Created] (ZEPPELIN-190) Add File browser

2015-07-28 Thread Raj Bains (JIRA)
Raj Bains created ZEPPELIN-190: -- Summary: Add File browser Key: ZEPPELIN-190 URL: https://issues.apache.org/jira/browse/ZEPPELIN-190 Project: Zeppelin Issue Type: New Feature Affects Version

[jira] [Created] (ZEPPELIN-189) Add Apache Geode Interpreter for Zeppelin

2015-07-28 Thread Christian Tzolov (JIRA)
Christian Tzolov created ZEPPELIN-189: - Summary: Add Apache Geode Interpreter for Zeppelin Key: ZEPPELIN-189 URL: https://issues.apache.org/jira/browse/ZEPPELIN-189 Project: Zeppelin Issu

[GitHub] incubator-zeppelin pull request: The user will be able to provide ...

2015-07-28 Thread Karuppayya
Github user Karuppayya commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/156#issuecomment-125550534 @corneadoug Thanks for letting me know. Sorry about the bad merge earlier. Found couple of js warnings during build time, fixed them as well. ---

[GitHub] incubator-zeppelin pull request: change runNote from event to func...

2015-07-28 Thread corneadoug
Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/171#issuecomment-125547368 CI is green, just need one review :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] incubator-zeppelin pull request: The user will be able to provide ...

2015-07-28 Thread corneadoug
Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/156#issuecomment-125526608 If you close/reopen the PR, it will launch the CI --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[GitHub] incubator-zeppelin pull request: The user will be able to provide ...

2015-07-28 Thread Karuppayya
Github user Karuppayya commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/156#issuecomment-125520007 Apologies for the bad merge.(Yes, I did rebase ). The build error is as follows 09:06:59,470 INFO org.apache.commons.httpclient.HttpMethodDirector

[GitHub] incubator-zeppelin pull request: ZEPPELIN-70: Add PostgreSQL Inter...

2015-07-28 Thread tzolov
GitHub user tzolov opened a pull request: https://github.com/apache/incubator-zeppelin/pull/172 ZEPPELIN-70: Add PostgreSQL Interpreter modified: conf/zeppelin-site.xml.template modified: pom.xml new file: postgresql/pom.xml new file: postgresql/s

[GitHub] incubator-zeppelin pull request: change runNote from event to func...

2015-07-28 Thread corneadoug
GitHub user corneadoug opened a pull request: https://github.com/apache/incubator-zeppelin/pull/171 change runNote from event to function call When using events, we can't guarantee that the paragraphs will be executed in order, so we need to loop through the paragraphs and make them

[GitHub] incubator-zeppelin pull request: The user will be able to provide ...

2015-07-28 Thread corneadoug
Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/156#issuecomment-125503275 Tests are passing, but the commit history is weird (event in github graph). Also I guess you didn't rebase, ng-delete should not be there anymore ht

Re: Working on a PostgreSQL Interpreter for Zeppelin [ZEPPELIN-70]

2015-07-28 Thread Christian Tzolov
Hi Alexander, Thank you for the pointing me to the github's contributors page. The https://zeppelin.incubator.apache.org/docs/development/howtocontribute.html page that i read looks almost the same but it is missing the first paragraf explaning the commiter workflow. It also misses the codestyle r