[GitHub] incubator-zeppelin pull request: zeppelin-333:Notebook create, del...

2015-10-06 Thread corneadoug
Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/334#issuecomment-146078691 @eranwitkon I can see that :) No problem with API, those are actually useful to me too in some cases. It's just a more global comment about the choi

[GitHub] incubator-zeppelin pull request: zeppelin-333:Notebook create, del...

2015-10-06 Thread eranwitkon
Github user eranwitkon commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/334#issuecomment-146074254 I agree that we shouldn't expose just random API but these are not just any utility functions, this is working with notebooks from external applicat

[GitHub] incubator-zeppelin pull request: zeppelin-333:Notebook create, del...

2015-10-06 Thread corneadoug
Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/334#issuecomment-146057741 Does the Rest API also have the Allow-Origins restrictions? I got nothing against making more REST API calls, however those calls has to have a be

[GitHub] incubator-zeppelin pull request: Add bullet graph support

2015-10-06 Thread galleon
Github user galleon commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/336#issuecomment-145999863 How is that different from #312 - focus chart --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] incubator-zeppelin pull request: Add bullet graph support

2015-10-06 Thread deepujain
Github user deepujain commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/336#issuecomment-145973086 Including support for line with focus chart. https://cloud.githubusercontent.com/assets/406777/10319930/934afd10-6c25-11e5-992c-3f0d8851c050.png";>

[GitHub] incubator-zeppelin pull request: zeppelin-333:Notebook create, del...

2015-10-06 Thread eranwitkon
Github user eranwitkon commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/334#issuecomment-145960012 Ok, let's review this PR and merge it. I will open an additional JIRA issue for the content of the notebook and we will discuss options in it. Eran

[GitHub] incubator-zeppelin pull request: zeppelin-333:Notebook create, del...

2015-10-06 Thread vmakhaev
Github user vmakhaev commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/334#issuecomment-145942562 Yes, we can merge this and treat my comment as request for additional API. I think in general case we just want to get as much info about particular note

[GitHub] incubator-zeppelin pull request: zeppelin-333:Notebook create, del...

2015-10-06 Thread eranwitkon
Github user eranwitkon commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/334#issuecomment-145936956 First, I agree that if it is ok with you we should merge this one and have another one for the paragraph requirement. As I understand, you are OK

[GitHub] incubator-zeppelin pull request: zeppelin-333:Notebook create, del...

2015-10-06 Thread vmakhaev
Github user vmakhaev commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/334#issuecomment-145934391 Sorry, to be late, maybe I should open another issue. I have use case for GET /notebook/:notebookId. We have some pre-defined notebooks, which we disp

[GitHub] incubator-zeppelin pull request: ZEPPELIN-289: User can now enter ...

2015-10-06 Thread lucarosellini
Github user lucarosellini commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/320#issuecomment-145923135 Hi @bzz, this feature is unaware of the underlying interpreter the code is being sent to, no interpreter specific code has been changed. We've t

Re: [ANNOUNCE] Welcoming new Zeppelin PPMC and committer

2015-10-06 Thread Jongyoul Lee
Hi folks and Moon, Thanks for your kindness and I'm also so happy to contiribute this community. I hope Zeppelin will be the cutting edge platform for supporting all of another environments. Warm regards, JL On Saturday, 3 October 2015, moon soo Lee wrote: > Hi folks, > > The Apache Zeppelin P

[GitHub] incubator-zeppelin pull request: zeppelin-333:Notebook create dele...

2015-10-06 Thread eranwitkon
Github user eranwitkon commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/334#issuecomment-145831974 I just re-based on latest master and run test again. Ready for merge. --- If your project is set up for it, you can reply to this email and have your

[GitHub] incubator-zeppelin pull request: zeppelin-333:Notebook create dele...

2015-10-06 Thread eranwitkon
GitHub user eranwitkon reopened a pull request: https://github.com/apache/incubator-zeppelin/pull/334 zeppelin-333:Notebook create delete & clone REST API Initial implementation of createNote REST API. implementation overlap socket implementation, to minimal the effect for socke

[GitHub] incubator-zeppelin pull request: ZEPPELIN-289: User can now enter ...

2015-10-06 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/320#issuecomment-145819977 Looks interesting, thank you for contributing! Please help me to understand, am I right that these changes potentially affect all interpreter's syntax an

[GitHub] incubator-zeppelin pull request: zeppelin-333:Notebook create dele...

2015-10-06 Thread eranwitkon
Github user eranwitkon closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/334 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-zeppelin pull request: [Zeppelin-239] The elapsed time i...

2015-10-06 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/325#issuecomment-145818547 CI is failing on this PR. Usually having it green (or at least updating on why is it red) fosters the reviewers to review\accept changes much faster. You

[GitHub] incubator-zeppelin pull request: zeppelin-333:Notebook create dele...

2015-10-06 Thread eranwitkon
Github user eranwitkon commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/334#issuecomment-145817699 The above commit was already merged . I will remove it and rebase on latest. Tnx, בתאריך יום ג׳, 6 באוק׳ 2015, 13:31 מאת Ale

[GitHub] incubator-zeppelin pull request: zeppelin-333:Notebook create dele...

2015-10-06 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/334#issuecomment-145816809 For this PR to be merged faster, it should include only your commits, related to the described work. Are you sure 0cfa463 is one of them? --- If your proje

[GitHub] incubator-zeppelin pull request: Add Shift+Enter description to to...

2015-10-06 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/337#issuecomment-145816117 Good catch! Looks great to me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] incubator-zeppelin pull request: ZEPPELIN-335: Apache Pig interpre...

2015-10-06 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/338#issuecomment-145813137 Yes, tests and update for the [docs](http://zeppelin.incubator.apache.org/docs/development/howtocontributewebsite.html) will be great to see as part of this PR i

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-319]wait an additional ...

2015-10-06 Thread RPCMoritz
Github user RPCMoritz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/323#issuecomment-145782077 @corneadoug thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-319]wait an additional ...

2015-10-06 Thread RPCMoritz
GitHub user RPCMoritz reopened a pull request: https://github.com/apache/incubator-zeppelin/pull/323 [ZEPPELIN-319]wait an additional .5 seconds, if assertion will fail This test failed randomly during a build. To make sure this is not due to timing issues, we can optionally wait an

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-319]wait an additional ...

2015-10-06 Thread RPCMoritz
Github user RPCMoritz closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/323 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-zeppelin pull request: ZEPPELIN-307 Not is added a new e...

2015-10-06 Thread vgmartinez
Github user vgmartinez closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/296 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-319]wait an additional ...

2015-10-06 Thread corneadoug
Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/323#issuecomment-145777022 @RPCMoritz you can close and reopen this PR to trigger the CI again --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-319]wait an additional ...

2015-10-06 Thread RPCMoritz
Github user RPCMoritz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/323#issuecomment-145776128 Looks like npm-dependency-resolution broke the build - how can I trigger a re-check? (Ironic, that this happens, while I'm trying to stabilize the build ^^

[GitHub] incubator-zeppelin pull request: ZEPPELIN-335: Apache Pig interpre...

2015-10-06 Thread vgmartinez
Github user vgmartinez commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/338#issuecomment-145771668 Hi @abajwa-hw, Nice improvement... I think it would be nice implement the test...;) --- If your project is set up for it, you can reply to this em