[GitHub] incubator-zeppelin pull request: Add an Elasticsearch interpreter

2015-12-21 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/520#issuecomment-166230789 This is a good question boiling down how the build system resolve such conflicts at the build time, but that's our of scope of this PR I suppose. As for

[GitHub] incubator-zeppelin pull request: ZEPPELIN-312: fix a bug with bloc...

2015-12-21 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/558#issuecomment-166231490 CI failure logged under https://issues.apache.org/jira/browse/ZEPPELIN-525 --- If your project is set up for it, you can reply to this email and have your reply

[jira] [Created] (ZEPPELIN-525) Test failing in zeppelin-interpreter

2015-12-21 Thread Alexander Bezzubov (JIRA)
Alexander Bezzubov created ZEPPELIN-525: --- Summary: Test failing in zeppelin-interpreter Key: ZEPPELIN-525 URL: https://issues.apache.org/jira/browse/ZEPPELIN-525 Project: Zeppelin Issue

[GitHub] incubator-zeppelin pull request: Release resource after cron job.

2015-12-21 Thread astroshim
Github user astroshim commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/557#issuecomment-166234115 @bzz Thanks your feedback. Yes, "release resource" means restarting all binded interpreters on the note. I was thinking restarting the interpreters

[GitHub] incubator-zeppelin pull request: Add JDBC Interpreter for Mysql

2015-12-21 Thread jongyoul
Github user jongyoul commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/60#issuecomment-166234850 @1teed Now, I will try to contact @andrescelis to accept jdbc interpreter. I hope you would understand it. And please check the mailing(https://www.mail-arch

[GitHub] incubator-zeppelin pull request: added jdbc interpreter

2015-12-21 Thread jongyoul
Github user jongyoul commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/211#issuecomment-166240323 @andrescelis Hi, I'm Jongyoul Lee and trying to merge jdbc interpreters for Zeppelin. I saw this PR is the second trial for doing this. The first one is con

[GitHub] incubator-zeppelin pull request: Add an Elasticsearch interpreter

2015-12-21 Thread bbonnin
Github user bbonnin commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/520#issuecomment-166244559 For LICENCE issue, I have removed the library references that already exist with the same grouId/artifactId, if they have a different version and the same li

[GitHub] incubator-zeppelin pull request: Drag to resize paragraph

2015-12-21 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/516#issuecomment-166268360 Thanks @corneadoug for the feedback and a providing me with a lot of test cases. Have merged this with the latest master, which seems to solve the

[GitHub] incubator-zeppelin pull request: Prevent server calls when there i...

2015-12-21 Thread Karuppayya
GitHub user Karuppayya opened a pull request: https://github.com/apache/incubator-zeppelin/pull/559 Prevent server calls when there is no data in paragraphs *Whenever there is no text text in para, server call are made to run para. With this PR, the paras will be run only where

[GitHub] incubator-zeppelin pull request: ZEPPELIN-507 Expand "run paragrap...

2015-12-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/541 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] incubator-zeppelin pull request: ZEPPELIN-509 Introduce a new REST...

2015-12-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/542 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] incubator-zeppelin pull request: Install guide modifications based...

2015-12-21 Thread dcardon
Github user dcardon commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/543#issuecomment-166446141 Thanks, @jeffsteinmetz! I didn't know that guide existed. I did run into issues running this on Windows, but eventually this does work (after manual Ansibl

[GitHub] incubator-zeppelin pull request: Add finish alert with blinking ta...

2015-12-21 Thread Stefan9149
GitHub user Stefan9149 opened a pull request: https://github.com/apache/incubator-zeppelin/pull/560 Add finish alert with blinking tab title Users may have pending/running tasks and do not want to keep focusing on the web page. This feature sends a simple notification in the fo

[jira] [Created] (ZEPPELIN-526) Add a (local mode) Scalding Interpreter to Zeppelin

2015-12-21 Thread Sriram Krishnan (JIRA)
Sriram Krishnan created ZEPPELIN-526: Summary: Add a (local mode) Scalding Interpreter to Zeppelin Key: ZEPPELIN-526 URL: https://issues.apache.org/jira/browse/ZEPPELIN-526 Project: Zeppelin

[GitHub] incubator-zeppelin pull request: Install guide modifications based...

2015-12-21 Thread jeffsteinmetz
Github user jeffsteinmetz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/543#issuecomment-166465873 We could reference this VM guide earlier in the Zeppelin documentation. Let me know if you think there is a documentation location at the top of the p

[GitHub] incubator-zeppelin pull request: Add a (local mode) Scalding Inter...

2015-12-21 Thread sriramkrishnan
GitHub user sriramkrishnan opened a pull request: https://github.com/apache/incubator-zeppelin/pull/561 Add a (local mode) Scalding Interpreter to Zeppelin ### What is this PR for? Scalding (https://github.com/twitter/scalding) is a Scala library for writing MapReduce jobs.

[GitHub] incubator-zeppelin pull request: ZEPPELIN-511 REST API: Insert / R...

2015-12-21 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/550#issuecomment-166469145 Upmerged. Please take a look again, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[jira] [Created] (ZEPPELIN-527) REST API: 'get notebook job' API returns status 500 when one or more paragraphs are not started or finished

2015-12-21 Thread Jungtaek Lim (JIRA)
Jungtaek Lim created ZEPPELIN-527: - Summary: REST API: 'get notebook job' API returns status 500 when one or more paragraphs are not started or finished Key: ZEPPELIN-527 URL: https://issues.apache.org/jira/browse

[GitHub] incubator-zeppelin pull request: Add an Elasticsearch interpreter

2015-12-21 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/520#issuecomment-166488973 Looks great to me. Thank you for awesome contribution with test & docs \w screenshots! --- If your project is set up for it, you can reply to this email and

[GitHub] incubator-zeppelin pull request: Add a (local mode) Scalding Inter...

2015-12-21 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/561#issuecomment-166489064 @sriramkrishnan could you please also add some docs for the new interpreter here http://zeppelin.incubator.apache.org/docs/0.6.0-incubating-SNAPSHOT/interpreter/

[GitHub] incubator-zeppelin pull request: Add finish alert with blinking ta...

2015-12-21 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/560#issuecomment-166501512 Great stuff! Page title is important way to communicate to user indeed. @Stefan9149 There are couple of things you can do to make a contribution be accep

[GitHub] incubator-zeppelin pull request: ZEPPELIN-527 Fix NPE while retrie...

2015-12-21 Thread HeartSaVioR
GitHub user HeartSaVioR opened a pull request: https://github.com/apache/incubator-zeppelin/pull/562 ZEPPELIN-527 Fix NPE while retrieving job status from notebook ### What is this PR for? Fix NPE while retrieving job status from notebook which contains "never run" / "first

[GitHub] incubator-zeppelin pull request: ZEPPELIN-527 Fix NPE while retrie...

2015-12-21 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/562#issuecomment-166502717 There seems to some preference, representing null value. If we think it would be better to represent null value as below, ``` { "s

[GitHub] incubator-zeppelin pull request: ZEPPELIN-527 Fix NPE while retrie...

2015-12-21 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/562#issuecomment-166504216 The fix looks good to me! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[jira] [Created] (ZEPPELIN-528) REST API: add "progress" to 'get notebook job' API

2015-12-21 Thread Jungtaek Lim (JIRA)
Jungtaek Lim created ZEPPELIN-528: - Summary: REST API: add "progress" to 'get notebook job' API Key: ZEPPELIN-528 URL: https://issues.apache.org/jira/browse/ZEPPELIN-528 Project: Zeppelin Iss

[GitHub] incubator-zeppelin pull request: ZEPPELIN-527 Fix NPE while retrie...

2015-12-21 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/562#issuecomment-166504962 @Leemoonsoo Thanks for the review! Regarding preference, do you think we should include null field to JSON, or leave as it is? --- If your proj

[GitHub] incubator-zeppelin pull request: Prevent server calls when there i...

2015-12-21 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/559#issuecomment-166505477 Tested and found 'Cannot run an empty paragraph ' message does not raise with 'Shift+Enter' shortcut. By the way, I thought running empty paragrap

[GitHub] incubator-zeppelin pull request: ZEPPELIN-527 Fix NPE while retrie...

2015-12-21 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/562#issuecomment-166507478 I think it's okay to leave it as is. But which do you think better? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] incubator-zeppelin pull request: ZEPPELIN-527 Fix NPE while retrie...

2015-12-21 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/562#issuecomment-166507936 At first I expect that null value from Map could be represented as null value to JSON, but it is not represented as I expected. Anyway, it is just a p

[GitHub] incubator-zeppelin pull request: ZEPPELIN-312: fix a bug with bloc...

2015-12-21 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/558#issuecomment-166508540 CI passes now, @anthonycorbacho review was addressed in bbbf8ae --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] incubator-zeppelin pull request: ZEPPELIN-312: fix a bug with bloc...

2015-12-21 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/558#issuecomment-166509036 +1 Let's merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] incubator-zeppelin pull request: ZEPPELIN-312: fix a bug with bloc...

2015-12-21 Thread zenglinxi0615
Github user zenglinxi0615 commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/558#issuecomment-166514034 @bzz ,sorry for my late response, and thanks for your work, it looks good for me! --- If your project is set up for it, you can reply to this email an

[GitHub] incubator-zeppelin pull request: Add firebug and firepath for debu...

2015-12-21 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/490#issuecomment-166516436 @Leemoonsoo @corneadoug @r-kamath rebased. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] incubator-zeppelin pull request: ZEPPELIN-528 REST API: add "progr...

2015-12-21 Thread HeartSaVioR
GitHub user HeartSaVioR opened a pull request: https://github.com/apache/incubator-zeppelin/pull/563 ZEPPELIN-528 REST API: add "progress" to 'get notebook job' API ### What is this PR for? To add 'progress' to 'get notebook job' REST API. All paragraphs which status is

[GitHub] incubator-zeppelin pull request: ZEPPELIN-528 REST API: add "progr...

2015-12-21 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/563#issuecomment-166528935 Two questions here, - Can I trap RUNNING status of the paragraph in UT? I don't have an idea to make it, so I can't add UT for now. - Would i

[GitHub] incubator-zeppelin pull request: Prevent server calls when there i...

2015-12-21 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/559#issuecomment-166534240 Could you change the description to follow our PR Template? (you can find it [here] (https://github.com/apache/incubator-zeppelin/blob/master/CONTR

[GitHub] incubator-zeppelin pull request: Add finish alert with blinking ta...

2015-12-21 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/560#issuecomment-166534387 Could you change the description to follow our PR Template? (you can find it [here] (https://github.com/apache/incubator-zeppelin/blob/master/CONTR

[GitHub] incubator-zeppelin pull request: ZEPPELIN-312: fix a bug with bloc...

2015-12-21 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/558#issuecomment-166541118 Cool, thank you for your kind feedback guys! Merging if there is no further discussion. --- If your project is set up for it, you can reply to this email an

[GitHub] incubator-zeppelin pull request: ZEPPELIN-312: fix a bug with bloc...

2015-12-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/558 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] incubator-zeppelin pull request: ZEPPELIN-312: use threadpoll to d...

2015-12-21 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/319#issuecomment-166541998 @zenglinxi0615 if you think it's fine, may be we should close this one now --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] incubator-zeppelin pull request: adding shadow to navbar if noteAc...

2015-12-21 Thread prabhjyotsingh
GitHub user prabhjyotsingh opened a pull request: https://github.com/apache/incubator-zeppelin/pull/564 adding shadow to navbar if noteActionBar is not present ### What is this PR for? This PR adds shadow to navbar if noteActionBar is not present ### What type of PR is i