Re: Regarding job status between current and the latest

2015-12-22 Thread Jungtaek Lim
Alexander, Thanks for the quick comment! As you may already know, null value is just a initial value of the date. Changing date to initial value should not hurt if initial value doesn't hurt now. Again, I love to have Option but Zeppelin uses Java so we may want to just adapt ourselves. "null, o

Re: Regarding job status between current and the latest

2015-12-22 Thread Alexander Bezzubov
Hi, Thank you for your question, I see what you meen. If I may, I would suggest that we do not try to store nulls anywhere becuse that will result in more pullrequests, checking for nulls in different places. If you could summerize the problem from the user perspective, that you are trying to so

Regarding job status between current and the latest

2015-12-22 Thread Jungtaek Lim
Hi devs, Paragraph seems to show the latest job run info (date, status), and another run overrides this information. Confused thing is that another run doesn't override the finished date until job finished, so while running start date is greater than finished date which is not intuitive. What do

[GitHub] incubator-zeppelin pull request: adding shadow to navbar if noteAc...

2015-12-22 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/564#issuecomment-166803095 I think shadow generally looks good on top bar / nav bar. Depending upon resolution after having 18-20 notebooks scroll bar shows up on homepage a

[GitHub] incubator-zeppelin pull request: ZEPPELIN-527 Fix NPE while retrie...

2015-12-22 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/562#issuecomment-166802602 @bzz Addressed your comment. @Leemoonsoo @bzz Ready for another round of review. --- If your project is set up for it, you can reply to this email an

Re: [DISCUSS] Preference of the JSON output representing null value

2015-12-22 Thread Jungtaek Lim
Alexander, Thanks for the input. Yes, that's why Option or others comes in modern language. Returning to origin issue, could you please take a look at PR #562 and comment? Seems like we can leave as it is, but PR #562 puts null value to the Map, so you would also think "removing put null value to

[GitHub] incubator-zeppelin pull request: adding shadow to navbar if noteAc...

2015-12-22 Thread corneadoug
Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/564#issuecomment-166794598 I think it could be better to fix the interpreter page Action bar instead of adding another shadow --- If your project is set up for it, you can reply to

[GitHub] incubator-zeppelin pull request: ZEPPELIN-501 Notebook search

2015-12-22 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/534#issuecomment-166783404 @Leemoonsoo thank you for thought testing and review! Scope is updated, will address all the feedback, and let you know. --- If your project is set up for it, y

[GitHub] incubator-zeppelin pull request: Add a (local mode) Scalding Inter...

2015-12-22 Thread sriramkrishnan
Github user sriramkrishnan commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/561#issuecomment-166764926 @bzz thanks for the review. I will address your other comments and update the PR in a day or so. @prasadwagle good point. I will add that too.

Re: [DISCUSS] Preference of the JSON output representing null value

2015-12-22 Thread Alexander Bezzubov
Hi, having null values meaning checking for nulls everywhere, which by itself adds quite meaningless code all over the place. I would say mature programmung style is to avoid having nulls whenever possible, including serialization on disk/wire. Other thoughts about not having null: - "I call it

[jira] [Created] (ZEPPELIN-530) Do not show plain-text credentials (user/password) in interpreter settings page

2015-12-22 Thread Prasad Wagle (JIRA)
Prasad Wagle created ZEPPELIN-530: - Summary: Do not show plain-text credentials (user/password) in interpreter settings page Key: ZEPPELIN-530 URL: https://issues.apache.org/jira/browse/ZEPPELIN-530 P

[DISCUSS] Preference of the JSON output representing null value

2015-12-22 Thread 임정택
Hi devs, It could be a tiny / trivial issue, but I'd love to see our opinions about the JSON output. When we use Map to body in JsonResponse (for REST API), it only represents keys which have non-null value to JSON. Please refer https://github.com/apache/incubator-zeppelin/pull/562 It seems to b

[GitHub] incubator-zeppelin pull request: ZEPPELIN-528 REST API: add "progr...

2015-12-22 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/563#issuecomment-166755709 @Leemoonsoo Addressed your comment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] incubator-zeppelin pull request: Add a (local mode) Scalding Inter...

2015-12-22 Thread prasadwagle
Github user prasadwagle commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/561#issuecomment-166755452 Should we add ScaldingInterpreter to ZEPPELIN_INTERPRETERS in ZeppelinConfiguration.java? tw-172-25-131-152 incubator-zeppelin (presto) $ git dif

[GitHub] incubator-zeppelin pull request: ZEPPELIN-528 REST API: add "progr...

2015-12-22 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/563#issuecomment-166752028 UT = Unit test :) I'll address the doc and let you know when complete. --- If your project is set up for it, you can reply to this email and have you

[jira] [Created] (ZEPPELIN-529) Make query parallelism configurable instead of hardcoding to 10 in HiveInterpreter.java

2015-12-22 Thread Prasad Wagle (JIRA)
Prasad Wagle created ZEPPELIN-529: - Summary: Make query parallelism configurable instead of hardcoding to 10 in HiveInterpreter.java Key: ZEPPELIN-529 URL: https://issues.apache.org/jira/browse/ZEPPELIN-529

[GitHub] incubator-zeppelin pull request: ZEPPELIN-528 REST API: add "progr...

2015-12-22 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/563#issuecomment-166718539 Thanks for the good improvement. I think it's better add an example of the JSON output that includes 'progress' field. Could you give me a hint tha

[GitHub] incubator-zeppelin pull request: ZEPPELIN-501 Notebook search

2015-12-22 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/534#issuecomment-166614398 Following error is thrown when persisting changes of notebook which loaded on Zeppelin startup (not created after start up) ``` java.lang.Null

[GitHub] incubator-zeppelin pull request: ZEPPELIN-501 Notebook search

2015-12-22 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/534#issuecomment-166612706 @bzz Great work. Seems like index is not updated after paragraph remove. Is it possible to be handled? --- If your project is set up for it, you can

[GitHub] incubator-zeppelin pull request: ZEPPELIN-501 Notebook search

2015-12-22 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/534#issuecomment-166600360 @Leemoonsoo All reviews are addressed, I think it's ready to be merged. --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] incubator-zeppelin pull request: [Docs] Minor fixes for Elasticsea...

2015-12-22 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/566#issuecomment-166598720 Thank you for fast reviews! Published live on http://zeppelin.incubator.apache.org/docs/0.6.0-incubating-SNAPSHOT/interpreter/elasticsearch.html --- If

[GitHub] incubator-zeppelin pull request: [Docs] Minor fixes for Elasticsea...

2015-12-22 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/566#issuecomment-166597354 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] incubator-zeppelin pull request: [Docs] Minor fixes for Elasticsea...

2015-12-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/566 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] incubator-zeppelin pull request: [Docs] Minor fixes for Elasticsea...

2015-12-22 Thread bbonnin
Github user bbonnin commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/566#issuecomment-166595214 Looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] incubator-zeppelin pull request: [Docs] Minor fixes for Elasticsea...

2015-12-22 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/566#issuecomment-166593880 Ready to be merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-zeppelin pull request: [Docs] Minor fixes for Elasticsea...

2015-12-22 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/566#issuecomment-166593788 \cc @bbonnin for review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] incubator-zeppelin pull request: [Docs] Minor fixes for Elasticsea...

2015-12-22 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/566#issuecomment-166585416 This is HotFix for #520 Would like to merge it asap --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[GitHub] incubator-zeppelin pull request: [Docs] Minor fixes for Elasticsea...

2015-12-22 Thread bzz
GitHub user bzz opened a pull request: https://github.com/apache/incubator-zeppelin/pull/566 [Docs] Minor fixes for Elasticsearch documentation ### What is this PR for? Adds elasticsearch to interpreter menu in navigation and fixes max image size for screenshots ### Wha

[GitHub] incubator-zeppelin pull request: Add an Elasticsearch interpreter

2015-12-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/520 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

Re: [DISCUSS] CI system for zeppelin

2015-12-22 Thread Alexander Bezzubov
Thank you for a proposal - to have a containerised CI solution will allow us to test with more version of interpreters and real clusters, as well as reduce build times, which is awesome. I wish we could also keep the simplicity of setup using `.travis.yaml` rather then job configuration details in

[GitHub] incubator-zeppelin pull request: Release resource after cron job.

2015-12-22 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/557#issuecomment-166569734 @astroshim I see, you are right, it's hard to say what else can do the job. I think if we just update the PR and the text in Zeppelin UI to something lik

[GitHub] incubator-zeppelin pull request: Bug fix/table scrolling and hidin...

2015-12-22 Thread cloverhearts
GitHub user cloverhearts opened a pull request: https://github.com/apache/incubator-zeppelin/pull/565 Bug fix/table scrolling and hiding ### What is this PR for? For Table, reimplemented, scrolling, deleting a bug in the Table Header, Scrolling area expressed bugs have been fixe

[GitHub] incubator-zeppelin pull request: Prevent server calls when there i...

2015-12-22 Thread Karuppayya
Github user Karuppayya commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/559#issuecomment-166567968 @Leemoonsoo i was not aware of the use cases. if its natural behaviour, then we can allow running of empty paras. May be we have to put the CSS c

[GitHub] incubator-zeppelin pull request: Add firebug and firepath for debu...

2015-12-22 Thread corneadoug
Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/490#issuecomment-166550272 CI is green, merging if there is no more discussions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu