[GitHub] incubator-zeppelin pull request: Add a (local mode) Scalding Inter...

2015-12-31 Thread sriramkrishnan
Github user sriramkrishnan commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/561#issuecomment-168290915 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-zeppelin pull request: Add a (local mode) Scalding Inter...

2015-12-31 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/561#issuecomment-168290811 I'm merging it, if there're no more discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] incubator-zeppelin pull request: Add a (local mode) Scalding Inter...

2015-12-31 Thread sriramkrishnan
Github user sriramkrishnan commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/561#issuecomment-168290262 Thanks @Leemoonsoo for the review. Could one of the committers please merge if there are no other objections? --- If your project is set up for it, y

[GitHub] incubator-zeppelin pull request: Shiro security v2

2015-12-31 Thread anthonycorbacho
Github user anthonycorbacho commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/586#issuecomment-168282745 What is the purpose of ticket? And why do you save principal and ticket in the notebook? What will happen to my notebook if i have zeppelin a

[GitHub] incubator-zeppelin pull request: ZEPPELIN-544 ] After the restart ...

2015-12-31 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/581#issuecomment-168277485 Forgot to say LGTM. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] incubator-zeppelin pull request: ZEPPELIN-544 ] After the restart ...

2015-12-31 Thread cloverhearts
Github user cloverhearts commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/581#issuecomment-168274289 @HeartSaVioR Happy new year, HeartSaVioR! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] incubator-zeppelin pull request: ZEPPELIN-544 ] After the restart ...

2015-12-31 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/581#issuecomment-168274083 @cloverhearts OK, Don't worry. I'll address it to another issue. :) Happy new year! --- If your project is set up for it, you can reply to this email an

[GitHub] incubator-zeppelin pull request: ZEPPELIN-544 ] After the restart ...

2015-12-31 Thread cloverhearts
Github user cloverhearts commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/581#issuecomment-168273664 @HeartSaVioR I agree with your opinion. But this is a PR for a bug-fix. I do not want to put undue changes here. I am concerned that a ne

Re: Version handling in the JIRA

2015-12-31 Thread moon soo Lee
0.5.1 removed from JIRA Thanks, moon On Wed, Dec 30, 2015 at 5:53 PM Konstantin Boudnik wrote: > On Wed, Dec 30, 2015 at 07:38AM, moon soo Lee wrote: > > Make sense. If it is okay, let me move resolved issue from 0.5.1 to 0.5.5 > > while they're included in 0.5.5-incubating and move open issue

[GitHub] incubator-zeppelin pull request: ZEPPELIN-544 ] After the restart ...

2015-12-31 Thread cloverhearts
Github user cloverhearts commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/581#issuecomment-168273429 @HeartSaVioR Your horse may have a point. But this is a PR for a bug-fix. I do not want to put undue changes here. I am concerned that a

[GitHub] incubator-zeppelin pull request: Add a (local mode) Scalding Inter...

2015-12-31 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/561#issuecomment-168273426 LGTM. @sriramkrishnan Thanks for the contribution! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-550] Let interpreter de...

2015-12-31 Thread Leemoonsoo
GitHub user Leemoonsoo opened a pull request: https://github.com/apache/incubator-zeppelin/pull/587 [ZEPPELIN-550] Let interpreter define function for angular js ### What is this PR for? This allow interpreter define a function that callable from front-end. ### What type

[jira] [Created] (ZEPPELIN-550) Let interpreter define function for angular js

2015-12-31 Thread Lee moon soo (JIRA)
Lee moon soo created ZEPPELIN-550: - Summary: Let interpreter define function for angular js Key: ZEPPELIN-550 URL: https://issues.apache.org/jira/browse/ZEPPELIN-550 Project: Zeppelin Issue T

[GitHub] incubator-zeppelin pull request: ZEPPELIN-547: Cannot select outpu...

2015-12-31 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/585#issuecomment-168268821 @prabhjyotsingh please take a look https://github.com/prabhjyotsingh/incubator-zeppelin/pull/1. I think more simple patch is possible. --- If your proje

[GitHub] incubator-zeppelin pull request: Shiro security v2

2015-12-31 Thread jeffsteinmetz
Github user jeffsteinmetz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/586#issuecomment-168262713 I tested this PR, and it does ask for basic auth credentials after setting up `conf/shiro.ini` and setting `zeppelin.anonymous.allowed` to `false`.

[GitHub] incubator-zeppelin pull request: Shiro security v2

2015-12-31 Thread hayssams
Github user hayssams commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/586#issuecomment-168236215 @elbamos Step 1: Require HTTP Auth In conf/shiro.ini file, replace the lines 31 and 32 below ``` /** = anon #/** = authcBasic

[GitHub] incubator-zeppelin pull request: Shiro security v2

2015-12-31 Thread elbamos
Github user elbamos commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/586#issuecomment-168235446 @hayssams Can you provide step-by-step directions for configuring and using this? --- If your project is set up for it, you can reply to this email and have

[GitHub] incubator-zeppelin pull request: Added Shiro security

2015-12-31 Thread hayssams
Github user hayssams closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/53 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] incubator-zeppelin pull request: Added Shiro security

2015-12-31 Thread hayssams
Github user hayssams commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/53#issuecomment-168235372 I am closing this PR and suggest that we move the discussion to #586 --- If your project is set up for it, you can reply to this email and have your reply ap

[GitHub] incubator-zeppelin pull request: Added Shiro security

2015-12-31 Thread hayssams
Github user hayssams commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/53#issuecomment-168235269 @jongyoul I just created 2 JIRA issues. [ZEPPELIN-548](https://issues.apache.org/jira/browse/ZEPPELIN-548) for Zeppelin Authentication [ZEPPELIN-

[jira] [Created] (ZEPPELIN-549) Shiro Authorization

2015-12-31 Thread Hayssam Saleh (JIRA)
Hayssam Saleh created ZEPPELIN-549: -- Summary: Shiro Authorization Key: ZEPPELIN-549 URL: https://issues.apache.org/jira/browse/ZEPPELIN-549 Project: Zeppelin Issue Type: New Feature

[jira] [Created] (ZEPPELIN-548) Shiro Authentication

2015-12-31 Thread Hayssam Saleh (JIRA)
Hayssam Saleh created ZEPPELIN-548: -- Summary: Shiro Authentication Key: ZEPPELIN-548 URL: https://issues.apache.org/jira/browse/ZEPPELIN-548 Project: Zeppelin Issue Type: New Feature

[GitHub] incubator-zeppelin pull request: Added Shiro security

2015-12-31 Thread hayssams
Github user hayssams commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/53#issuecomment-168234161 You are right that should be removed. I took it from the shiro sample. I am removing the whole section right away. Cordialement. Hayssam Saleh,

[GitHub] incubator-zeppelin pull request: Added Shiro security

2015-12-31 Thread jeffsteinmetz
Github user jeffsteinmetz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/53#issuecomment-168232632 One comment: why is Stormpath (a commercial auth service unrelated to Zeppelin) mentioned in the comments for this PR? See: https://github.com/

[GitHub] incubator-zeppelin pull request: Added Shiro security

2015-12-31 Thread hayssams
Github user hayssams commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/53#issuecomment-168230807 @elbamos @jongyoul @rconline I created a new PR (https://github.com/apache/incubator-zeppelin/pull/586) which implements HTTP et Websocket security but d

[GitHub] incubator-zeppelin pull request: Shiro security v2

2015-12-31 Thread hayssams
GitHub user hayssams opened a pull request: https://github.com/apache/incubator-zeppelin/pull/586 Shiro security v2 Added Authentication. Once authenticated, a user has access to all notes. HTTP & Websocket channels are secured and require auth. This PR is based on PR

[GitHub] incubator-zeppelin pull request: update error message and output s...

2015-12-31 Thread gauravkumar37
Github user gauravkumar37 commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/583#issuecomment-168153475 I agree with both @Leemoonsoo as well as @r-kamath. I suggest we remove the vertical bar from the output and have the color of the output differenti

[GitHub] incubator-zeppelin pull request: Add a (local mode) Scalding Inter...

2015-12-31 Thread sriramkrishnan
Github user sriramkrishnan commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/561#issuecomment-168152743 And we also have a green build now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If