[GitHub] incubator-zeppelin pull request: ZEPPELIN-543: Storage initializat...

2016-01-04 Thread khalidhuseynov
Github user khalidhuseynov commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/582#issuecomment-168921896 @bzz thanks for the feedback! I updated naming for the methods I found starting with uppercase, let me know if there's anything else left. Otherwise i

[jira] [Created] (ZEPPELIN-557) Support programmatic access to dynamic forms in SQL interpreter

2016-01-04 Thread kunal chelani (JIRA)
kunal chelani created ZEPPELIN-557: -- Summary: Support programmatic access to dynamic forms in SQL interpreter Key: ZEPPELIN-557 URL: https://issues.apache.org/jira/browse/ZEPPELIN-557 Project: Zeppel

[GitHub] incubator-zeppelin pull request: ZEPPELIN-534 Discard broken thrif...

2016-01-04 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/575#issuecomment-168917836 Looks great to me, @HeartSaVioR thank you for the improvement. --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

Re: [DISCUSS] Release 0.5.6-incubating

2016-01-04 Thread moon soo Lee
Really appreciated taking release manager for 0.5.6-incubating release :-) On Mon, Jan 4, 2016 at 10:12 PM Alexander Bezzubov wrote: > Hi Moon, > > as mentioned before, I think rotating release management responsibilities > is a great idea! > Will be happy to volunteer and cut 0.5.6-incubating r

[GitHub] incubator-zeppelin pull request: ZEPPELIN-534 Discard broken thrif...

2016-01-04 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/575#issuecomment-168909928 @HeartSaVioR Thanks! LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

Re: [DISCUSS] Release 0.5.6-incubating

2016-01-04 Thread Alexander Bezzubov
Hi Moon, as mentioned before, I think rotating release management responsibilities is a great idea! Will be happy to volunteer and cut 0.5.6-incubating release. On Tue, Jan 5, 2016 at 3:02 PM, moon soo Lee wrote: > I've been release manager for 0.5.0-incubating and 0.5.5-incubating. > Any commi

Re: [DISCUSS] Release 0.5.6-incubating

2016-01-04 Thread moon soo Lee
I've been release manager for 0.5.0-incubating and 0.5.5-incubating. Any committer volunteer the release manager for 0.5.6-incubating release? Thanks, moon On Mon, Jan 4, 2016 at 9:52 PM Alexander Bezzubov wrote: > +1 for 0.5.6 release from maser > > On Wed, Dec 30, 2015 at 9:51 PM, Khalid Huse

[GitHub] incubator-zeppelin pull request: ZEPPELIN-545. Include Ignite 1.5....

2016-01-04 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/584#issuecomment-168906506 Looks good to me, thank you for taking care! Will merging if there is no further discussion. --- If your project is set up for it, you can reply to this emai

Re: [DISCUSS] Release 0.5.6-incubating

2016-01-04 Thread Alexander Bezzubov
+1 for 0.5.6 release from maser On Wed, Dec 30, 2015 at 9:51 PM, Khalid Huseynov wrote: > +1 for 0.5.6 release with current improvements/fixes. > > > On Wed, Dec 30, 2015 at 4:10 PM, moon soo Lee wrote: > > > Amos, > > > > Who started the word "meaningful" is not important. > > Release discussi

[GitHub] incubator-zeppelin pull request: ZEPPELIN-545. Include Ignite 1.5....

2016-01-04 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/584#issuecomment-168904696 Looks good to me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] incubator-zeppelin pull request: Bump nvd3 version

2016-01-04 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/597#issuecomment-168904621 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] incubator-zeppelin pull request: ZEPPELIN-545. Include Ignite 1.5....

2016-01-04 Thread c0s
Github user c0s commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/584#issuecomment-168900525 Looks like it is good to go. There might be a bigger issue with different default marshallers for different node modes, which I am discussing on dev@ignite right

[GitHub] incubator-zeppelin pull request: Bump nvd3 version

2016-01-04 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/597#issuecomment-168897207 LGTM :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-zeppelin pull request: ZEPPELIN-545. Include Ignite 1.5....

2016-01-04 Thread c0s
Github user c0s closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/584 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] incubator-zeppelin pull request: ZEPPELIN-545. Include Ignite 1.5....

2016-01-04 Thread c0s
GitHub user c0s reopened a pull request: https://github.com/apache/incubator-zeppelin/pull/584 ZEPPELIN-545. Include Ignite 1.5.0.final into next release of Zeppelin Ready for the review. The latest Ignite release will be published in the next day or so You can merge this pull req

[GitHub] incubator-zeppelin pull request: ZEPPELIN-545. Include Ignite 1.5....

2016-01-04 Thread c0s
Github user c0s commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/584#issuecomment-168894741 Looks like CI didn't pick up correct commit. Restarting once again. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] incubator-zeppelin pull request: ZEPPELIN-545. Include Ignite 1.5....

2016-01-04 Thread c0s
GitHub user c0s reopened a pull request: https://github.com/apache/incubator-zeppelin/pull/584 ZEPPELIN-545. Include Ignite 1.5.0.final into next release of Zeppelin Ready for the review. The latest Ignite release will be published in the next day or so You can merge this pull req

[GitHub] incubator-zeppelin pull request: ZEPPELIN-545. Include Ignite 1.5....

2016-01-04 Thread c0s
Github user c0s closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/584 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] incubator-zeppelin pull request: Delete useless file : docs.md

2016-01-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/595 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] incubator-zeppelin pull request: ZEPPELIN-534 Discard broken thrif...

2016-01-04 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/575#issuecomment-168886879 @jongyoul @Leemoonsoo Address your comment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] incubator-zeppelin pull request: Bump nvd3 version

2016-01-04 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/597#issuecomment-168885350 @corneadoug totally missed about grunt minification tasks. Also, can you take a look at https://github.com/corneadoug/incubator-zeppelin/pull/3 ---

[GitHub] incubator-zeppelin pull request: ZEPPELIN-545. Include Ignite 1.5....

2016-01-04 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/584#issuecomment-168875634 Command such as ```mvn package -pl 'zeppelin-interpreter,ignite'``` will run ignite (and zeppelin-interpreter module) only. --- If your project is set

[GitHub] incubator-zeppelin pull request: Bump nvd3 version

2016-01-04 Thread corneadoug
Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/597#issuecomment-168875211 License is updated, Good to go --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] incubator-zeppelin pull request: ZEPPELIN-543: Storage initializat...

2016-01-04 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/582#issuecomment-168875123 +1 for better user notifications\warnings in the separate PR. @khalidhuseynov could you please check if the method naming follows the project code conventions

[GitHub] incubator-zeppelin pull request: ZEPPELIN-545. Include Ignite 1.5....

2016-01-04 Thread c0s
Github user c0s commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/584#issuecomment-168872438 Looks like it is cause by a missing configuration piece... ```Caused by: class org.apache.ignite.spi.IgniteSpiException: Local node's marshaller differs from

[GitHub] incubator-zeppelin pull request: Display aggregation result with E...

2016-01-04 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/596#issuecomment-168868697 Looks good to me, will merge if there is no disucssion --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] incubator-zeppelin pull request: ZEPPELIN-545. Include Ignite 1.5....

2016-01-04 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/584#issuecomment-168866454 Looking though [CI logs](https://s3.amazonaws.com/archive.travis-ci.org/jobs/100251649/log.txt) it looks like one test is failing ``` SEVERE: Got e

[GitHub] incubator-zeppelin pull request: Add -Pscalding flag to .travis.ym...

2016-01-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/594 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] incubator-zeppelin pull request: Bump nvd3 version

2016-01-04 Thread corneadoug
Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/597#issuecomment-168862465 @prabhjyotsingh 1) 1.8.1 has a new tooltip system, and I found some bug while trying it 2) This is auto-generated by bower, also all libraries are

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-550] Let interpreter de...

2016-01-04 Thread corneadoug
Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/587#issuecomment-168861143 @Leemoonsoo I think #591 is easier indeed. Just asking in case closing it was a mistake :) --- If your project is set up for it, you can reply to this

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-550] Let interpreter de...

2016-01-04 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/587#issuecomment-168860435 This PR is fully functioning with test and docs. However, i think https://github.com/apache/incubator-zeppelin/pull/591 provides much simpler way to use a

[GitHub] incubator-zeppelin pull request: ZEPPELIN-545. Include Ignite 1.5....

2016-01-04 Thread c0s
Github user c0s closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/584 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] incubator-zeppelin pull request: ZEPPELIN-545. Include Ignite 1.5....

2016-01-04 Thread c0s
GitHub user c0s reopened a pull request: https://github.com/apache/incubator-zeppelin/pull/584 ZEPPELIN-545. Include Ignite 1.5.0.final into next release of Zeppelin Ready for the review. The latest Ignite release will be published in the next day or so You can merge this pull req

[GitHub] incubator-zeppelin pull request: ZEPPELIN-545. Include Ignite 1.5....

2016-01-04 Thread c0s
Github user c0s commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/584#issuecomment-168856099 Re-opening to trigger the CI --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-zeppelin pull request: ZEPPELIN-545. Include Ignite 1.5....

2016-01-04 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/584#issuecomment-168854282 So cool! @c0s AFAIK the simplest way to re-trigger the CI would be to close and re-open the PR by the author --- If your project is set up for it, you can

[GitHub] incubator-zeppelin pull request: ZEPPELIN-545. Include Ignite 1.5....

2016-01-04 Thread c0s
Github user c0s commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/584#issuecomment-168778042 The 1.5.0.final release has been published and this PR should be able to clear the CI. Thanks! --- If your project is set up for it, you can reply to this email

[GitHub] incubator-zeppelin pull request: [WIP] [ZEPPELIN-395] Support Spar...

2016-01-04 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/463#issuecomment-168770542 http://archive.apache.org/dist/spark/ does not have 1.6.0 yet. --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] incubator-zeppelin pull request: Shiro security v2

2016-01-04 Thread hayssams
Github user hayssams commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/586#issuecomment-168738915 @Leemoonsoo Just pushed the code. Now using the baseUrlSrv on bootstrap. --- If your project is set up for it, you can reply to this email and have you

[GitHub] incubator-zeppelin pull request: Bump nvd3 version

2016-01-04 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/597#issuecomment-168686642 @corneadoug we can use the license folder when license requires copy of the license. You may at least update name of the file zeppelin-distribution/src/bi

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-552] Shadow on focused ...

2016-01-04 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/592#issuecomment-168680849 Tested, works well, LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] incubator-zeppelin pull request: Bump nvd3 version

2016-01-04 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/597#issuecomment-168677889 :+1: for moving out from 1.5-beta to 1.7.1. Few questions: - Any reason why 1.7.1 not 1.8.1 - can we use .min.js and .min.css in [

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-552] Shadow on focused ...

2016-01-04 Thread corneadoug
Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/592#issuecomment-168609962 Looks good, However when we focus by clicking on the output, shortcut are not working. --- If your project is set up for it, you can reply to this email

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-550] Let interpreter de...

2016-01-04 Thread corneadoug
Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/587#issuecomment-168608089 @Leemoonsoo Closed? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] incubator-zeppelin pull request: Bump nvd3 version

2016-01-04 Thread corneadoug
Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/597#issuecomment-168605975 READY @Leemoonsoo, could you tell me what is that license folder: https://github.com/apache/incubator-zeppelin/tree/master/zeppelin-distribution/s