[GitHub] incubator-zeppelin pull request: Add new selenium test case to tes...

2016-02-20 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/689#issuecomment-186759123 This should catch all Exception not just ElementNotVisibleException. --- If your project is set up for it, you can reply to this email and have your

[GitHub] incubator-zeppelin pull request: Notebook Authorization

2016-02-20 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/681#issuecomment-186755439 Okay, If i summarize my understanding, Shiro can not only handle authentication for user but also can be extended to save/load permission information

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-647] - Native Windows s...

2016-02-20 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/734#issuecomment-186749794 It works well on my windows XP with oracle jdk 1.7.0_79. great work! --- If your project is set up for it, you can reply to this email and have your

[GitHub] incubator-zeppelin pull request: ZEPPELIN-408 Fix configuration bu...

2016-02-20 Thread chiwanpark
Github user chiwanpark closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/420 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] incubator-zeppelin pull request: ZEPPELIN-408 Fix configuration bu...

2016-02-20 Thread chiwanpark
Github user chiwanpark commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/420#issuecomment-186747107 I close this issue due to #731. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-zeppelin pull request: Get travis to retry download of S...

2016-02-20 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/727#issuecomment-186735968 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-408] Properly honor not...

2016-02-20 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/731#issuecomment-186728252 LGTM and merge if there're no more discussions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-408] Properly honor not...

2016-02-20 Thread khalidhuseynov
Github user khalidhuseynov commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/731#issuecomment-186728191 Thanks for the fix, LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-zeppelin pull request: [document] update document for ze...

2016-02-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/649 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-647] - Native Windows s...

2016-02-20 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/734#issuecomment-186653407 @granturing Appreciate for the patch! I'll manually test it in this evening with my windows XP and share the result. --- If your project is set up

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-408] Properly honor not...

2016-02-20 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/731#issuecomment-186649379 [ci fails](https://s3.amazonaws.com/archive.travis-ci.org/jobs/110572850/log.txt) with ``` Running

[GitHub] incubator-zeppelin pull request: [DOCS][JDBC] Guide user to add jd...

2016-02-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/717 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-zeppelin pull request: Return empty file list instead of...

2016-02-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/716 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-zeppelin pull request: ZEPPELIN-631 Allow user to config...

2016-02-20 Thread jongyoul
GitHub user jongyoul opened a pull request: https://github.com/apache/incubator-zeppelin/pull/735 ZEPPELIN-631 Allow user to configure spark.yarn.dist.files ### What is this PR for? This enables to append values into spark.yarn.dist.files ### What type of PR is it?

[GitHub] incubator-zeppelin pull request: [MINOR] Update copyright year

2016-02-20 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/733#issuecomment-186649239 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-647] - Native Windows s...

2016-02-20 Thread granturing
GitHub user granturing opened a pull request: https://github.com/apache/incubator-zeppelin/pull/734 [ZEPPELIN-647] - Native Windows support for startup scripts and configuration ### What is this PR for? This is to give Windows first-class support for running Zeppelin without

[GitHub] incubator-zeppelin pull request: User in interpreter context

2016-02-20 Thread jongyoul
Github user jongyoul commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/705#issuecomment-186631173 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-zeppelin pull request: [MINOR] Update copyright year

2016-02-20 Thread jongyoul
Github user jongyoul commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/733#issuecomment-186625319 Clear. Merging if there's no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] incubator-zeppelin pull request: Zeppelin 639

2016-02-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/684 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-02-20 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-186613590 @elbamos got it, about BSD licence files. Let me double-check everything and get back to you with it by Monday --- If your project is set up for it, you can

[GitHub] incubator-zeppelin pull request: [MINOR] Remove obsolete and old c...

2016-02-20 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/732#issuecomment-186545937 Thanks for taking care those obsolete notices. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on