[GitHub] incubator-zeppelin pull request: Add new selenium test case to tes...

2016-02-20 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/689#issuecomment-186759123 This should catch all Exception not just ElementNotVisibleException. --- If your project is set up for it, you can reply to this email and have your r

[GitHub] incubator-zeppelin pull request: Notebook Authorization

2016-02-20 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/681#issuecomment-186755439 Okay, If i summarize my understanding, Shiro can not only handle authentication for user but also can be extended to save/load permission information f

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-647] - Native Windows s...

2016-02-20 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/734#issuecomment-186749794 It works well on my windows XP with oracle jdk 1.7.0_79. great work! --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] incubator-zeppelin pull request: ZEPPELIN-408 Fix configuration bu...

2016-02-20 Thread chiwanpark
Github user chiwanpark closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/420 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-zeppelin pull request: ZEPPELIN-408 Fix configuration bu...

2016-02-20 Thread chiwanpark
Github user chiwanpark commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/420#issuecomment-186747107 I close this issue due to #731. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] incubator-zeppelin pull request: Get travis to retry download of S...

2016-02-20 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/727#issuecomment-186735968 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-408] Properly honor not...

2016-02-20 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/731#issuecomment-186728252 LGTM and merge if there're no more discussions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-408] Properly honor not...

2016-02-20 Thread khalidhuseynov
Github user khalidhuseynov commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/731#issuecomment-186728191 Thanks for the fix, LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] incubator-zeppelin pull request: [MINOR] Remove obsolete and old c...

2016-02-20 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/732#issuecomment-186727939 Merging it if there're no more discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

ZEPPELIN-682

2016-02-20 Thread Minudika Malshan
Hi all, I am looking forward to contribute in this year GSOC. I have a basic understand in writing interpreters for zeppelin and have already implement an interpreter for WSO2 siddhi which is a complex event processing language. Could you please give me more details about the requirement for imple

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-408] Properly honor not...

2016-02-20 Thread jongyoul
Github user jongyoul commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/731#issuecomment-186656231 That failure looks related other tests that set some properties like `System.setProperty(ConfVars.ZEPPELIN_NOTEBOOK_DIR.getVarName(), mainNotebookDir.getAbs

[GitHub] incubator-zeppelin pull request: Add test case for remove paragrap...

2016-02-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/691 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] incubator-zeppelin pull request: ZEPPELIN-631 Allow user to config...

2016-02-20 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/735#issuecomment-186654455 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] incubator-zeppelin pull request: [document] update document for ze...

2016-02-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/649 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-647] - Native Windows s...

2016-02-20 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/734#issuecomment-186653407 @granturing Appreciate for the patch! I'll manually test it in this evening with my windows XP and share the result. --- If your project is set up f

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-408] Properly honor not...

2016-02-20 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/731#issuecomment-186649379 [ci fails](https://s3.amazonaws.com/archive.travis-ci.org/jobs/110572850/log.txt) with ``` Running org.apache.zeppelin.conf.ZeppelinConfigur

[GitHub] incubator-zeppelin pull request: [DOCS][JDBC] Guide user to add jd...

2016-02-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/717 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] incubator-zeppelin pull request: Return empty file list instead of...

2016-02-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/716 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] incubator-zeppelin pull request: ZEPPELIN-631 Allow user to config...

2016-02-20 Thread jongyoul
GitHub user jongyoul opened a pull request: https://github.com/apache/incubator-zeppelin/pull/735 ZEPPELIN-631 Allow user to configure spark.yarn.dist.files ### What is this PR for? This enables to append values into spark.yarn.dist.files ### What type of PR is it? B

[GitHub] incubator-zeppelin pull request: [MINOR] Update copyright year

2016-02-20 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/733#issuecomment-186649239 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-647] - Native Windows s...

2016-02-20 Thread granturing
GitHub user granturing opened a pull request: https://github.com/apache/incubator-zeppelin/pull/734 [ZEPPELIN-647] - Native Windows support for startup scripts and configuration ### What is this PR for? This is to give Windows first-class support for running Zeppelin without th

[GitHub] incubator-zeppelin pull request: User in interpreter context

2016-02-20 Thread jongyoul
Github user jongyoul commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/705#issuecomment-186631173 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] incubator-zeppelin pull request: [MINOR] Update copyright year

2016-02-20 Thread jongyoul
Github user jongyoul commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/733#issuecomment-186625319 Clear. Merging if there's no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] incubator-zeppelin pull request: Zeppelin 639

2016-02-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/684 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-02-20 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-186613590 @elbamos got it, about BSD licence files. Let me double-check everything and get back to you with it by Monday --- If your project is set up for it, you can rep

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-02-20 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-186613513 @btiernay @zhiboz thank you for feedback, if you could please express it on the [dev@ mailing list](http://zeppelin.incubator.apache.org/community.html) that wou

[GitHub] incubator-zeppelin pull request: [MINOR] Remove obsolete and old c...

2016-02-20 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/732#issuecomment-186545937 Thanks for taking care those obsolete notices. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] incubator-zeppelin pull request: [MINOR] Update copyright year

2016-02-20 Thread lresende
GitHub user lresende opened a pull request: https://github.com/apache/incubator-zeppelin/pull/733 [MINOR] Update copyright year You can merge this pull request into a Git repository by running: $ git pull https://github.com/lresende/incubator-zeppelin copyright Alternatively

[GitHub] incubator-zeppelin pull request: [MINOR] Remove obsolete and old c...

2016-02-20 Thread lresende
GitHub user lresende opened a pull request: https://github.com/apache/incubator-zeppelin/pull/732 [MINOR] Remove obsolete and old copyright notices in legal header There is already a collective copyright notice in the NOTICE file You can merge this pull request into a Git repository

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-408] Properly honor not...

2016-02-20 Thread lresende
GitHub user lresende opened a pull request: https://github.com/apache/incubator-zeppelin/pull/731 [ZEPPELIN-408] Properly honor notebook dir from xml configuration This is a fork of #420 (stalled since December) which address the provided comments and also add minor test case on the