[GitHub] incubator-zeppelin pull request: ZEPPELIN-346 Fix NotebookTest not...

2016-01-08 Thread RPCMoritz
Github user RPCMoritz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/347#issuecomment-170016876 testSelectingReplImplementation(org.apache.zeppelin.notebook.NotebookTest) Time elapsed: 0.032 sec <<&

[GitHub] incubator-zeppelin pull request: ZEPPELIN-346 Fix NotebookTest not...

2016-01-05 Thread RPCMoritz
Github user RPCMoritz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/347#issuecomment-168988570 I will re-test on my systems ASAP. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-zeppelin pull request: ZEPPELIN-315 Fix time-dependant s...

2015-11-10 Thread RPCMoritz
Github user RPCMoritz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/315#issuecomment-155355447 @Leemoonsoo I'd really like to be able to tick this one off of my list - any chance of merging this soon? --- If your project is set up for it, yo

[GitHub] incubator-zeppelin pull request: ZEPPELIN-346 Fix NotebookTest not...

2015-10-30 Thread RPCMoritz
Github user RPCMoritz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/347#issuecomment-152624067 On any machine I attempted to build, I got the test failure (interpreter not found). I'll try again with the current master on yet another machine to

[GitHub] incubator-zeppelin pull request: ZEPPELIN-346 Fix NotebookTest not...

2015-10-30 Thread RPCMoritz
Github user RPCMoritz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/347#issuecomment-152616329 I believe the test currently only passes CI, because of the broken implementation of using System properties. Without setting group.name explicetely, the

[GitHub] incubator-zeppelin pull request: ZEPPELIN-346 Fix NotebookTest not...

2015-10-30 Thread RPCMoritz
Github user RPCMoritz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/347#issuecomment-152497944 @Leemoonsoo if you plan to release a new version, then you should probably merge this as-is. A fix of the underlying logic is going to be more involved

[GitHub] incubator-zeppelin pull request: ZEPPELIN-315 Fix time-dependant s...

2015-10-27 Thread RPCMoritz
Github user RPCMoritz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/315#issuecomment-151411072 Unclear what caused that build to fail - retrying --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] incubator-zeppelin pull request: ZEPPELIN-315 Fix time-dependant s...

2015-10-27 Thread RPCMoritz
Github user RPCMoritz closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/315 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-zeppelin pull request: ZEPPELIN-315 Fix time-dependant s...

2015-10-27 Thread RPCMoritz
GitHub user RPCMoritz reopened a pull request: https://github.com/apache/incubator-zeppelin/pull/315 ZEPPELIN-315 Fix time-dependant scheduling test test-schedule can fail when it starts late in a second, as the result will then return the next second due to in-system delays

[GitHub] incubator-zeppelin pull request: ZEPPELIN-315 Fix time-dependant s...

2015-10-23 Thread RPCMoritz
Github user RPCMoritz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/315#issuecomment-150604474 Rebased to current master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] incubator-zeppelin pull request: ZEPPELIN-315 Fix time-dependant s...

2015-10-22 Thread RPCMoritz
Github user RPCMoritz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/315#issuecomment-150260023 Looks like your last commit broke diff's ability to properly locate these lines. Should I attempt to rebase, or can you take care of this during the

[GitHub] incubator-zeppelin pull request: ZEPPELIN-346 Fix NotebookTest not...

2015-10-16 Thread RPCMoritz
GitHub user RPCMoritz opened a pull request: https://github.com/apache/incubator-zeppelin/pull/347 ZEPPELIN-346 Fix NotebookTest not passing non-default group to NoteIn… …terpreterLoader This implements the actually required logic for this test to pass and should

[GitHub] incubator-zeppelin pull request: ZEPPELIN-315 Fix time-dependant s...

2015-10-11 Thread RPCMoritz
Github user RPCMoritz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/315#issuecomment-147173875 This merely gives the cron configuration one second to become effective, before testing whether the job is still running, using the same logic as before

[GitHub] incubator-zeppelin pull request: ZEPPELIN-315 Fix time-dependant s...

2015-10-07 Thread RPCMoritz
Github user RPCMoritz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/315#issuecomment-146189825 @Leemoonsoo could you take a look at this one? It's a pretty straighforward fix. --- If your project is set up for it, you can reply to this emai

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-319]wait an additional ...

2015-10-06 Thread RPCMoritz
Github user RPCMoritz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/323#issuecomment-145782077 @corneadoug thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-319]wait an additional ...

2015-10-06 Thread RPCMoritz
GitHub user RPCMoritz reopened a pull request: https://github.com/apache/incubator-zeppelin/pull/323 [ZEPPELIN-319]wait an additional .5 seconds, if assertion will fail This test failed randomly during a build. To make sure this is not due to timing issues, we can optionally wait

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-319]wait an additional ...

2015-10-06 Thread RPCMoritz
Github user RPCMoritz closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/323 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-319]wait an additional ...

2015-10-06 Thread RPCMoritz
Github user RPCMoritz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/323#issuecomment-145776128 Looks like npm-dependency-resolution broke the build - how can I trigger a re-check? (Ironic, that this happens, while I'm trying to stabilize the

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-319]wait an additional ...

2015-10-03 Thread RPCMoritz
Github user RPCMoritz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/323#issuecomment-145323504 That's more reasonable, I'll amend the commit. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-319]wait an additional ...

2015-10-03 Thread RPCMoritz
Github user RPCMoritz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/323#issuecomment-145272322 Well, we do need some kind of way out of that loop, to get to the failure - stage. Infinite looping won't work. --- If your project is set up for it

[GitHub] incubator-zeppelin pull request:

2015-09-24 Thread RPCMoritz
Github user RPCMoritz commented on the pull request: https://github.com/apache/incubator-zeppelin/commit/528dbfaa93fc4e91bf20f30e1498907271073e1a#commitcomment-13412803 In zeppelin-interpreter/src/test/java/org/apache/zeppelin/scheduler/RemoteSchedulerTest.java: In zeppelin

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-319]wait an additional ...

2015-09-24 Thread RPCMoritz
GitHub user RPCMoritz opened a pull request: https://github.com/apache/incubator-zeppelin/pull/323 [ZEPPELIN-319]wait an additional .5 seconds, if assertion will fail This test failed randomly during a build. To make sure this is not due to timing issues, we can optionally wait an

[GitHub] incubator-zeppelin pull request: #315 Fix time-dependant schedulin...

2015-09-21 Thread RPCMoritz
GitHub user RPCMoritz opened a pull request: https://github.com/apache/incubator-zeppelin/pull/315 #315 Fix time-dependant scheduling test test-schedule can fail when it starts late in a second, as the result will then return the next second due to in-system delays (particularly

[GitHub] incubator-zeppelin pull request: Added Shiro security

2015-07-09 Thread RPCMoritz
Github user RPCMoritz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/53#issuecomment-120013860 Hi, I'd like to know whether this PR will be followed up? Integrated authentication would go along way towards making Zeppelin enterprise capable wi

[GitHub] incubator-zeppelin pull request: Simplify classpath.

2015-05-13 Thread RPCMoritz
Github user RPCMoritz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/65#issuecomment-101553576 While this was a decent effort (it actually made my classpath-related error almost readable, where previously it was three screens worth of text), there is