[GitHub] incubator-zeppelin pull request: zeppelin-333:Notebook create, del...

2015-10-06 Thread vmakhaev
Github user vmakhaev commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/334#issuecomment-145942562 Yes, we can merge this and treat my comment as request for additional API. I think in general case we just want to get as much info about particular

[GitHub] incubator-zeppelin pull request: zeppelin-333:Notebook create, del...

2015-10-06 Thread vmakhaev
Github user vmakhaev commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/334#issuecomment-145934391 Sorry, to be late, maybe I should open another issue. I have use case for GET /notebook/:notebookId. We have some pre-defined notebooks, which we

[GitHub] incubator-zeppelin pull request: zeppelin-333: [WIP] Notebook crea...

2015-10-05 Thread vmakhaev
Github user vmakhaev commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/334#issuecomment-145553828 Ok, I see your point. Let's wait for use cases (I do not have any). --- If your project is set up for it, you can reply to this email and have your

[GitHub] incubator-zeppelin pull request: zeppelin-333: [WIP] Notebook crea...

2015-10-05 Thread vmakhaev
Github user vmakhaev commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/334#issuecomment-145526573 Looks good. Meets our needs. Looking forward to have it. Only one remark: why would not we add GET /api/notebook/:notebookId for retrieving notebook

[GitHub] incubator-zeppelin pull request: Send back message with note data ...

2015-10-02 Thread vmakhaev
Github user vmakhaev closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/332 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-zeppelin pull request: Send back message with note data ...

2015-10-02 Thread vmakhaev
Github user vmakhaev commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/332#issuecomment-145048314 Yes, please. CRUD and clone will be enough for the beginning. If you need anything from me, let me know. --- If your project is set up for it, you can

[GitHub] incubator-zeppelin pull request: Send back message with note data ...

2015-10-02 Thread vmakhaev
Github user vmakhaev commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/332#issuecomment-145027589 The problem is to know id of just created Note (or just cloned Note). In our case, we store metadata (Note ids and names) in our databases and

[GitHub] incubator-zeppelin pull request: Send back message with note data ...

2015-10-01 Thread vmakhaev
GitHub user vmakhaev opened a pull request: https://github.com/apache/incubator-zeppelin/pull/332 Send back message with note data on create and clone We use web-socket api for creating and cloning notes from our servers. To know noteId of created or cloned note, we need some