Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/513
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fea
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/513#issuecomment-164197014
merging into master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/513#issuecomment-163574301
Looks great to me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/513#issuecomment-163375121
Thanks all the feedbacks and alternative solutions.
I have changed script name from `test.py` to `test_zeppelin_pr.py` and add
more comment.
A
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/513#issuecomment-162734353
@Leemoonsoo If we want to go further with this tool, as we already have
`./dev/merge_zeppelin_pr.py` may be we could name it something like
`./dev/test_zeppelin_
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/513#issuecomment-162728666
Looks great to me.
Another way to do the same is a small `hub`
[github/hub](https://github.com/github/hub) that allows you to do, apart from
many other
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/513#issuecomment-162160322
Should we also include some:
``git clean -dxf`` and then launch build then?
---
If your project is set up for it, you can reply to this email and have
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/513#issuecomment-162133198
I've tested. Looks good. It's enough to me to test pr. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/513#issuecomment-162050935
@r-kamath solution looks simpler, both are hacky though :smiley:
---
If your project is set up for it, you can reply to this email and have your
repl
Github user r-kamath commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/513#issuecomment-162049203
@Leemoonsoo I do `curl
https://patch-diff.githubusercontent.com/raw/apache/incubator-zeppelin/pull/.patch
| git apply` in master, review it and reset!
---
GitHub user Leemoonsoo opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/513
[ZEPPELIN-484] A small utility to help review the pullrequest.
This PR address https://issues.apache.org/jira/browse/ZEPPELIN-484.
We've got discussions recently about impasse
11 matches
Mail list logo
