Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/574
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fea
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/574#issuecomment-167506491
@HeartSaVioR Thanks for asking. Please remember anyone can create a
pullrequest to change CONTRIBUTING.md to improve review process, and more.
---
If you
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/574#issuecomment-167504561
@minahlee @Leemoonsoo
Thanks for letting me know. Zeppelin's review process is a bit uncommon so
I was confused. It's cleared.
---
If your project
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/574#issuecomment-167503853
According to CONTRIBUTING.md, a committer review is required, not one
additional committer. So technically, nothing stops push committer self
reviewed cod
Github user minahlee commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/574#issuecomment-167503210
@HeartSaVioR It's not mandatory to have review from PPMC/committer since we
follow lazy consensus rule but always good to be reviewed by more people
includi
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/574#issuecomment-167497891
@Leemoonsoo
Thanks for the quick fix!
Btw, skimming review process from CONTRIBUTING.md, it may require one
additional committer to be reviewed (
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/574#issuecomment-167496373
@HeartSaVioR Thanks for raising issue and taking review.
Merge if there're no more discussions.
---
If your project is set up for it, you can reply t
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/574#issuecomment-167485569
@Leemoonsoo
Yeah, actually interpreterGroupReference makes me hard to read (and
understand) Zeppelin's interpreter source code. Great for removing it
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/574#issuecomment-167483812
@HeartSaVioR now ci is passing
This PR make sure RemoteInterpreter.close() call
InterpreterProcess.dereference().
Also simplify code by let In
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/574#issuecomment-167471224
Great for reducing complexity, modified code looks good to me.
Btw, CI test is failing,
```
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0,
GitHub user Leemoonsoo opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/574
[ZEPPELIN-535] "Scheduler already terminated" occurs when
RemoteInterpreter.close() doesn't succeed
### What is this PR for?
Fix the exception "Scheduler already terminated" when
11 matches
Mail list logo
