Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/859
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/859#issuecomment-218070339
Merging if no more discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/859#issuecomment-217782293
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user ravicodder commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/859#issuecomment-217127237
@bzz Done required changes. Please have a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/859#issuecomment-217057001
@ravicodder thank you for prompt responce!
Looks great to me, modulo style nitpicks above. Let's merge as soon as
those are addressed!
---
If your
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/859#issuecomment-216866674
Looks good to me!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user ravicodder commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/859#issuecomment-216158267
@Leemoonsoo @bzz Thanks for review , Fixed indentation and added test.
@bzz thanks for informing , will take care in future PR's
---
If your project
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/859#issuecomment-216086558
ð for adding a new test-case for the search API on a new behavoir
---
If your project is set up for it, you can reply to this email and have your
reply
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/859#issuecomment-215941636
Thanks @ravicodder for the improvement.
Tried and works well.
If it is not too difficult, it might be better to have a simple testcase
for
Github user ravicodder commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/859#issuecomment-215164810
Ready for review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user ravicodder opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/859
[ZEPPELIN-599]notebook search should search paragraph title
### What is this PR for?
Allow notebook search to search paragraph title too.
### What type of PR is it?
11 matches
Mail list logo
