Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/754
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fea
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/754#issuecomment-194027542
Thanks i'm merging it into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AhyoungRyu commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/754#issuecomment-193660503
@echarles Thanks for creating the issue!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user echarles commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/754#issuecomment-193657371
@AhyoungRyu I have opened ZEPPELIN-725 for the interpreter update issue.
@felixcheung @Leemoonsoo This PR #754 is good to merge.
---
If your projec
Github user AhyoungRyu commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/754#issuecomment-193308252
@echarles I faced the same issue. I think it's a bug..
---
If your project is set up for it, you can reply to this email and have your
reply appear on Gi
Github user echarles commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/754#issuecomment-193176072
Tested with zeppelin.spark.sql.stacktrace being false and true, and it
works fine.
Good to merge.
PS: With HEAD source, I have issues setti
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/754#issuecomment-192706297
LGTM. @echarles what do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/754#issuecomment-192670762
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user zhongneu commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/754#issuecomment-192100210
Added a configuration to show full stacktrace
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user zhongneu commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/754#issuecomment-190611618
I agree to make it configurable, but show the shortened message by default
@echarles I think that's a good suggestion.
---
If your project is set u
Github user echarles commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/754#issuecomment-190609552
So we all agree to make it configurable on the interpreter settings leve
`zeppelin.spark.sql.stacktrace = false` by default ?
What about whe
Github user joelvanveluwen commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/754#issuecomment-190607278
+1 for making it configurable. I find the stack trace invaluable!
---
If your project is set up for it, you can reply to this email and have your
rep
Github user nemccarthy commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/754#issuecomment-190606798
this seems a little misguided. hiding errors is great until you need to
stack trace.
id vote to have it configurable where the default is always
Github user zhongneu commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/754#issuecomment-190604656
@echarles Thanks, Eric! It is good to know we have such cases. We should
definitely leave it as configurable if Spark doesn't provide informative error
mess
Github user echarles commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/754#issuecomment-190602637
@zhongneu I will rather give you a message a user could face running the
SQL: `java.lang.IllegalArgumentException: requirement failed` What will the guy
res
Github user zhongneu commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/754#issuecomment-189950117
@echarles I thought about made this configurable, but I thought the
stacktraces might not be helpful for SQL queries, because typically it is
difficult for
Github user echarles commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/754#issuecomment-189898912
I often use the stacktraces to debug what's going wrong. With this, I
expect I will miss information. Can we make this configurable (default being
"not verb
Github user zhongneu commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/754#issuecomment-189806808
fixed the test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/754#issuecomment-189802314
btw, it looks like this might be a legitimate test failure, could you take
a look?
https://s3.amazonaws.com/archive.travis-ci.org/jobs/112358128/log.t
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/754#issuecomment-189801164
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
Github user zhongneu commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/754#issuecomment-189788087
@felixcheung great idea. updated & tested. full stack trace will be logged
in the interpreter log
---
If your project is set up for it, you can reply to th
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/754#issuecomment-189787467
thx - let's add logger to capture the full stack before returning with
InterpreterResult?
```
logger.error("Invocation target exception", e);
Github user zhongneu commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/754#issuecomment-189785825
@felixcheung definitely. updated based on your comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHu
GitHub user zhongneu opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/754
[ZEPPELIN-679] only print the error message for SQL exceptions
### What is this PR for?
Most of the SQL exceptions are syntax errors. Printing the full stack trace
is not neces
24 matches
Mail list logo
