Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/866
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fea
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/866#issuecomment-217782239
Merging is no more discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/866#issuecomment-216825049
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user ravicodder commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/866#issuecomment-216759102
@prabhjyotsingh thanks for review.
Refactored all the logic into common function.
---
If your project is set up for it, you can reply to this email an
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/866#issuecomment-216208518
I think you should refactor all of these `{{note.name.trim()==='' && 'Note
' + note.id || note.name}}` to a common function.
---
If your project is
GitHub user ravicodder opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/866
[ZEPPELIN-834]Handle Note-name with spaces
### What is this PR for?
Handle notename to have only white spaces.
### What type of PR is it?
[Bug Fix ]
### Todo
