Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/668
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/668#issuecomment-185520105
merging if no more comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/668#issuecomment-185454337
@felixcheung I hope this would be merged into JDBC until releasing
0.6.0-incuating. I'll make a discussion mail thread on dev@
---
If your project is set
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/668#issuecomment-185103551
hi @felixcheung @jongyoul
This brought up to date nowplease review...;)
---
If your project is set up for it, you can reply to this email and
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/668#issuecomment-184891761
@vgmartinez could this be brought up to date with #667 ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/667#issuecomment-184891527
looks good, merging if no more comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/667#issuecomment-184589886
hi @felixcheung @jongyoul...I have added more test and fix the other
---
If your project is set up for it, you can reply to this email and have your
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/667#issuecomment-184506451
@vgmartinez could you rebase to latest on master to get tests to run again?
---
If your project is set up for it, you can reply to this email and have
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/667#issuecomment-182383545
@vgmartinez it looks like that you merge master into your branch. Please
check it and rebase your PR from master again.
---
If your project is set up for
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/667#issuecomment-182388974
@jongyoul...Done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/667#issuecomment-182490584
@jongyoul
I have added more tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/667#issuecomment-182250577
agreed, I think `%jdbc` should work.
can't we check only when a prefix is there? say `%jdbc()` or `%jdbc
(something_invalid)` should both fail, but
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/667#issuecomment-182253519
Hi @felixcheung @jongyoul
I tested it and looks like this:
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/667#issuecomment-181711378
@vgmartinez I think we need to support default interpreter without setting
any `default` word. In other words, users should be able to use default jdbc by
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/667#issuecomment-181007407
Hi @felixcheung I'm online now.
I think there are two ways to handle this:
* check that when a paragraph is executed there is an interpreter and a
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/667#issuecomment-180845559
Ok...I fix
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/667#issuecomment-180839918
property key not matching a valid profile is probably a fix would be great
to make separately - would you be interested in that, @vgmartinez ?
let's
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/667#issuecomment-178625423
@felixcheung I don't think current implementation is good. but I think it's
better handle it with different issue. Does it make sense?
---
If your project
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/667#issuecomment-178224031
the problem was when they used the in this way ```%jdbc``` and had the
query something like this ```select max(code) as ok, min(title) as t from
films2
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/667#issuecomment-178384425
Tested the current broken behavior, thanks for fixing this.
Added a comment on parsing.
Also, I think it's an issue when the return value from
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/667#issuecomment-177823526
I've tested it a bit, it seems to work - to reproduce the bug, do I need to
have multiple, or valid propertyKey?
For example, I type a random
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/667#issuecomment-177458549
Hi @felixcheung, could you check the bug...?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user prabhugs commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/668#issuecomment-174411917
Thanks, works good.
http://stackoverflow.com/questions/34926094/zeppelins-hive-interpreter-throws-null-pointer-exception/34933927#34933927
---
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/667#issuecomment-174238329
ok, I'll try to test this out a bit in 1-2 days
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/667#issuecomment-174052585
thanks for addressing this. could we add some tests for this?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/667#issuecomment-174067979
Hi @felixcheung, thanks for review...
add the test, is enough? or you think is necessary something more?
---
If your project is set up for it, you
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/667#issuecomment-174091218
in additional to `getPropertyKey()` is there a place where it parses the
rest of the query? that might need to be changed too?
---
If your project is
GitHub user vgmartinez opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/668
[Zeppelin-628 ] Fix parse propertyKey in interpreter name for Hive
### What is this PR for?
Fix bug
https://issues.apache.org/jira/browse/ZEPPELIN-628
### Todos
28 matches
Mail list logo
