[GitHub] incubator-zeppelin pull request: [Zeppelin 329] Notebook copied in...

2015-10-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/331 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-zeppelin pull request: [Zeppelin 329] Notebook copied in...

2015-10-11 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/331#issuecomment-147167587 I think activating this function by default will brings some IO overhead in some cases. (large number of big notebooks). As @minahlee mentioned, it's

[GitHub] incubator-zeppelin pull request: [Zeppelin 329] Notebook copied in...

2015-10-05 Thread minahlee
Github user minahlee commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/331#issuecomment-145621950 Beacause PR will load notebooks from storage everytime client requests notebook list, which can be burden to Zeppelin with a bunch of notebooks. So I

[GitHub] incubator-zeppelin pull request: [Zeppelin 329] Notebook copied in...

2015-10-05 Thread anthonycorbacho
Github user anthonycorbacho commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/331#issuecomment-145711460 so why not using a watcher? like if someone drop a notebook in the notebook dir, you update the list of notebook. --- If your project is set up for

[GitHub] incubator-zeppelin pull request: [Zeppelin 329] Notebook copied in...

2015-10-05 Thread minahlee
Github user minahlee commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/331#issuecomment-145493238 @Leemoonsoo @khalidhuseynov ready for review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] incubator-zeppelin pull request: [Zeppelin 329] Notebook copied in...

2015-10-05 Thread anthonycorbacho
Github user anthonycorbacho commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/331#issuecomment-145587447 why do you need to activate this functionality? shouldnt be a expected behavior? --- If your project is set up for it, you can reply to this email

[GitHub] incubator-zeppelin pull request: [Zeppelin 329] Notebook copied in...

2015-10-03 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/331#issuecomment-145209942 Nice improvement. Could you choose little more intuitive name than `ZEPPELIN_NOTEBOOK_GET_FROM_REPO` ? --- If your project is set up for it, you can