[GitHub] incubator-zeppelin pull request: Add PR template for github

Github user asfgit closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/748 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] incubator-zeppelin pull request: Add PR template for github

Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/748#issuecomment-18857 Then lets remove the bookmarklet and update the template in the contributing.md --- If your project is set up for it, you can reply to this email and hav

[GitHub] incubator-zeppelin pull request: Add PR template for github

Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/748#issuecomment-188932693 I think it's useful to have that in contributing.md so newcomers would have an idea what to expect before actually opening a new PR. We might want to leav

[GitHub] incubator-zeppelin pull request: Add PR template for github

Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/748#issuecomment-188853739 Should we remove the PR template part from the Contributing.md then? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] incubator-zeppelin pull request: Add PR template for github

Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/748#issuecomment-188816748 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] incubator-zeppelin pull request: Add PR template for github

Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/748#issuecomment-188663996 yea ;) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-zeppelin pull request: Add PR template for github

Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/748#issuecomment-188663789 CI failure is due to ``` Unapproved licenses: .github/PULL_REQUEST_TEMPLATE *** ``` .. but you got

[GitHub] incubator-zeppelin pull request: Add PR template for github

Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/748#issuecomment-188663097 Looks great to me! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-zeppelin pull request: Add PR template for github

Github user AhyoungRyu commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/748#issuecomment-188657433 Really cool! :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] incubator-zeppelin pull request: Add PR template for github

Github user jongyoul commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/748#issuecomment-188634098 Wow! LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-zeppelin pull request: Add PR template for github

GitHub user felixcheung opened a pull request: https://github.com/apache/incubator-zeppelin/pull/748 Add PR template for github ### What is this PR for? PR template can be added automatically by GitHub when a PR is opened. Proposing some changes to PR template wordings.