[GitHub] incubator-zeppelin pull request: Add tachyon interpreter

Github user asfgit closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/632 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-zeppelin pull request: Add tachyon interpreter

Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/632#issuecomment-175826081 thanks! merging if there is no more discussion --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] incubator-zeppelin pull request: Add tachyon interpreter

Github user maocorte commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/632#issuecomment-175539049 Thank you @AhyoungRyu for your review and your suggestions and I'm glad you appreciate the idea of a Tachyon interpreter. I have tried to add a simple

[GitHub] incubator-zeppelin pull request: Add tachyon interpreter

Github user maocorte commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/632#issuecomment-175652391 Thank you @AhyoungRyu...sorry, my fault!! I've used a bad markdown editor.. --- If your project is set up for it, you can reply to this email and have

[GitHub] incubator-zeppelin pull request: Add tachyon interpreter

Github user AhyoungRyu commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/632#issuecomment-175643457 @maocorte Thank you for your quick response! Hopefully it will be : ) I applied this PR and found this. ![screen shot 2016-01-27 at 10 52 35

[GitHub] incubator-zeppelin pull request: Add tachyon interpreter

Github user maocorte commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/632#issuecomment-174931772 Changed format of tachyon documentation to new guidelines and added link to navigation page. About interpreter response management, it reflects the

[GitHub] incubator-zeppelin pull request: Add tachyon interpreter

Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/632#issuecomment-175192708 Thanks @AhyoungRyu could you please take a quick look at the doc too? --- If your project is set up for it, you can reply to this email and have your

[GitHub] incubator-zeppelin pull request: Add tachyon interpreter

Github user AhyoungRyu commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/632#issuecomment-175352458 Hi @maocorte : ) It's really good news that we have Tachyon interpreter ! How about adding a basic Tachyon example code and result image(if

[GitHub] incubator-zeppelin pull request: Add tachyon interpreter

Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/632#issuecomment-174821511 Tested, worked well, thanks! One small question, some invalid commands do not always give an error message, do you know why?

[GitHub] incubator-zeppelin pull request: Add tachyon interpreter

Github user maocorte commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/632#issuecomment-174443346 Hi @felixcheung , I have tried but works for me. Please let me know if you need something from my side to merge this PR --- If your project is set up

[GitHub] incubator-zeppelin pull request: Add tachyon interpreter

Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/632#issuecomment-174240526 I tried to test this but was not able to pull the changes from the branch, I'll look into this a bit more. --- If your project is set up for it, you

[GitHub] incubator-zeppelin pull request: Add tachyon interpreter

Github user maocorte commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/632#issuecomment-172995655 I've added few tests for the interpreter using LocalTachyonCluster, any suggestion is appreciated. Just a question: for test porpouse, I've added

[GitHub] incubator-zeppelin pull request: Add tachyon interpreter

Github user maocorte commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/632#issuecomment-173118534 Done, thank you!!! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] incubator-zeppelin pull request: Add tachyon interpreter

Github user maocorte commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/632#issuecomment-172842355 I've added the doc for the interpreter and a simple method to print the availble commands list. I'm studying the better way to run a simple Tachyon

[GitHub] incubator-zeppelin pull request: Add tachyon interpreter

Github user jsimsa commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/632#issuecomment-172883582 @maocorte if you need to spin up a test EC2 Tachyon cluster, the Tachyon project contains scripts for doing exactly that:

[GitHub] incubator-zeppelin pull request: Add tachyon interpreter

Github user maocorte commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/632#issuecomment-172889854 Thank you @jsimsa, I was thinking about using LocalTachyonCluster to creare a local cluster and interact with it. Do you think it could be a good

[GitHub] incubator-zeppelin pull request: Add tachyon interpreter

Github user hsaputra commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/632#issuecomment-172899220 You are right, we could use startsWith. Was trying to avoid iterating through all keywords but using hash set not the right way. Maybe something like trie

[GitHub] incubator-zeppelin pull request: Add tachyon interpreter

Github user jsimsa commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/632#issuecomment-172893469 That is an interesting idea. I know that Tachyon makes extensive use of it in its integration tests, but I am not sure if you will be able to interact with

[GitHub] incubator-zeppelin pull request: Add tachyon interpreter

Github user maocorte commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/632#issuecomment-171589520 Thank you for the suggestions, I hope changes will be fine --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] incubator-zeppelin pull request: Add tachyon interpreter

Github user maocorte commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/632#issuecomment-171748444 Hi @hsaputra , thank you for your advices. Sorry for the question, shouldent HashSet.contains fail if comparison is not equal between the values?

[GitHub] incubator-zeppelin pull request: Add tachyon interpreter

GitHub user maocorte opened a pull request: https://github.com/apache/incubator-zeppelin/pull/632 Add tachyon interpreter ### What is this PR for? Add an interpreter to work with a tachyon file system. Properties required for the interpreter are: * tachyon

[GitHub] incubator-zeppelin pull request: Add tachyon interpreter

Github user maocorte commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/632#issuecomment-171438930 Hi @felixcheung , many thanks for your suggestions. I hope the changes are consisten with the request. --- If your project is set up for it, you can

[GitHub] incubator-zeppelin pull request: Add tachyon interpreter

Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/632#issuecomment-171471964 thanks. and thanks for contributing this new interpreter! In general we would prefer a new interpreter committed along with brief, introductory