[GitHub] incubator-zeppelin pull request: Drag to resize paragraph

Github user asfgit closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/516 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] incubator-zeppelin pull request: Drag to resize paragraph

Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/516#issuecomment-167708719 Re-tested, +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] incubator-zeppelin pull request: Drag to resize paragraph

Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/516#issuecomment-167703394 Merge if there're no more discussions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[GitHub] incubator-zeppelin pull request: Drag to resize paragraph

Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/516#issuecomment-167537248 Tested and LGTM. Thanks @prabhjyotsingh for really useful feature --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] incubator-zeppelin pull request: Drag to resize paragraph

Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/516#issuecomment-167485196 I've found weird behaviors. I can make paragraph width larger than the notebook width and resize proxy is displayed in correctly. Please take a loo

[GitHub] incubator-zeppelin pull request: Drag to resize paragraph

Github user prabhjyotsingh commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/516#issuecomment-166268360 Thanks @corneadoug for the feedback and a providing me with a lot of test cases. Have merged this with the latest master, which seems to solve the

[GitHub] incubator-zeppelin pull request: Drag to resize paragraph

Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/516#issuecomment-166058372 Tested, the bug are gone. There is now a minimum size on the output. However, would it be possible to apply the same limit to the dragging? Righ

[GitHub] incubator-zeppelin pull request: Drag to resize paragraph

Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/516#issuecomment-165704366 @prabhjyotsingh I will test it again tomorrow, sorry for the delay --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] incubator-zeppelin pull request: Drag to resize paragraph

Github user prabhjyotsingh commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/516#issuecomment-165692621 Does this looks ok ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] incubator-zeppelin pull request: Drag to resize paragraph

Github user prabhjyotsingh commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/516#issuecomment-164997127 Thanks for the review and finding bugs; 1) Scrollbar when code line is too long on notebook refresh/load - Fixed 2) Resize to a size too small

[GitHub] incubator-zeppelin pull request: Drag to resize paragraph

Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/516#issuecomment-164659904 Found plenty of issues: 1) Scrollbar when code line is too long on notebook refresh/load ![screen shot 2015-12-15 at 3 29 52 pm](https://cloud

[GitHub] incubator-zeppelin pull request: Drag to resize paragraph

Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/516#issuecomment-164651768 Could you also un-commit the note.json? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] incubator-zeppelin pull request: Drag to resize paragraph

Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/516#issuecomment-164643672 I have tested and it works really well. Thanks @prabhjyotsingh for really improvement. One thing is, resize drag handle is shown in report mode. B

[GitHub] incubator-zeppelin pull request: Drag to resize paragraph

Github user prabhjyotsingh commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/516#issuecomment-164396499 Have updated this PR, instead of having multiple resize handles. Merged it into one. ![drag to resize paragraph](https://cloud.githubusercon

[GitHub] incubator-zeppelin pull request: Drag to resize paragraph

Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/516#issuecomment-163108869 It's not too shocking to have both resize handles, however the resize graph height doesn't work anymore. You might also want to rebase. (since we merge

[GitHub] incubator-zeppelin pull request: Drag to resize paragraph

Github user prabhjyotsingh commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/516#issuecomment-162163115 Yes, I've noticed it, but it only shows up when there is a table/graph in view. Should I try merge it here, or this there? --- If your project is set

[GitHub] incubator-zeppelin pull request: Drag to resize paragraph

Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/516#issuecomment-162159952 We already have one to resize the height of the paragraph result. So there might be some conflicts --- If your project is set up for it, you can reply

[GitHub] incubator-zeppelin pull request: Drag to resize paragraph

GitHub user prabhjyotsingh opened a pull request: https://github.com/apache/incubator-zeppelin/pull/516 Drag to resize paragraph  You can merge this pull