[GitHub] incubator-zeppelin pull request: Interpreter setting not getting s...

2015-09-15 Thread Karuppayya
GitHub user Karuppayya opened a pull request: https://github.com/apache/incubator-zeppelin/pull/308 Interpreter setting not getting saved Scenario. In the create new interpreter setting form 1)Press "+" to create a new key/value. 2) Enter details.(dont press "+" button)

[GitHub] incubator-zeppelin pull request: Interpreter setting not getting s...

2015-09-15 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/308#issuecomment-140585375 Thanks for looking into this. I myself have also bitten by this issue. Is this the right user experience though, storing something that is potentially

[GitHub] incubator-zeppelin pull request: Interpreter setting not getting s...

2015-09-15 Thread Karuppayya
Github user Karuppayya commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/308#issuecomment-140600751 @felixcheung I guess the user would expect all entered properties to get persisted when he clicks "Save". Clicking "Save" with incomplete values seems t

[GitHub] incubator-zeppelin pull request: Interpreter setting not getting s...

2015-09-16 Thread corneadoug
Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/308#issuecomment-140655687 I think that behavior (not saving what is in the form) is okay. However, properties that were added should not be shown with an input, otherwise it's c

[GitHub] incubator-zeppelin pull request: Interpreter setting not getting s...

2015-09-19 Thread Karuppayya
Github user Karuppayya commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/308#issuecomment-141660225 Based on aboove discussion, seems to be hampering User Experience . Hence closing this PR. --- If your project is set up for it, you can reply to this em

[GitHub] incubator-zeppelin pull request: Interpreter setting not getting s...

2015-09-19 Thread Karuppayya
Github user Karuppayya closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/308 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: [GitHub] incubator-zeppelin pull request: Interpreter setting not getting s...

2015-09-16 Thread IT CTO
I agree with corneadoug, if we automatically persist the properties when user press save without pressing the + sigh then we have to add some kind of cancel only on the preperty level. say I just typed in a property name and value and did not press +, how do I cancel this without saving? maybe a d