Github user beeva-victorgarcia commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-172542965
In the next PR I add docs and auto-completion function...sorry for this
confusion
---
If your project is set up for it, you can reply to this ema
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-172539838
I fixed my mistakes. Feel free to talk to me if there's some problems.
Thanks everyone for taking care of it.
---
If your project is set up for it, you can
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-172530452
@tzolov Yes, It would be safe in general case, but in this case, because we
drop postgresql interpreter only, I think it's ok that I just add postgresql
int
Github user tzolov commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-172529513
Same principles that apply for extending/evolving APIs (or Interfaces)
should apply here. One shouldn't drop a new incomplete and undocumented API
while remov
Github user tzolov commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-172528525
@jongyoul,
Imo the safest and cleanest solution is be to revert the last (jdbc) commit
and to do the changes right before committing the again.
Then
Github user woonsan commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-172528015
Big applause to you guys!
+1 on moving to jdbc interpreter which may also allow other db specific
interpreter extensions in the future.
Cheers!
---
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-172526791
@tzolov Oops. I've found what's the problem. We just delete sqlCompleter
only. It's my mistake. I'll fix asap.
---
If your project is set up for it, you ca
Github user beeva-victorgarcia commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-172526244
ok...make sense
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-172525954
@beeva-victorgarcia I keep this PR merged and add Postgresql interpreter
again. I think this is more easier way to add Postgresql interpreter.
---
If your
Github user beeva-victorgarcia commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-172525500
ok, no problem when I can add docs.
@jongyoul you move the generic jdbc and restore the PostgresQL Interprete?
---
If your project is set
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-172523822
@vgmartinez Our goal is to move to the generic jdbc interpreter, finally.
Could you please contribute a document?
---
If your project is set up for it, yo
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-172522382
@tzolov Hi, your opinion makes sense. @Leemoonsoo also worried about
changing Postgresql to Jdbc, but I don't think it's a big problem because I
will add au
Github user tzolov commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-172505545
Thanks for the quick response @vgmartinez ,
The SqlCompleter (removed by the last commit) is meant to be 100% JDBC API
compliant and hopefully easy t
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-172495765
Hi @tzolov,
Yes, the interpreter is based on the PostgreSQL was mentioned
https://github.com/apache/incubator-zeppelin/pull/608. I think is that we
Github user tzolov commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-172492176
@vgmartinez , @felixcheung , @asfgit, @Leemoonsoo
Hello guys, I am sorry to jump a bit late.
First let me say that I am glad that you have decided to
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/361
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fea
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-172415835
@vgmartinez Thanks, I'll merge it. Did you make a PR for docs? or will you
make it?
---
If your project is set up for it, you can reply to this email and h
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-172359934
hi @jongyoul,
It ready...in other PR add docs for the interpreter
---
If your project is set up for it, you can reply to this email and have your
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-172355131
@vgmartinez Hi, Could you please rebase this PR one more? Some logging
codes are added by another PR. After that rebase, I'll merge it immediately.
---
If
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-172354008
@Leemoonsoo Thanks for the reply. I'll merge this PR after resolving
conflict.
---
If your project is set up for it, you can reply to this email and have y
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-172353917
@jongyoul Thanks for consideration. Please feel free to merge regardless of
upcoming meetup. If i need, i can always use specific commit from git
reposito
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-172348402
@vgmartinez Sorry for late reply. @Leemoonsoo Do you introduce or use the
postgresql interpreter from master branch on the upcoming meetup at 21st Jan?
If y
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-172103321
Hi @jongyoul @Leemoonsoo,
There is something more to fix or to make the merge...
---
If your project is set up for it, you can reply to this email and
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-170316015
LGTM. Merging if there isn't no more discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-170147338
I removed the dependencies and add the postgres dependency to have it by
default without having to add the jar to the classpath. What do you think?
---
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-170056833
I think postgresql is good candidate to be default, too. Leaving it
undecided also good to me.
---
If your project is set up for it, you can reply to thi
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-170033129
@vgmartinez Thanks for making it clear. You look like that you want to
includes some jdbc connectors but it's not appropriate because we don't decide
which
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-169939310
Hi @jongyoul,
Is rebase now...let me know if you need help with testing or anything else.
---
If your project is set up for it, you can reply to this
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-169863487
And... Could you please rebase your changes only and ``push --force`` ?
That makes commits clear
---
If your project is set up for it, you can reply to thi
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-169863282
@vgmartinez Yes, HiveInterpreter is based on this interpreter, but I
thought it's a natural way of you to commit this PR, then I fix to support to
multiple
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-169696454
Hi @jongyoul,
I think it is not necessary to add another interpreter, I think you can
improve the interpreter hive to add the jars to the classpath and
Github user vgmartinez closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/608
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/608#issuecomment-169639840
Hi @jongyoul,
Please review this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user vgmartinez closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/361
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-168941295
@vgmartinez Thanks for quick response. And first of all, could you rebase
this PR? this PR won't be merged into current master until you rebase it.
---
If
Github user beeva-victorgarcia commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-168940927
Hi @jongyoul,
Yes, this week I can complete the PR...
---
If your project is set up for it, you can reply to this email and have your
reply ap
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-168940465
@vgmartinez It took a long time to reach this PR. I hope you could share
your time to complete this PR. Basically, this implementation looks good to me,
but
Github user vrajat commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-168020790
I read your mail. I understand why you are following this process.
I am voting for a requirement that seems to be missing in others but is
satisfied in
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-168008003
@vrajat And I also think JDBC interpreter supports all kind of JDBC drivers.
---
If your project is set up for it, you can reply to this email and have your
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-168004929
@vrajat Thanks for taking an interest in this issue and being willing to
contribute your code. I have a plan to merge several jdbc-like interpreters
until 0
Github user vrajat commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-167984726
FWIW - I vote for this implementation of JDBC Interpreter. I understand
that your focus is on well-known databases - mysql, postgres etc.
I am working wit
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-164620557
And could you please check
https://www.mail-archive.com/dev@zeppelin.incubator.apache.org/msg05504.html at
dev@. I, strongly, think every contribution shoul
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-164620107
@vgmartinez Sorry for delay. I've committed #455 #517 for supporting
multiple instances - connections - Because that's based on this interpreter, it
would b
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-163870545
Hi @jongyoul,
Sorry for my delay ...;) as we move forward with the discussion about the
interpreter jdbc ...? I can improve this withdrawal request wit
Github user beeva-victorgarcia commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-163870346
Hi @jongyoul,
Sorry for my delay ...;) as we move forward with the discussion about the
interpreter jdbc ...? I can improve this withdrawal req
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-160284341
@jiekechoo This interpreter is based on jdbc connecttion, and this PR makes
PostgreSqlInterpreter change JdbcInterpreter only. Thus you can use
PostgrsSqlIn
Github user jiekechoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-160135681
@jongyoul I mean how to use jdbc interpreter.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-160021026
@jiekechoo You can find a document on
http://zeppelin.incubator.apache.org/docs/0.5.5-incubating/interpreter/postgresql.html
1. Set the driver
Github user jiekechoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-160019122
How to get this function?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-156319520
@felixcheung
1.
http://docs.oracle.com/javase/7/docs/api/java/sql/DriverManager.html#getConnection(java.lang.String,%20java.util.Properties)
would
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-152012132
If I recall there were 3 areas of discussions around JDBC:
1. JDBC url, authentication etc would need to be extensible since they vary
greatly between
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-151794561
As @felixcheung mentioned, there were couple of attempt.
This patch renames existing postgresql to jdbc. So if renaming does not
bring big problem, I t
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-151024130
@felixcheung There are several implementations for jdbc. We should talk
about it for focusing one issue. Do you have any idea?
+ @Leemoonsoo
---
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-150986836
There's another earlier attempt for this #211, #60
Other JDBC-like use cases perhaps you could also factor into your design?
#73, #110
---
If your
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-150933832
Hi @jongyoul,
Thanks for the feedback...I will implement the suggestion
---
If your project is set up for it, you can reply to this email and have
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-150919985
@vgmartinez Finally, How about adding a `ZEPPELIN_INTP_CLASSPATH` to
zeppelin-env.sh and making it added by interpreter.sh?
---
If your project is set up f
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-150918917
@vgmartinez Thanks for contribution on this issue which @Leemoonsoo and I
talk about a few days ago. It will covers several Interpreters using JDBC.
---
I
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-150918846
@vgmartinez
https://github.com/vgmartinez/incubator-zeppelin/blob/jdbc_interpreter/jdbc/src/main/java/org/apache/zeppelin/jdbc/JDBCInterpreter.java#L146
How
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-150661569
@tzolov
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
GitHub user vgmartinez opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/361
JDBC generic interpreter
Only you need to add to the classpath the jdbc connector jar and the
interpreter add the particular properties for each db.
In the file zeppelin-daemon.sh
60 matches
Mail list logo
