[GitHub] incubator-zeppelin pull request: Prevent server calls when there i...

2016-01-06 Thread Karuppayya
Github user Karuppayya commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/559#issuecomment-169302930 Closing this PR based on above discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] incubator-zeppelin pull request: Prevent server calls when there i...

2016-01-06 Thread Karuppayya
Github user Karuppayya closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/559 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-zeppelin pull request: Prevent server calls when there i...

2015-12-29 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/559#issuecomment-167921950 To me, it make sense to let run empty paragraph while this allow each different interpreter implement their own behavior for empty input. If we de

[GitHub] incubator-zeppelin pull request: Prevent server calls when there i...

2015-12-29 Thread corneadoug
Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/559#issuecomment-167920273 @Leemoonsoo What is the decision about this PR in the end? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] incubator-zeppelin pull request: Prevent server calls when there i...

2015-12-22 Thread Karuppayya
Github user Karuppayya commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/559#issuecomment-166567968 @Leemoonsoo i was not aware of the use cases. if its natural behaviour, then we can allow running of empty paras. May be we have to put the CSS c

[GitHub] incubator-zeppelin pull request: Prevent server calls when there i...

2015-12-21 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/559#issuecomment-166534240 Could you change the description to follow our PR Template? (you can find it [here] (https://github.com/apache/incubator-zeppelin/blob/master/CONTR

[GitHub] incubator-zeppelin pull request: Prevent server calls when there i...

2015-12-21 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/559#issuecomment-166505477 Tested and found 'Cannot run an empty paragraph ' message does not raise with 'Shift+Enter' shortcut. By the way, I thought running empty paragrap

[GitHub] incubator-zeppelin pull request: Prevent server calls when there i...

2015-12-21 Thread Karuppayya
GitHub user Karuppayya opened a pull request: https://github.com/apache/incubator-zeppelin/pull/559 Prevent server calls when there is no data in paragraphs *Whenever there is no text text in para, server call are made to run para. With this PR, the paras will be run only where