[GitHub] incubator-zeppelin pull request: Replace standard basic-auth dialo...

2016-03-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/801 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] incubator-zeppelin pull request: Replace standard basic-auth dialo...

2016-03-29 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/801#issuecomment-203258628 Merge into master if there're no more discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] incubator-zeppelin pull request: Replace standard basic-auth dialo...

2016-03-29 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/801#issuecomment-202844427 @prabhjyotsingh Checked last commit. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] incubator-zeppelin pull request: Replace standard basic-auth dialo...

2016-03-28 Thread AhyoungRyu
Github user AhyoungRyu commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/801#issuecomment-202726499 @prabhjyotsingh Absolutely better than before :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] incubator-zeppelin pull request: Replace standard basic-auth dialo...

2016-03-28 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/801#issuecomment-202691934 Thanks for the feedback @Leemoonsoo, have restrict access to notebook(s) without login. --- If your project is set up for it, you can reply to this e

[GitHub] incubator-zeppelin pull request: Replace standard basic-auth dialo...

2016-03-28 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/801#issuecomment-202445244 @prabhjyotsingh Cool improvement! I tried. And found that i can access notebook without login after enables authentication by editing shiro.ini.

[GitHub] incubator-zeppelin pull request: Replace standard basic-auth dialo...

2016-03-28 Thread prabhjyotsingh
GitHub user prabhjyotsingh opened a pull request: https://github.com/apache/incubator-zeppelin/pull/801 Replace standard basic-auth dialog with BootstrapDialog for user authentication ### What is this PR for? Instead of showing standard basic-auth dialog, replace the same with