[GitHub] incubator-zeppelin pull request: Save all repos, and not just the ...

2015-10-14 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/318#issuecomment-148064890 Thanks @dirceusemighini. Please take your time. As @khalidhuseynov commented, I think [sync()](https://github.com/apache/incubator-zeppelin/blob/m

[GitHub] incubator-zeppelin pull request: Save all repos, and not just the ...

2015-10-14 Thread dirceusemighini
Github user dirceusemighini commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/318#issuecomment-148039317 Hi @Leemoonsoo latter this week I will update the test to assure that the code is running fine. --- If your project is set up for it, you can reply

[GitHub] incubator-zeppelin pull request: Save all repos, and not just the ...

2015-10-07 Thread hsaputra
Github user hsaputra commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/318#issuecomment-146314427 Hi @dirceusemighini, could you also update the description of this PR with more info of what is the intended change and the desired behavior? It wil

[GitHub] incubator-zeppelin pull request: Save all repos, and not just the ...

2015-10-07 Thread dirceusemighini
Github user dirceusemighini commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/318#issuecomment-146211856 Hi Guys, I was on vacation and just returned. So, we still can't open more than two repos, but does this code will help on saving when the opti

[GitHub] incubator-zeppelin pull request: Save all repos, and not just the ...

2015-10-04 Thread khalidhuseynov
Github user khalidhuseynov commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/318#issuecomment-145325073 I think this PR doesn't add synchronization for more than 2 repos, it just saves to all available repos. The reason is that there's still limit on the

[GitHub] incubator-zeppelin pull request: Save all repos, and not just the ...

2015-10-03 Thread khalidhuseynov
Github user khalidhuseynov commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/318#issuecomment-145230159 @dirceusemighini I believe `getSimpleName` should be fine --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] incubator-zeppelin pull request: Save all repos, and not just the ...

2015-10-02 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/318#issuecomment-145210388 Nice improvement! Could you update https://github.com/apache/incubator-zeppelin/blob/master/zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/rep

[GitHub] incubator-zeppelin pull request: Save all repos, and not just the ...

2015-09-23 Thread dirceusemighini
Github user dirceusemighini commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/318#issuecomment-142589013 I used getSimple name in the repo class, do you think that someone could use an anonymous class in here? --- If your project is set up for it, you c

Re: [GitHub] incubator-zeppelin pull request: Save all repos, and not just the ...

2015-09-23 Thread Dirceu Semighini Filho
Hi Khaliduseynov, Thank you for looking into this, is there any guide on how can I run CI here? 2015-09-22 23:03 GMT-03:00 khalidhuseynov : > Github user khalidhuseynov commented on the pull request: > > > https://github.com/apache/incubator-zeppelin/pull/318#issuecomment-142471747 > > Existi

[GitHub] incubator-zeppelin pull request: Save all repos, and not just the ...

2015-09-22 Thread khalidhuseynov
Github user khalidhuseynov commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/318#issuecomment-142471747 Existing implementation gives more focus on the existence of maximum of two backend repos. The change makes it look more logical in case we add more b

[GitHub] incubator-zeppelin pull request: Save all repos, and not just the ...

2015-09-22 Thread dirceusemighini
GitHub user dirceusemighini opened a pull request: https://github.com/apache/incubator-zeppelin/pull/318 Save all repos, and not just the first two You can merge this pull request into a Git repository by running: $ git pull https://github.com/dirceusemighini/incubator-zeppeli