[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...

2016-04-27 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-215126055 Great - will you have time to get that ready then? _ --- If your project is set up

[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...

2016-04-27 Thread Madhuka
Github user Madhuka commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-214997716 Referee #765 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...

2016-04-27 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-214995913 Based on the earlier comment, are we moving to #728 then? --- If your project is set up for it, you can reply to

[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...

2016-04-26 Thread yanglei99
Github user yanglei99 commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-214961384 When will this be in the main stream?It is a pity to see some great function missing while the solution is already available for more than half a year.

[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...

2016-04-08 Thread ankurmitujjain
Github user ankurmitujjain commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-207395845 @Madhuka Any update on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...

2016-02-19 Thread corneadoug
Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-186336504 After discussion with @Madhuka, this should be rebased and finished by 1st week of March. (since he is busy) There has been a new PR opened

[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...

2016-02-09 Thread ankurmitujjain
Github user ankurmitujjain commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-181825058 Hi @Madhuka any update on this? really appreciate your effort for this. Thanks --- If your project is set up for it, you can reply to this email

[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...

2016-02-06 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-180840046 any update on this? @Madhuka this would be very cool to have --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...

2015-12-15 Thread corneadoug
Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-164705767 @Madhuka Are you working on a new PR? Tell me if you need some help --- If your project is set up for it, you can reply to this email and have your

[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...

2015-12-08 Thread randerzander
Github user randerzander commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-163108454 @Madhuka @bzz what's holding this one up? Is there something someone else can do to get this across the goal line? --- If your project is set up for

[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...

2015-12-08 Thread Madhuka
Github user Madhuka commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-163121874 @corneadoug : Thanks, get #262, it contain data validation. So new PR will have only Map Vis. --- If your project is set up for it, you can reply to

[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...

2015-12-08 Thread corneadoug
Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-163109639 @randerzander @Madhuka I'm reviewing #262 first, already took a look at it. I'm planning on finishing review on those 3 PR this week. But I

[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...

2015-09-23 Thread Madhuka
Github user Madhuka commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-142812217 @bzz : ZeppelinIT which is failed in CI run fine in local environment. I have re-base (update) the PR. is there any more things to do for this PR?

[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...

2015-09-20 Thread Madhuka
Github user Madhuka commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-141870314 @bzz : I wil verify in my local env. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...

2015-09-17 Thread randerzander
Github user randerzander commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-141191419 anything we can do to figure out the failing CI build issue? This feature is incredibly useful- will stop quite a lot of HTML and JS hacking for users

[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...

2015-09-10 Thread Madhuka
Github user Madhuka commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-139316805 @bzz : I have updated the PR to master. Build has run for multiple times, and any idea or reason to run build for multiple times. --- If your project is

[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...

2015-09-09 Thread Madhuka
Github user Madhuka commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-138859366 @buzz I will try to make both checks in green --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...

2015-09-08 Thread Madhuka
Github user Madhuka commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-138777945 @bzz : Even after rebase CI is giving fail and CI build has run for two times last one is successful and first one is fail in zeppelin server test. (where

[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...

2015-09-08 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-138790015 `This branch has conflicts that must be resolved` signifies that it is not aligned with the latest master, you need to make sure both checks are green here.

[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...

2015-08-19 Thread Madhuka
Github user Madhuka commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-132897074 The Travis CI is only check first Build only, isn't it? First build test failure which is bind to CI and In next build It was fine. According to log second

[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...

2015-08-17 Thread Madhuka
Github user Madhuka commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-131800619 yes, Build has run multiple times and final build was successful according to log files. But there is still one failing check. --- If your project is set

[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...

2015-08-17 Thread corneadoug
Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-131722364 The Build runs multiple time on the CI --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...

2015-08-16 Thread eranwitkon
Github user eranwitkon commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-131536089 Cool that did the trick. Now that I can run the code I found this behavior : Try the following code: %sql select Name from myMap

[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...

2015-08-15 Thread Madhuka
Github user Madhuka commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-131391418 ![screenshot from 2015-08-15 20 40 30](https://cloud.githubusercontent.com/assets/1180128/9289469/6b9dc096-438e-11e5-9d43-cf41980ed485.png) Test are

[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...

2015-08-03 Thread Madhuka
Github user Madhuka commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-127289349 Data validator message will contain {'error':true/false,'msg':'error msg'}. Data schema can be set as config file. Data validator is expose as service

[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...

2015-07-27 Thread Madhuka
Github user Madhuka commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-125176472 In Data `validatorservices` will return error status in boolean true or false. And also it will return error msg with explanation which data record is not

[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...

2015-07-24 Thread Madhuka
Github user Madhuka commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-124595000 Loading sample data from internet ![screenshot from 2015-07-24 23 11

[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...

2015-07-20 Thread Madhuka
Github user Madhuka commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-122901099 Add it as in tutorial, where it can be run from the clean environment ![screenshot from 2015-07-20 19 04

[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...

2015-07-20 Thread tog
hi Madhuka I am looking forward testing it. Have you considered plotting trajectories (lines between 2 points) and disks - and make this a default plots for specific tables for example? Cheers Guillaume On Monday, July 20, 2015, Madhuka g...@git.apache.org

[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...

2015-07-12 Thread Madhuka
Github user Madhuka commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-120754413 Map Visualization for Zeppelin ![screenshot from 2015-07-13 00 18

[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...

2015-07-12 Thread vgmartinez
Github user vgmartinez commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-120761338 Hi @Madhuka when you try to resize the paragraph the map does not update to the new size ... I have seen that you have: leaflet width=100%

[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...

2015-07-12 Thread Madhuka
GitHub user Madhuka opened a pull request: https://github.com/apache/incubator-zeppelin/pull/152 ZEPPELIN-157: Adding Map Visualization for Zeppelin - [x] Listing Map charting Libraries - [x] Checking compatible license - [x] Adding chart library (leafletjs) - [x]