GitHub user prabhjyotsingh opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/356
ZEPPELIN-235: jscs in zeppelin-web
ZEPPELIN-235: jscs in zeppelin-web
used following for .jscsrc
{
"preset": "google",
"maximumLineLength": {
"value": 120,
Github user prabhjyotsingh closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/229
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/229#issuecomment-149836145
Closing this, will open up again with fixed changes
---
If your project is set up for it, you can reply to this email and have your
reply appear on Gi
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/229#issuecomment-134494232
Can we start something basic, and then keep improvising it on the need
basis?
Also, I thought "preset": "google" will take care of a lot of thing
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/229#issuecomment-134286869
Well I'm using Intellij Idea, and on pressing Control + Shift + A spawns up
this menu, which does the job. I'm sure similar option should be available
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/229#issuecomment-134234729
Our base is the google guideline, so using its prefix sounds good.
But I'm having some trouble when re-indenting the code in my text editor.
Especia
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/229#issuecomment-134127299
Sure giving a 4 spaces prefix indent for the function code, makes code look
slightly more cleaner.
I thought of 120 characters in line, becau
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/229#issuecomment-133779847
We might have to work on the configuration for indentation.
### Example:
current formatting in this branch
```
angular.module
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/229#issuecomment-132926557
@corneadoug Intellij Idea fixed most if not all of the issues. However if
build fails, or if there are errors in merging this to master, this will surl
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/229#issuecomment-132894654
I guess there might be plenty of errors, do you need help cleaning them?
---
If your project is set up for it, you can reply to this email and have your
r
GitHub user prabhjyotsingh opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/229
ZEPPELIN-235: jscs in zeppelin-web
used following for .jscsrc
{
"preset": "google",
"maximumLineLength": {
"value": 120,
"allExcept": [ "commen
11 matches
Mail list logo
