[GitHub] incubator-zeppelin pull request: ZEPPELIN-294 Enable karma code co...

2015-10-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/292 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] incubator-zeppelin pull request: ZEPPELIN-294 Enable karma code co...

2015-10-04 Thread corneadoug
Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/292#issuecomment-145336434 @r-kamath I think it is good like that We can't really use it without us activating coveralls on that repository, but it will be the work of another is

[GitHub] incubator-zeppelin pull request: ZEPPELIN-294 Enable karma code co...

2015-09-29 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/292#issuecomment-144015973 @corneadoug let me know if I have missed anything here --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] incubator-zeppelin pull request: ZEPPELIN-294 Enable karma code co...

2015-09-13 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/292#issuecomment-139978374 http://stackoverflow.com/a/26635182 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-zeppelin pull request: ZEPPELIN-294 Enable karma code co...

2015-09-13 Thread corneadoug
Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/292#issuecomment-139978106 I still would love to know how to read that report, and could be added to our docs --- If your project is set up for it, you can reply to this email and

[GitHub] incubator-zeppelin pull request: ZEPPELIN-294 Enable karma code co...

2015-09-13 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/292#issuecomment-139973768 Change looks good to me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] incubator-zeppelin pull request: ZEPPELIN-294 Enable karma code co...

2015-09-10 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/292#issuecomment-139183078 @corneadoug Thanks for the comment. Updated in 5316b61 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

Re: [GitHub] incubator-zeppelin pull request: ZEPPELIN-294 Enable karma code co...

2015-09-10 Thread IT CTO
Is this going to be mandatory threshold during CI? Report can be same as RAT report, right? On Thu, Sep 10, 2015 at 10:30 AM corneadoug wrote: > Github user corneadoug commented on the pull request: > > > https://github.com/apache/incubator-zeppelin/pull/292#issuecomment-139138641 > > I woul

[GitHub] incubator-zeppelin pull request: ZEPPELIN-294 Enable karma code co...

2015-09-10 Thread corneadoug
Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/292#issuecomment-139138641 I wouldn't export the report in the ``dist`` directory since it is not directly related to zeppelin usage. Maybe ``reports/coverage`` instead. (and hav

[GitHub] incubator-zeppelin pull request: ZEPPELIN-294 Enable karma code co...

2015-09-10 Thread r-kamath
GitHub user r-kamath opened a pull request: https://github.com/apache/incubator-zeppelin/pull/292 ZEPPELIN-294 Enable karma code coverage plugin https://cloud.githubusercontent.com/assets/2031306/9782316/e27a2d8c-57b9-11e5-9c13-c9ff212c7bc0.png";> You can merge this pull request in