[GitHub] incubator-zeppelin pull request: ZEPPELIN-315 Fix time-dependant s...

2015-11-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/315 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] incubator-zeppelin pull request: ZEPPELIN-315 Fix time-dependant s...

2015-11-10 Thread FRosner
Github user FRosner commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/315#issuecomment-155467136 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

[GitHub] incubator-zeppelin pull request: ZEPPELIN-315 Fix time-dependant s...

2015-11-10 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/315#issuecomment-155444690 Okay, Merging it if there're no more discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[GitHub] incubator-zeppelin pull request: ZEPPELIN-315 Fix time-dependant s...

2015-11-10 Thread RPCMoritz
Github user RPCMoritz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/315#issuecomment-155355447 @Leemoonsoo I'd really like to be able to tick this one off of my list - any chance of merging this soon? --- If your project is set up for it, you can re

[GitHub] incubator-zeppelin pull request: ZEPPELIN-315 Fix time-dependant s...

2015-10-27 Thread RPCMoritz
Github user RPCMoritz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/315#issuecomment-151411072 Unclear what caused that build to fail - retrying --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] incubator-zeppelin pull request: ZEPPELIN-315 Fix time-dependant s...

2015-10-27 Thread RPCMoritz
Github user RPCMoritz closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/315 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-zeppelin pull request: ZEPPELIN-315 Fix time-dependant s...

2015-10-27 Thread RPCMoritz
GitHub user RPCMoritz reopened a pull request: https://github.com/apache/incubator-zeppelin/pull/315 ZEPPELIN-315 Fix time-dependant scheduling test test-schedule can fail when it starts late in a second, as the result will then return the next second due to in-system delays (partic

[GitHub] incubator-zeppelin pull request: ZEPPELIN-315 Fix time-dependant s...

2015-10-23 Thread RPCMoritz
Github user RPCMoritz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/315#issuecomment-150604474 Rebased to current master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] incubator-zeppelin pull request: ZEPPELIN-315 Fix time-dependant s...

2015-10-22 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/315#issuecomment-150468613 Appreciated If you rebase. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] incubator-zeppelin pull request: ZEPPELIN-315 Fix time-dependant s...

2015-10-22 Thread RPCMoritz
Github user RPCMoritz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/315#issuecomment-150260023 Looks like your last commit broke diff's ability to properly locate these lines. Should I attempt to rebase, or can you take care of this during the merge?

[GitHub] incubator-zeppelin pull request: ZEPPELIN-315 Fix time-dependant s...

2015-10-11 Thread RPCMoritz
Github user RPCMoritz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/315#issuecomment-147173875 This merely gives the cron configuration one second to become effective, before testing whether the job is still running, using the same logic as before.

[GitHub] incubator-zeppelin pull request: ZEPPELIN-315 Fix time-dependant s...

2015-10-11 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/315#issuecomment-147171849 The test case was intended to test, 1) create a paragraph 2) set cron expression and wait for paragraph finishes. to verify cron scheduler wo

[GitHub] incubator-zeppelin pull request: ZEPPELIN-315 Fix time-dependant s...

2015-10-07 Thread RPCMoritz
Github user RPCMoritz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/315#issuecomment-146189825 @Leemoonsoo could you take a look at this one? It's a pretty straighforward fix. --- If your project is set up for it, you can reply to this email and hav