[GitHub] incubator-zeppelin pull request: ZEPPELIN-387 Allow enable/disable...

2015-11-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/414 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] incubator-zeppelin pull request: ZEPPELIN-387 Allow enable/disable...

2015-11-23 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/414#issuecomment-158911266 merging if there're no more discussions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] incubator-zeppelin pull request: ZEPPELIN-387 Allow enable/disable...

2015-11-21 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/414#issuecomment-158633626 Tested, working nicely. Looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] incubator-zeppelin pull request: ZEPPELIN-387 Allow enable/disable...

2015-11-20 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/414#issuecomment-158595978 Tested, works as expected on FF, chrome, safari, IE10 and Edge (12) --- If your project is set up for it, you can reply to this email and have your re

[GitHub] incubator-zeppelin pull request: ZEPPELIN-387 Allow enable/disable...

2015-11-20 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/414#issuecomment-158579034 @corneadoug @Leemoonsoo build issues are fixed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] incubator-zeppelin pull request: ZEPPELIN-387 Allow enable/disable...

2015-11-17 Thread corneadoug
Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/414#issuecomment-157604401 @r-kamath seems there is some test failing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] incubator-zeppelin pull request: ZEPPELIN-387 Allow enable/disable...

2015-11-17 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/414#issuecomment-157418759 @corneadoug fixed the z.run() case in bdf703d --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] incubator-zeppelin pull request: ZEPPELIN-387 Allow enable/disable...

2015-11-15 Thread corneadoug
Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/414#issuecomment-156947126 I tried it, and there might be another case we should handle: z.run(4) (for example) will run your paragraph. I think it could be better if this kin

[GitHub] incubator-zeppelin pull request: ZEPPELIN-387 Allow enable/disable...

2015-11-15 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/414#issuecomment-156930130 @Leemoonsoo @corneadoug @jongyoul updates from 3a7175a https://cloud.githubusercontent.com/assets/2031306/11175456/6b5e88dc-8c58-11e5-99ff-adfcee4e15

[GitHub] incubator-zeppelin pull request: ZEPPELIN-387 Allow enable/disable...

2015-11-12 Thread jongyoul
Github user jongyoul commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/414#issuecomment-156318918 +1 for `Enable/Disable run` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] incubator-zeppelin pull request: ZEPPELIN-387 Allow enable/disable...

2015-11-10 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/414#issuecomment-155631510 +1 for Enable/Disable run than Enable/Disable paragraph. --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] incubator-zeppelin pull request: ZEPPELIN-387 Allow enable/disable...

2015-11-10 Thread corneadoug
Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/414#issuecomment-155625281 After thinking about it more, _Enable paragraph_ and _Disable paragraph_ can be a bit confusing since the paragraph is still shown. _Enable run_ a

[GitHub] incubator-zeppelin pull request: ZEPPELIN-387 Allow enable/disable...

2015-11-10 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/414#issuecomment-155385289 Hi @corneadoug, That sounds like a right spot for the enable/disable menu item. Updated in 87aa4e8. Please take a look at the new screenshots. Thanks!

[GitHub] incubator-zeppelin pull request: ZEPPELIN-387 Allow enable/disable...

2015-11-09 Thread corneadoug
Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/414#issuecomment-155297426 Hi, Maybe you could keep the same style as the other (without checkbox) and with an icon (like the run button). Also that menu position could be lo

[GitHub] incubator-zeppelin pull request: ZEPPELIN-387 Allow enable/disable...

2015-11-09 Thread r-kamath
GitHub user r-kamath opened a pull request: https://github.com/apache/incubator-zeppelin/pull/414 ZEPPELIN-387 Allow enable/disable of specific paragraphs - When "run all" is called the disabled paragraphs are not executed. - There is no "run" button for a disabled paragraph.