[GitHub] incubator-zeppelin pull request: ZEPPELIN-501 Notebook search

Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/534#issuecomment-166856151 Tested and works really well. Thanks for really useful new feature. LGTM! --- If your project is set up for it, you can reply to this email and have

[GitHub] incubator-zeppelin pull request: ZEPPELIN-501 Notebook search

Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/534#issuecomment-166856636 Thank you! Merging if there are no other discussions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] incubator-zeppelin pull request: ZEPPELIN-501 Notebook search

Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/534#issuecomment-166783404 @Leemoonsoo thank you for thought testing and review! Scope is updated, will address all the feedback, and let you know. --- If your project is set up for it,

[GitHub] incubator-zeppelin pull request: ZEPPELIN-501 Notebook search

Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/534#issuecomment-166612706 @bzz Great work. Seems like index is not updated after paragraph remove. Is it possible to be handled? --- If your project is set up for it, you can

[GitHub] incubator-zeppelin pull request: ZEPPELIN-501 Notebook search

Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/534#issuecomment-166600360 @Leemoonsoo All reviews are addressed, I think it's ready to be merged. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] incubator-zeppelin pull request: ZEPPELIN-501 Notebook search

Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/534#issuecomment-166614398 Following error is thrown when persisting changes of notebook which loaded on Zeppelin startup (not created after start up) ```

[GitHub] incubator-zeppelin pull request: ZEPPELIN-501 Notebook search

Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/534#issuecomment-165332326 CI now fails with exactly the same case as on master under [ZEPPELIN-510](https://issues.apache.org/jira/browse/ZEPPELIN-510) ``` pabilities

[GitHub] incubator-zeppelin pull request: ZEPPELIN-501 Notebook search

Github user vgmartinez commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/534#issuecomment-164727893 LGTM... It is a good feature --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-zeppelin pull request: ZEPPELIN-501 Notebook search

Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/534#issuecomment-164742605 @bzz Could you rewrite the PR description following the PR template

[GitHub] incubator-zeppelin pull request: ZEPPELIN-501 Notebook search

GitHub user bzz opened a pull request: https://github.com/apache/incubator-zeppelin/pull/534 ZEPPELIN-501 Notebook search This implements [ZEPPELIN-501](https://issues.apache.org/jira/browse/ZEPPELIN-501) - a full-text search though paragraph inputs. ![screen shot

[GitHub] incubator-zeppelin pull request: ZEPPELIN-501 Notebook search

Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/534#issuecomment-164945411 Thank you all guys for timely reviews and kind feedback! TODOs: - [ ] tix fypos :dancer: - [ ] fix js issue in js console - [ ] update

[GitHub] incubator-zeppelin pull request: ZEPPELIN-501 Notebook search

Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/534#issuecomment-164752442 @vgmartinez than you for positive feedback! @corneadoug well, I expected a bit more of the code review, rather than "Wrong formatting of the PR

[GitHub] incubator-zeppelin pull request: ZEPPELIN-501 Notebook search

Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/534#issuecomment-164755385 @bzz Of course, the code review will come :) Well, JIRA issue is JIRA issue, PR Template is PR Template :) You will find that there is a lot

[GitHub] incubator-zeppelin pull request: ZEPPELIN-501 Notebook search

Github user khalidhuseynov commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/534#issuecomment-164975439 thanks for a nice feature! one more question: in case of large number or notebooks (volume to be indexed), can there be any problem (e.g. system

[GitHub] incubator-zeppelin pull request: ZEPPELIN-501 Notebook search

Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/534#issuecomment-164978015 @khalidhuseynov >in case of large number or notebooks (volume to be indexed), can there be any problem (e.g. system resources exhaustion) because of

[GitHub] incubator-zeppelin pull request: ZEPPELIN-501 Notebook search

Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/534#issuecomment-164978523 @corneadoug thanks for description update, have moved everything there --- If your project is set up for it, you can reply to this email and have your reply