[GitHub] incubator-zeppelin pull request: ZEPPELIN-528 REST API: add "progr...

2015-12-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/563 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] incubator-zeppelin pull request: ZEPPELIN-528 REST API: add "progr...

2015-12-24 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/563#issuecomment-167065178 Great. Looks good to me. Merge if there're no more discussions --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] incubator-zeppelin pull request: ZEPPELIN-528 REST API: add "progr...

2015-12-23 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/563#issuecomment-167047627 @Leemoonsoo Thanks for merging ZEPPELIN-527! Upmerged and add UT. --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] incubator-zeppelin pull request: ZEPPELIN-528 REST API: add "progr...

2015-12-23 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/563#issuecomment-167026319 @Leemoonsoo Thanks for sharing the idea! It works like a charm! But new unit test requires ZEPPELIN-527 to be merged since API returns HTTP STATU

[GitHub] incubator-zeppelin pull request: ZEPPELIN-528 REST API: add "progr...

2015-12-23 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/563#issuecomment-166854142 Thanks! LGTM If you would like to add UT in ZeppelinRestApiTest, you can add a such paragraph ```%sh sleep 1``` instead of https://github.com/apa

[GitHub] incubator-zeppelin pull request: ZEPPELIN-528 REST API: add "progr...

2015-12-22 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/563#issuecomment-166755709 @Leemoonsoo Addressed your comment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] incubator-zeppelin pull request: ZEPPELIN-528 REST API: add "progr...

2015-12-22 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/563#issuecomment-166752028 UT = Unit test :) I'll address the doc and let you know when complete. --- If your project is set up for it, you can reply to this email and have you

[GitHub] incubator-zeppelin pull request: ZEPPELIN-528 REST API: add "progr...

2015-12-22 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/563#issuecomment-166718539 Thanks for the good improvement. I think it's better add an example of the JSON output that includes 'progress' field. Could you give me a hint tha

[GitHub] incubator-zeppelin pull request: ZEPPELIN-528 REST API: add "progr...

2015-12-21 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/563#issuecomment-166528935 Two questions here, - Can I trap RUNNING status of the paragraph in UT? I don't have an idea to make it, so I can't add UT for now. - Would i

[GitHub] incubator-zeppelin pull request: ZEPPELIN-528 REST API: add "progr...

2015-12-21 Thread HeartSaVioR
GitHub user HeartSaVioR opened a pull request: https://github.com/apache/incubator-zeppelin/pull/563 ZEPPELIN-528 REST API: add "progress" to 'get notebook job' API ### What is this PR for? To add 'progress' to 'get notebook job' REST API. All paragraphs which status is