Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/590
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fea
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/590#issuecomment-171128338
Great. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user minahlee commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/590#issuecomment-17761
Rebased master branch and CI build passed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/590#issuecomment-170316643
LGTM!! It also makes any kind of jars loaded easily. I could load JDBC
libraries using this feature.
---
If your project is set up for it, you can reply to
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/590#issuecomment-169193256
@minahlee @AhyoungRyu - thanks for explanations, makes perfect sense to
have 2 PRs for 2 ppl!
Looks good to me.
---
If your project is set up for it, y
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/590#issuecomment-169190669
@Leemoonsoo Yes, it will be better to have both at the same time to merge
them together.
Its just to keep features documented as we include them in the
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/590#issuecomment-169153578
I think how to split large work into small peices of PRs is up to
contributors. (although smaller PR helps review process)
If necessary documentation f
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/590#issuecomment-169144424
@minahlee still doesn't make much sense to separate the docs into a
different PR.
At least create both PR so that we can merge both at the same time.
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/590#issuecomment-168936778
Looks great! A quick question if it's ready to merge:
`zeppelin-interpreter/pom.xml` was changed with dependencies added but you
think there is no need to mentio
GitHub user minahlee opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/590
ZEPPELIN-546 Enables interpreter library loading from maven repository
### What is this PR for?
This PR enables library loading from maven repository to load interpreter
binaries.
10 matches
Mail list logo
