[GitHub] incubator-zeppelin pull request: getPort should not have curly bra...

2015-06-30 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/127#issuecomment-117275060 Because of AppScriptServlet replace `function getPort() { ... }` by detecting `}`. Please check https://github.com/apache/incubator-zeppelin/blob/master/

[GitHub] incubator-zeppelin pull request: getPort should not have curly bra...

2015-06-29 Thread corneadoug
Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/127#issuecomment-116892833 Hi, @echarles Can you explain to me exactly what is the relation between the getPort function and the AppScriptServlet? And how they work togethe

[GitHub] incubator-zeppelin pull request: getPort should not have curly bra...

2015-06-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/127 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] incubator-zeppelin pull request: getPort should not have curly bra...

2015-06-28 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/127#issuecomment-116357013 Thank you for bringing it in again! Looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] incubator-zeppelin pull request: getPort should not have curly bra...

2015-06-28 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/127#issuecomment-116302183 Thanks! Looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] incubator-zeppelin pull request: getPort should not have curly bra...

2015-06-28 Thread echarles
GitHub user echarles opened a pull request: https://github.com/apache/incubator-zeppelin/pull/127 getPort should not have curly bracket in its body This patch simply remove the usage of curly bracket in the body of the getPort method of the app.js. This is needed so the AppScrip