Re: Deserialization issue for AngularObject in RemoteInterpreterServer

2016-01-30 Thread moon soo Lee
+1 for adding last step to catch all type and remove String case On Thu, Jan 28, 2016 at 6:26 PM DuyHai Doan wrote: > "I guess if List type of AngularObject is updated from front-end" --> It is > very possible now with my PR #678 > > I suggest that we add a last step to catch all types other tha

Re: Deserialization issue for AngularObject in RemoteInterpreterServer

2016-01-28 Thread DuyHai Doan
"I guess if List type of AngularObject is updated from front-end" --> It is very possible now with my PR #678 I suggest that we add a last step to catch all types other than String (or we can remove completely the String case) : value = gson.fromJson(object) On Thu, Jan 28, 2016 at 7:40 AM,

Re: Deserialization issue for AngularObject in RemoteInterpreterServer

2016-01-27 Thread moon soo Lee
Good catch. I guess if List type of AngularObject is updated from front-end, interpreter process can not not correctly deserialize it. So shell we add deserialize as a List before deserialize as a String? And right, value can be anything, not necessarily a String. On Thu, Jan 28, 2016 at 7:14 AM

Re: Deserialization issue for AngularObject in RemoteInterpreterServer

2016-01-27 Thread DuyHai Doan
"deserialize as a Map, and if it fails, it try to deserialize as a String (in the next statements)." --> But why a String for the last attempt of deserialization ? What will happen if I send a List as a value for the AngularObject ? After all, by looking at the definition of an AngularObject, th

Re: Deserialization issue for AngularObject in RemoteInterpreterServer

2016-01-27 Thread moon soo Lee
Hi, When deserializing AngularObject, RemoteInterpreterServer first try to deserialize as a Map, and if it fails, it try to deserialize as a String (in the next statements). So the exception should be muted, as it's just expected exception while guessing the type. I've made commit for muting thi

Deserialization issue for AngularObject in RemoteInterpreterServer

2016-01-27 Thread DuyHai Doan
I encountered the following exception when pushing an AngularObject to a remote interpreter: INFO [2016-01-27 15:25:41,433] ({pool-1-thread-4} RemoteInterpreterServer.java[angularObjectAdd]:598) - Exception in RemoteInterpreterServer while deserializing "James BOND" in angularObjectAdd, nolock co