Re: Review Request: patch for ZOOKEEPER-1560: Zookeeper client hangs on creation of large nodes

2012-10-25 Thread Patrick Hunt
> On Oct. 25, 2012, 9:23 p.m., Patrick Hunt wrote: > > src/java/main/org/apache/zookeeper/ClientCnxnSocketNIO.java, lines 133-134 > > > > > > why are we synchronizing this? it's already protected by outgoingQueue, > >

[jira] [Commented] (ZOOKEEPER-1552) Enable sync request processor in Observer

2012-10-25 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484694#comment-13484694 ] Hadoop QA commented on ZOOKEEPER-1552: -- -1 overall. Here are the results of test

Failed: ZOOKEEPER-1552 PreCommit Build #1240

2012-10-25 Thread Apache Jenkins Server
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1552 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1240/ ### ## LAST 60 LINES OF THE CONSOLE ### [

[jira] [Updated] (ZOOKEEPER-1552) Enable sync request processor in Observer

2012-10-25 Thread Thawan Kooburat (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thawan Kooburat updated ZOOKEEPER-1552: --- Attachment: ZOOKEEPER-1552.patch Updated patch with added comments for txnlog sem

Re: Review Request: patch for ZOOKEEPER-1560: Zookeeper client hangs on creation of large nodes

2012-10-25 Thread Skye Wanderman-Milne
> On Oct. 25, 2012, 9:23 p.m., Patrick Hunt wrote: > > src/java/main/org/apache/zookeeper/ClientCnxnSocketNIO.java, lines 133-134 > > > > > > why are we synchronizing this? it's already protected by outgoingQueue, > >

Re: Review Request: patch for ZOOKEEPER-1560: Zookeeper client hangs on creation of large nodes

2012-10-25 Thread Skye Wanderman-Milne
> On Oct. 25, 2012, 11:33 p.m., Skye Wanderman-Milne wrote: > > Looks like I'm no longer passing unit tests, please hold off on further > > reviews for now... Just kidding, I was testing the wrong branch :) - Skye --- This is an automa

Re: Review Request: patch for ZOOKEEPER-1560: Zookeeper client hangs on creation of large nodes

2012-10-25 Thread Patrick Hunt
> On Oct. 25, 2012, 9:23 p.m., Patrick Hunt wrote: > > src/java/main/org/apache/zookeeper/ClientCnxnSocketNIO.java, lines 133-134 > > > > > > why are we synchronizing this? it's already protected by outgoingQueue, > >

Re: Review Request: patch for ZOOKEEPER-1560: Zookeeper client hangs on creation of large nodes

2012-10-25 Thread Skye Wanderman-Milne
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7730/#review12800 --- Looks like I'm no longer passing unit tests, please hold off on furth

Re: Review Request: patch for ZOOKEEPER-1560: Zookeeper client hangs on creation of large nodes

2012-10-25 Thread Skye Wanderman-Milne
> On Oct. 25, 2012, 9:23 p.m., Patrick Hunt wrote: > > src/java/main/org/apache/zookeeper/ClientCnxnSocketNIO.java, lines 133-134 > > > > > > why are we synchronizing this? it's already protected by outgoingQueue, > >

Re: Review Request: patch for ZOOKEEPER-1560: Zookeeper client hangs on creation of large nodes

2012-10-25 Thread Skye Wanderman-Milne
> On Oct. 25, 2012, 9:36 p.m., Patrick Hunt wrote: > > src/java/main/org/apache/zookeeper/ClientCnxnSocketNIO.java, lines 160-161 > > > > > > hm, maybe this is ok given the clientTunneledAuthenticationInProgress > > ch

Re: Review Request: patch for ZOOKEEPER-1560: Zookeeper client hangs on creation of large nodes

2012-10-25 Thread Skye Wanderman-Milne
> On Oct. 25, 2012, 9:23 p.m., Patrick Hunt wrote: > > src/java/main/org/apache/zookeeper/ClientCnxnSocketNIO.java, lines 133-134 > > > > > > why are we synchronizing this? it's already protected by outgoingQueue, > >

Re: Review Request: patch for ZOOKEEPER-1560: Zookeeper client hangs on creation of large nodes

2012-10-25 Thread Ted Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7730/#review12796 --- src/java/main/org/apache/zookeeper/ClientCnxnSocketNIO.java

Re: Review Request: patch for ZOOKEEPER-1560: Zookeeper client hangs on creation of large nodes

2012-10-25 Thread Skye Wanderman-Milne
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7730/ --- (Updated Oct. 25, 2012, 10:51 p.m.) Review request for zookeeper, Patrick Hunt a

Re: Review Request: patch for ZOOKEEPER-1560: Zookeeper client hangs on creation of large nodes

2012-10-25 Thread Skye Wanderman-Milne
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7730/ --- (Updated Oct. 25, 2012, 10:38 p.m.) Review request for zookeeper, Patrick Hunt a

Re: Review Request: patch for ZOOKEEPER-1560: Zookeeper client hangs on creation of large nodes

2012-10-25 Thread Patrick Hunt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7730/#review12794 --- src/java/main/org/apache/zookeeper/ClientCnxnSocketNIO.java

Re: Review Request: patch for ZOOKEEPER-1560: Zookeeper client hangs on creation of large nodes

2012-10-25 Thread Patrick Hunt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7730/#review12792 --- There's a big problem here: if the packet went unsent (fully) then th

[jira] [Commented] (ZOOKEEPER-1568) multi should have a non-transaction version

2012-10-25 Thread Jimmy Xiang (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484256#comment-13484256 ] Jimmy Xiang commented on ZOOKEEPER-1568: For our use case, there is no depende

Success: ZOOKEEPER-1474 PreCommit Build #1239

2012-10-25 Thread Apache Jenkins Server
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1474 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1239/ ### ## LAST 60 LINES OF THE CONSOLE ### [

[jira] [Commented] (ZOOKEEPER-1474) Cannot build Zookeeper with IBM Java: use of Sun MXBean classes

2012-10-25 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484068#comment-13484068 ] Hadoop QA commented on ZOOKEEPER-1474: -- +1 overall. Here are the results of test

[jira] [Commented] (ZOOKEEPER-1474) Cannot build Zookeeper with IBM Java: use of Sun MXBean classes

2012-10-25 Thread Claude Falbriard (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484066#comment-13484066 ] Claude Falbriard commented on ZOOKEEPER-1474: - Dear colleagues, When doin

[jira] [Updated] (ZOOKEEPER-1474) Cannot build Zookeeper with IBM Java: use of Sun MXBean classes

2012-10-25 Thread Paulo Ricardo Paz Vital (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paulo Ricardo Paz Vital updated ZOOKEEPER-1474: --- Attachment: zookeeper-1474-v3.patch New version of same patch but

Re: Review Request: patch for ZOOKEEPER-1560: Zookeeper client hangs on creation of large nodes

2012-10-25 Thread Nikita Vetoshkin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7730/#review12760 --- src/java/main/org/apache/zookeeper/ClientCnxnSocketNIO.java