Re: Review Request 31277: ZOOKEEPER-2125: SSL on Netty client-server communication

> On March 7, 2015, 5:24 a.m., Rakesh R wrote: > > src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java, line > > 493 > > > > > > Can we extract this to a method to avoid duplication adding few more

Re: Review Request 31277: ZOOKEEPER-2125: SSL on Netty client-server communication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31277/#review75616 --- src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.jav

Re: Review Request 31277: ZOOKEEPER-2125: SSL on Netty client-server communication

> On March 6, 2015, 8:39 p.m., Rakesh R wrote: > > src/java/main/org/apache/zookeeper/common/X509Error.java, line 21 > > > > > > I prefer to use X509Exception instead of X509Error, can you rename this > > to X509Excep

Re: Review Request 31277: ZOOKEEPER-2125: SSL on Netty client-server communication

> On March 6, 2015, 8:39 p.m., Rakesh R wrote: > > src/java/main/org/apache/zookeeper/common/X509Error.java, line 21 > > > > > > I prefer to use X509Exception instead of X509Error, can you rename this > > to X509Excep

Failed: ZOOKEEPER-2125 PreCommit Build #2545

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2125 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2545/ ### ## LAST 60 LINES OF THE CONSOLE ### [

[jira] [Commented] (ZOOKEEPER-2125) SSL on Netty client-server communication

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14351315#comment-14351315 ] Hadoop QA commented on ZOOKEEPER-2125: -- -1 overall. Here are the results of test

Re: Review Request 31277: ZOOKEEPER-2125: SSL on Netty client-server communication

> On March 7, 2015, 1:08 a.m., Raul Gutierrez Segales wrote: > > src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java, line 849 > > > > > > can we get rid of these red tabs pls? Yes I did a few other p

Re: Review Request 31277: ZOOKEEPER-2125: SSL on Netty client-server communication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31277/#review75593 --- src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java

Re: Review Request 31277: ZOOKEEPER-2125: SSL on Netty client-server communication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31277/ --- (Updated March 7, 2015, 1:04 a.m.) Review request for zookeeper. Repository:

[jira] [Updated] (ZOOKEEPER-2125) SSL on Netty client-server communication

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hongchao Deng updated ZOOKEEPER-2125: - Attachment: ZOOKEEPER-2125.patch > SSL on Netty client-server communication >

[jira] [Commented] (ZOOKEEPER-2125) SSL on Netty client-server communication

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14351081#comment-14351081 ] Hongchao Deng commented on ZOOKEEPER-2125: -- Attached a new patch addressing R

[jira] [Updated] (ZOOKEEPER-2125) SSL on Netty client-server communication

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hongchao Deng updated ZOOKEEPER-2125: - Attachment: ZOOKEEPER-2125.patch > SSL on Netty client-server communication >

Re: Review Request 31277: ZOOKEEPER-2125: SSL on Netty client-server communication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31277/ --- (Updated March 6, 2015, 10:48 p.m.) Review request for zookeeper. Repository:

Re: Review Request 31277: ZOOKEEPER-2125: SSL on Netty client-server communication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31277/ --- (Updated March 6, 2015, 10:41 p.m.) Review request for zookeeper. Repository:

Re: Review Request 31277: ZOOKEEPER-2125: SSL on Netty client-server communication

> On March 6, 2015, 8:39 p.m., Rakesh R wrote: > > src/java/main/org/apache/zookeeper/ClientCnxnSocketNetty.java, line 356 > > > > > > do we need synchronization here? It's not obvious here. I am going to add some co

Re: Review Request 31277: ZOOKEEPER-2125: SSL on Netty client-server communication

> On March 6, 2015, 8:44 p.m., Rakesh R wrote: > > src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml, line 618 > > > > > > Netty usage is pluggable. SSL feature will be enabled when user user > > plugged-in

Re: Review Request 31277: ZOOKEEPER-2125: SSL on Netty client-server communication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31277/#review75542 --- src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml

Re: Review Request 31277: ZOOKEEPER-2125: SSL on Netty client-server communication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31277/#review75525 --- src/java/main/org/apache/zookeeper/ClientCnxnSocketNetty.java

ZooKeeper_branch35_jdk7 - Build # 223 - Still Failing

See https://builds.apache.org/job/ZooKeeper_branch35_jdk7/223/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 345223 lines...] [junit] 2015-03-06 15:50:42,323

ZooKeeper-trunk - Build # 2616 - Still Failing

See https://builds.apache.org/job/ZooKeeper-trunk/2616/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 352235 lines...] [junit] 2015-03-06 12:34:51,449 [myid:

ZooKeeper-trunk-solaris - Build # 961 - Still Failing

See https://builds.apache.org/job/ZooKeeper-trunk-solaris/961/ ### ## LAST 60 LINES OF THE CONSOLE ### Started by timer Building remotely on solaris1 (Solaris) in worksp

ZooKeeper_branch34_solaris - Build # 936 - Failure

See https://builds.apache.org/job/ZooKeeper_branch34_solaris/936/ ### ## LAST 60 LINES OF THE CONSOLE ### Started by timer Building remotely on solaris1 (Solaris) in wor