[jira] [Commented] (ZOOKEEPER-2193) reconfig command completes even if parameter is wrong obviously

2015-06-08 Thread Yasuhito Fukuda (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14578441#comment-14578441 ] Yasuhito Fukuda commented on ZOOKEEPER-2193: [~rgs] thanks for your review

Re: Review Request 35204: ZOOKEEPER-2193: reconfig command completes even if parameter is wrong obviously

2015-06-08 Thread Yasuhito Fukuda
> On 6月 9, 2015, 10:12 a.m., Raul Gutierrez Segales wrote: > > src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java, line 304 > > > > > > sounds like myAddrs could be constructed and saved from the > > con

Re: Review Request 35204: ZOOKEEPER-2193: reconfig command completes even if parameter is wrong obviously

2015-06-08 Thread Yasuhito Fukuda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35204/ --- (Updated 6月 9, 2015, 3:45 p.m.) Review request for zookeeper. Bugs: ZOOKEEPER

[jira] [Reopened] (ZOOKEEPER-2163) Introduce new ZNode type: container

2015-06-08 Thread Michi Mutsuzaki (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michi Mutsuzaki reopened ZOOKEEPER-2163: [~rgs] could you address Rakesh's comment? > Introduce new ZNode type: container >

Re: [VOTE] Apache ZooKeeper release 3.5.1-alpha candidate 2

2015-06-08 Thread Michi Mutsuzaki
https://issues.apache.org/jira/browse/ZOOKEEPER-2210 I'm cancelling the vote to address this issue. On Mon, Jun 8, 2015 at 9:25 PM, Michi Mutsuzaki wrote: > Thanks Raul for reporting. I'll take a look. > > On Mon, Jun 8, 2015 at 5:12 PM, Raúl Gutiérrez Segalés > wrote: >> I can't confirm this s

[jira] [Created] (ZOOKEEPER-2210) clock_gettime is not available in os x

2015-06-08 Thread Michi Mutsuzaki (JIRA)
Michi Mutsuzaki created ZOOKEEPER-2210: -- Summary: clock_gettime is not available in os x Key: ZOOKEEPER-2210 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2210 Project: ZooKeeper

Re: [VOTE] Apache ZooKeeper release 3.5.1-alpha candidate 2

2015-06-08 Thread Michi Mutsuzaki
Thanks Raul for reporting. I'll take a look. On Mon, Jun 8, 2015 at 5:12 PM, Raúl Gutiérrez Segalés wrote: > I can't confirm this since I don't have OS X, but I think the C library is > broken there because of this change: > > https://github.com/apache/zookeeper/commit/41c9fcb3ca09cd3d05e59fe47f0

Re: do we need a corresponding JIRA for each (github) PR?

2015-06-08 Thread Michi Mutsuzaki
We could also set up automated builds on pull requests. https://blogs.apache.org/infra/entry/github_pull_request_builds_now Also, I found this discussion regrading accepting github pull requests. https://issues.apache.org/jira/browse/LEGAL-156 On Mon, Jun 8, 2015 at 11:39 AM, Raúl Gutiérrez Se

[jira] [Commented] (ZOOKEEPER-2193) reconfig command completes even if parameter is wrong obviously

2015-06-08 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14578151#comment-14578151 ] Raul Gutierrez Segales commented on ZOOKEEPER-2193: --- Thanks for the

Re: Review Request 35204: ZOOKEEPER-2193: reconfig command completes even if parameter is wrong obviously

2015-06-08 Thread Raul Gutierrez Segales
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35204/#review87114 --- src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java

Re: [VOTE] Apache ZooKeeper release 3.5.1-alpha candidate 2

2015-06-08 Thread Raúl Gutiérrez Segalés
I can't confirm this since I don't have OS X, but I think the C library is broken there because of this change: https://github.com/apache/zookeeper/commit/41c9fcb3ca09cd3d05e59fe47f08ecf0b85532c8 (got some reports on #zookeeper today, not sure if that's a showstopper for the RC - probably it is).

[jira] [Commented] (ZOOKEEPER-2168) Add C APIs for new createContainer Methods

2015-06-08 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577645#comment-14577645 ] Raul Gutierrez Segales commented on ZOOKEEPER-2168: --- *pull request

[jira] [Commented] (ZOOKEEPER-2168) Add C APIs for new createContainer Methods

2015-06-08 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577644#comment-14577644 ] Raul Gutierrez Segales commented on ZOOKEEPER-2168: --- Commented on th

Re: do we need a corresponding JIRA for each (github) PR?

2015-06-08 Thread Raúl Gutiérrez Segalés
On 8 June 2015 at 11:21, Raúl Gutiérrez Segalés wrote: > On 8 June 2015 at 11:13, Patrick Hunt wrote: > >> Sounds reasonable. I have reached out personally in the past, but >> having it be automated would be good. Perhaps you can discuss with the >> apache infra team as to what is possible? >> >

[jira] [Commented] (ZOOKEEPER-2186) QuorumCnxManager#receiveConnection may crash with random input

2015-06-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577616#comment-14577616 ] ASF GitHub Bot commented on ZOOKEEPER-2186: --- Github user rgs1 closed the pul

[GitHub] zookeeper pull request: ZOOKEEPER-2186: QuorumCnxManager#receiveCo...

2015-06-08 Thread rgs1
Github user rgs1 closed the pull request at: https://github.com/apache/zookeeper/pull/30 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

Re: do we need a corresponding JIRA for each (github) PR?

2015-06-08 Thread Raúl Gutiérrez Segalés
On 8 June 2015 at 11:13, Patrick Hunt wrote: > Sounds reasonable. I have reached out personally in the past, but > having it be automated would be good. Perhaps you can discuss with the > apache infra team as to what is possible? > Yeah, I'll ping them and get back to this thread with what's pos

Re: do we need a corresponding JIRA for each (github) PR?

2015-06-08 Thread Patrick Hunt
Sounds reasonable. I have reached out personally in the past, but having it be automated would be good. Perhaps you can discuss with the apache infra team as to what is possible? Patrick On Mon, Jun 8, 2015 at 10:40 AM, Raúl Gutiérrez Segalés wrote: > One final note for posterity and people inte

Re: do we need a corresponding JIRA for each (github) PR?

2015-06-08 Thread Raúl Gutiérrez Segalés
One final note for posterity and people interested in using PRs for the review process at least (which I guess is ok) is that the ASF GitHub Bot will actually ping the associated JIRA if you reference it from your PR, i.e.; https://issues.apache.org/jira/browse/ZOOKEEPER-2168 https://github.com/ap

Re: do we need a corresponding JIRA for each (github) PR?

2015-06-08 Thread Raúl Gutiérrez Segalés
On 8 June 2015 at 10:07, Patrick Hunt wrote: > Keep in mind that filing the jira, attaching the patch file, etc... > are all demonstrating intent of the author to contribute the changes > under the apache license conditions. Jira is part of IP tracking. If > you file the jira for them we lose tha

Re: do we need a corresponding JIRA for each (github) PR?

2015-06-08 Thread Patrick Hunt
Keep in mind that filing the jira, attaching the patch file, etc... are all demonstrating intent of the author to contribute the changes under the apache license conditions. Jira is part of IP tracking. If you file the jira for them we lose that. We used to (olden days) have a specific checkbox in

Re: do we need a corresponding JIRA for each (github) PR?

2015-06-08 Thread Raúl Gutiérrez Segalés
Fair enough. I do agree that multiple sources of truth is not great (even if avoiding it means some copy/pasta between PRs and JIRAs). For now, I guess we can just ask people to open JIRAs, or file them for the casual contributors. Thanks all! -rgs On 8 June 2015 at 09:27, Patrick Hunt wrot

Re: do we need a corresponding JIRA for each (github) PR?

2015-06-08 Thread Patrick Hunt
Agree with the single record of truth. All changes currently go through Jira. It's part of the process and documented in the "how to contribute" page: https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute The git mirror at github is just that, a mirror of svn and meant to be a conv

Re: do we need a corresponding JIRA for each (github) PR?

2015-06-08 Thread Chris Nauroth
FWIW, the JIRA requirement is typical of Apache projects. Most projects have a strong preference that this single record of truth lies on Apache infrastructure, hence the use of Apache JIRA and Apache's hosted git rather than GitHub. The idea is that a full permanent record of all project decisio

[GitHub] zookeeper pull request: ZOOKEEPER-2168 - first pass at C changes f...

2015-06-08 Thread Randgalt
GitHub user Randgalt opened a pull request: https://github.com/apache/zookeeper/pull/33 ZOOKEEPER-2168 - first pass at C changes for containers The C build doesn't compile on my Mac and it's been ages since I wrote any C. So, this needs careful review. You can merge this pull reque

[jira] [Commented] (ZOOKEEPER-2168) Add C APIs for new createContainer Methods

2015-06-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577358#comment-14577358 ] ASF GitHub Bot commented on ZOOKEEPER-2168: --- GitHub user Randgalt opened a p

Re: do we need a corresponding JIRA for each (github) PR?

2015-06-08 Thread Camille Fournier
I personally don't think that having a single record of truth and asking people to use that record is asking too much. I'm not in favor at all of removing the requirement for tickets to track work. Perhaps if we were entirely in git hub it would be one thing but we aren't. C On Jun 8, 2015 12:42 A

ZooKeeper-trunk-jdk8 - Build # 408 - Still Failing

2015-06-08 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk-jdk8/408/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 374157 lines...] [junit] 2015-06-08 11:06:40,831 [m

ZooKeeper-trunk - Build # 2720 - Failure

2015-06-08 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk/2720/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 372771 lines...] [exec] Log Message Received: [2015-06

ZooKeeper_branch34_openjdk7 - Build # 901 - Failure

2015-06-08 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/901/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 213763 lines...] [junit] 2015-06-08 10:12:56

[jira] [Commented] (ZOOKEEPER-2193) reconfig command completes even if parameter is wrong obviously

2015-06-08 Thread Yasuhito Fukuda (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14576840#comment-14576840 ] Yasuhito Fukuda commented on ZOOKEEPER-2193: Hi [~michim], [~shralex], tha

Review Request 35204: ZOOKEEPER-2193: reconfig command completes even if parameter is wrong obviously

2015-06-08 Thread Yasuhito Fukuda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35204/ --- Review request for zookeeper. Bugs: ZOOKEEPER-2193 https://issues.apache.or

Re: Improving latency monitoring

2015-06-08 Thread Brian Brazil
Hi, Could I get a rough idea of when ZOOKEEPER-2093 might make it into an official release? I've currently got a hack doing a similar job, and want to plan for when I can clean it up. Thanks, Brian On 10 April 2015 at 11:42, Brian Brazil wrote: > On 10 April 2015 at 11:28, Rakesh R wrote: > >

[VOTE] Apache ZooKeeper release 3.5.1-alpha candidate 2

2015-06-08 Thread Michi Mutsuzaki
This is the third release candidate for 3.5.1-alpha. The full release notes is available at: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12326786 *** Please download, test and vote by June 26th 2015, 23:59 UTC+0. *** Source files: http://people.apache.org/~mi

[jira] [Commented] (ZOOKEEPER-2163) Introduce new ZNode type: container

2015-06-08 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14576743#comment-14576743 ] Rakesh R commented on ZOOKEEPER-2163: - Hi [~rgs] [~michim] Since we merged the fea

[jira] [Updated] (ZOOKEEPER-2202) Cluster crashes when reconfig adds an unreachable observer

2015-06-08 Thread Michi Mutsuzaki (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michi Mutsuzaki updated ZOOKEEPER-2202: --- Fix Version/s: (was: 3.5.1) 3.5.2 > Cluster crashes when re

[jira] [Updated] (ZOOKEEPER-2163) Introduce new ZNode type: container

2015-06-08 Thread Michi Mutsuzaki (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michi Mutsuzaki updated ZOOKEEPER-2163: --- Fix Version/s: (was: 3.5.0) 3.6.0 3.5.1

[jira] [Updated] (ZOOKEEPER-2209) A .NET C# version of ZooKeeper client 3.4.6 release

2015-06-08 Thread Shay Hazor (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shay Hazor updated ZOOKEEPER-2209: -- Remaining Estimate: 168h (was: 336h) Original Estimate: 168h (was: 336h) > A .NET C#

[jira] [Created] (ZOOKEEPER-2209) A .NET C# version of ZooKeeper client 3.4.6 release

2015-06-08 Thread Shay Hazor (JIRA)
Shay Hazor created ZOOKEEPER-2209: - Summary: A .NET C# version of ZooKeeper client 3.4.6 release Key: ZOOKEEPER-2209 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2209 Project: ZooKeeper