[jira] [Commented] (ZOOKEEPER-2193) reconfig command completes even if parameter is wrong obviously

2015-06-22 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14597232#comment-14597232 ] Raul Gutierrez Segales commented on ZOOKEEPER-2193: --- Patch lgtm, +1.

[jira] [Commented] (ZOOKEEPER-2193) reconfig command completes even if parameter is wrong obviously

2015-06-22 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14597216#comment-14597216 ] Hadoop QA commented on ZOOKEEPER-2193: -- -1 overall. Here are the results of test

[jira] [Commented] (ZOOKEEPER-2172) Cluster crashes when reconfig a new node as a participant

2015-06-22 Thread Ziyou Wang (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14597203#comment-14597203 ] Ziyou Wang commented on ZOOKEEPER-2172: --- Thanks for looking on this. I always su

[jira] [Updated] (ZOOKEEPER-2172) Cluster crashes when reconfig a new node as a participant

2015-06-22 Thread Ziyou Wang (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ziyou Wang updated ZOOKEEPER-2172: -- Attachment: zoo-4-3.log zoo-4-2.log zoo-4-1.log Add log to r

[jira] [Commented] (ZOOKEEPER-2193) reconfig command completes even if parameter is wrong obviously

2015-06-22 Thread Yasuhito Fukuda (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14597155#comment-14597155 ] Yasuhito Fukuda commented on ZOOKEEPER-2193: Thank you for your review. I

[jira] [Updated] (ZOOKEEPER-2193) reconfig command completes even if parameter is wrong obviously

2015-06-22 Thread Yasuhito Fukuda (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yasuhito Fukuda updated ZOOKEEPER-2193: --- Attachment: ZOOKEEPER-2193-v8.patch > reconfig command completes even if parameter

Re: Review Request 35204: ZOOKEEPER-2193: reconfig command completes even if parameter is wrong obviously

2015-06-22 Thread Yasuhito Fukuda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35204/ --- (Updated 6月 23, 2015, 1:39 p.m.) Review request for zookeeper. Bugs: ZOOKEEPE

[jira] [Commented] (ZOOKEEPER-2218) Close IO Streams in finally block

2015-06-22 Thread Tang Xinye (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14597135#comment-14597135 ] Tang Xinye commented on ZOOKEEPER-2218: --- oops! still learning, sorry for the mis

[jira] [Updated] (ZOOKEEPER-1792) Observers don't need to keep an in-memory copy of last commited proposals

2015-06-22 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raul Gutierrez Segales updated ZOOKEEPER-1792: -- Summary: Observers don't need to keep an in-memory copy of last commi

[jira] [Commented] (ZOOKEEPER-2218) Close IO Streams in finally block

2015-06-22 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14597125#comment-14597125 ] Raul Gutierrez Segales commented on ZOOKEEPER-2218: --- Thanks for the

[jira] [Reopened] (ZOOKEEPER-2218) Close IO Streams in finally block

2015-06-22 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raul Gutierrez Segales reopened ZOOKEEPER-2218: --- > Close IO Streams in finally block >

[jira] [Resolved] (ZOOKEEPER-2218) Close IO Streams in finally block

2015-06-22 Thread Tang Xinye (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tang Xinye resolved ZOOKEEPER-2218. --- Resolution: Fixed Release Note: Place the close method in the finally clause, so we c

[jira] [Commented] (ZOOKEEPER-2218) Close IO Streams in finally block

2015-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14597030#comment-14597030 ] ASF GitHub Bot commented on ZOOKEEPER-2218: --- GitHub user sugartxy opened a p

[GitHub] zookeeper pull request: #ZOOKEEPER-2218 Close IO Streams in finall...

2015-06-22 Thread sugartxy
GitHub user sugartxy opened a pull request: https://github.com/apache/zookeeper/pull/36 #ZOOKEEPER-2218 Close IO Streams in finally block Place the close method in the finally clause, so we can ensure it always runs regardless of how the method exits. You can merge this pull reques

[jira] [Created] (ZOOKEEPER-2218) Close IO Streams in finally block

2015-06-22 Thread Tang Xinye (JIRA)
Tang Xinye created ZOOKEEPER-2218: - Summary: Close IO Streams in finally block Key: ZOOKEEPER-2218 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2218 Project: ZooKeeper Issue Type: Bug

Re: Design document

2015-06-22 Thread sajjad rizvi
Thank you Jordan, these are good pointers. On Mon, Jun 22, 2015 at 4:37 PM, Jordan Zimmerman < jor...@jordanzimmerman.com> wrote: > https://cwiki.apache.org/confluence/display/ZOOKEEPER/FAQ > > http://web.stanford.edu/class/cs347/reading/zab.pdf > > Start with these. > > -Jordan > > > > On June 2

Re: Design document

2015-06-22 Thread Jordan Zimmerman
https://cwiki.apache.org/confluence/display/ZOOKEEPER/FAQ http://web.stanford.edu/class/cs347/reading/zab.pdf Start with these. -Jordan On June 22, 2015 at 3:34:24 PM, sajjad rizvi (sm3ri...@uwaterloo.ca) wrote: Hi, I am just curious, is there any design document available to help in unde

Design document

2015-06-22 Thread sajjad rizvi
Hi, I am just curious, is there any design document available to help in understanding the ZooKeeper code? In a research project, I have to make some significant changes in the quorum part of the code. Although the code is very elegant and self descriptive, any design document will be very helpful

[jira] [Commented] (ZOOKEEPER-1907) Improve Thread handling

2015-06-22 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14595965#comment-14595965 ] Rakesh R commented on ZOOKEEPER-1907: - As per the [discussion|https://issues.apac

[jira] [Commented] (ZOOKEEPER-602) log all exceptions not caught by ZK threads

2015-06-22 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14595961#comment-14595961 ] Rakesh R commented on ZOOKEEPER-602: Thank you [~rgs] for the reviews and commit. A

[jira] [Reopened] (ZOOKEEPER-1907) Improve Thread handling

2015-06-22 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh R reopened ZOOKEEPER-1907: - > Improve Thread handling > --- > > Key: ZOOKEEPER-1907 >

[jira] [Commented] (ZOOKEEPER-2210) clock_gettime is not available in os x

2015-06-22 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14595750#comment-14595750 ] Hudson commented on ZOOKEEPER-2210: --- SUCCESS: Integrated in ZooKeeper-trunk #2734 (S