[jira] [Commented] (ZOOKEEPER-2841) ZooKeeper public include files leak porting changes

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16091117#comment-16091117 ] ASF GitHub Bot commented on ZOOKEEPER-2841: --- Github user hanm commented on the issue:

[GitHub] zookeeper issue #311: ZOOKEEPER-2841: ZooKeeper public include files leak po...

Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/311 @andschwa branch-3.4 is the stable branch that we actually ship - I assume your use case (Mesos on windows?) will integrate with that version as well. --- If your project is set up for it, you can

[jira] [Commented] (ZOOKEEPER-2841) ZooKeeper public include files leak porting changes

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16091116#comment-16091116 ] ASF GitHub Bot commented on ZOOKEEPER-2841: --- Github user hanm commented on the issue:

[GitHub] zookeeper issue #306: ZOOKEEPER-2841: ZooKeeper public include files leak po...

Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/306 Thanks for the extra efforts on integration testing, @andschwa. I'll commit this tomorrow. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[jira] [Commented] (ZOOKEEPER-2770) ZooKeeper slow operation log

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16091065#comment-16091065 ] ASF GitHub Bot commented on ZOOKEEPER-2770: --- Github user tdunning commented on a diff in the

[GitHub] zookeeper pull request #307: ZOOKEEPER-2770 ZooKeeper slow operation log

Github user tdunning commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/307#discussion_r127877506 --- Diff: src/java/test/org/apache/zookeeper/server/ZooKeeperServerMainTest.java --- @@ -138,14 +145,56 @@ void delete(File f) throws IOException {

ZooKeeper-trunk-openjdk7 - Build # 1548 - Still Failing

See https://builds.apache.org/job/ZooKeeper-trunk-openjdk7/1548/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 62.44 MB...] [junit] 2017-07-18 03:00:58,359

Success: ZOOKEEPER- PreCommit Build #884

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/884/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 72.90 MB...] [exec]

[jira] [Commented] (ZOOKEEPER-2841) ZooKeeper public include files leak porting changes

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16090919#comment-16090919 ] Hadoop QA commented on ZOOKEEPER-2841: -- +1 overall. GitHub Pull Request Build +1

[jira] [Commented] (ZOOKEEPER-2841) ZooKeeper public include files leak porting changes

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16090756#comment-16090756 ] ASF GitHub Bot commented on ZOOKEEPER-2841: --- Github user andschwa commented on the issue:

[GitHub] zookeeper issue #311: ZOOKEEPER-2841: ZooKeeper public include files leak po...

Github user andschwa commented on the issue: https://github.com/apache/zookeeper/pull/311 Hm... it might not backport so easily to `branch-3.4`. Let me know how badly it's wanted. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[jira] [Commented] (ZOOKEEPER-2841) ZooKeeper public include files leak porting changes

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16090709#comment-16090709 ] ASF GitHub Bot commented on ZOOKEEPER-2841: --- Github user andschwa commented on the issue:

[GitHub] zookeeper issue #311: ZOOKEEPER-2841: ZooKeeper public include files leak po...

Github user andschwa commented on the issue: https://github.com/apache/zookeeper/pull/311 @hanm this backports #306 to `branch-3.5`. I rebuilt and retested, all looks good. Since original branch came from `master` the version was already what I believe to be correct at `3.5.3`. ---

[jira] [Commented] (ZOOKEEPER-2841) ZooKeeper public include files leak porting changes

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16090704#comment-16090704 ] ASF GitHub Bot commented on ZOOKEEPER-2841: --- GitHub user andschwa opened a pull request:

[GitHub] zookeeper pull request #311: ZOOKEEPER-2841: ZooKeeper public include files ...

GitHub user andschwa opened a pull request: https://github.com/apache/zookeeper/pull/311 ZOOKEEPER-2841: ZooKeeper public include files leak porting change This patch primarily adds a cross-platform CMake build system. This is in addition to the Autotools system on Linux, until

ZooKeeper_branch34_openjdk7 - Build # 1578 - Failure

See https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1578/ ### ## LAST 60 LINES OF THE CONSOLE ### Started by timer [EnvInject] - Loading node environment

[jira] [Commented] (ZOOKEEPER-2841) ZooKeeper public include files leak porting changes

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16090446#comment-16090446 ] ASF GitHub Bot commented on ZOOKEEPER-2841: --- Github user andschwa commented on the issue:

[GitHub] zookeeper issue #306: ZOOKEEPER-2841: ZooKeeper public include files leak po...

Github user andschwa commented on the issue: https://github.com/apache/zookeeper/pull/306 I managed to get the Mesos unit tests for ZooKeeper ported to our CMake system, which much more thoroughly exercises the C client. I've integrated this patch and the CMake system with the Mesos

ZooKeeper-trunk-jdk8 - Build # 1131 - Still Failing

See https://builds.apache.org/job/ZooKeeper-trunk-jdk8/1131/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 64.45 MB...] [junit] 2017-07-17 19:07:52,373

ZooKeeper_branch35_openjdk7 - Build # 603 - Still Failing

See https://builds.apache.org/job/ZooKeeper_branch35_openjdk7/603/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 65.90 MB...] [junit]

[jira] [Commented] (ZOOKEEPER-2770) ZooKeeper slow operation log

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16090088#comment-16090088 ] ASF GitHub Bot commented on ZOOKEEPER-2770: --- Github user karanmehta93 commented on a diff in

[GitHub] zookeeper pull request #307: ZOOKEEPER-2770 ZooKeeper slow operation log

Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/307#discussion_r127762613 --- Diff: src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java --- @@ -460,11 +464,21 @@ public void processRequest(Request request)

[jira] [Commented] (ZOOKEEPER-2770) ZooKeeper slow operation log

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16090045#comment-16090045 ] ASF GitHub Bot commented on ZOOKEEPER-2770: --- Github user karanmehta93 commented on a diff in

[GitHub] zookeeper pull request #307: ZOOKEEPER-2770 ZooKeeper slow operation log

Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/307#discussion_r127757305 --- Diff: src/java/test/org/apache/zookeeper/server/ZooKeeperServerMainTest.java --- @@ -138,14 +145,56 @@ void delete(File f) throws IOException {

ZooKeeper_branch35_jdk7 - Build # 1046 - Still Failing

See https://builds.apache.org/job/ZooKeeper_branch35_jdk7/1046/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 65.42 MB...] [junit] 2017-07-17 15:55:30,368

[jira] [Commented] (ZOOKEEPER-2755) Allow to subclass ClientCnxnSocketNetty and NettyServerCnxn in order to use Netty Local transport

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16089952#comment-16089952 ] ASF GitHub Bot commented on ZOOKEEPER-2755: --- Github user eolivelli commented on the issue:

[GitHub] zookeeper issue #227: ZOOKEEPER-2755 Allow to subclass ClientCnxnSocketNetty...

Github user eolivelli commented on the issue: https://github.com/apache/zookeeper/pull/227 @ivankelly thank you for your time > The commit message explains what the patch is doing, but not why. The reason I'm pushing back a lot on this, is that I think it adds indirection and

[jira] [Commented] (ZOOKEEPER-2770) ZooKeeper slow operation log

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16089846#comment-16089846 ] ASF GitHub Bot commented on ZOOKEEPER-2770: --- Github user tdunning commented on a diff in the

[GitHub] zookeeper pull request #307: ZOOKEEPER-2770 ZooKeeper slow operation log

Github user tdunning commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/307#discussion_r127711561 --- Diff: src/java/test/org/apache/zookeeper/server/ZooKeeperServerMainTest.java --- @@ -138,14 +145,56 @@ void delete(File f) throws IOException {

[jira] [Commented] (ZOOKEEPER-2755) Allow to subclass ClientCnxnSocketNetty and NettyServerCnxn in order to use Netty Local transport

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16089702#comment-16089702 ] ASF GitHub Bot commented on ZOOKEEPER-2755: --- Github user ivankelly commented on the issue:

[GitHub] zookeeper issue #227: ZOOKEEPER-2755 Allow to subclass ClientCnxnSocketNetty...

Github user ivankelly commented on the issue: https://github.com/apache/zookeeper/pull/227 @eolivelli Sorry for taking so long to respond, I was out of town. The commit message explains what the patch is doing, but not why. The reason I'm pushing back a lot on this, is